Re: [PATCH] os-prober: Fix translating device to mach format
Hello, Daniel Kiper, on mer. 14 mars 2018 13:58:51 +0100, wrote: > On Sun, Mar 11, 2018 at 09:58:20PM +0100, Samuel Thibault wrote: > > "hostdisk//dev/sda,msdos1", i.e. not something we can translate. We can > > Are you sure that this happens upstream? It happens with plain build from git yes. > On which arch? Linux x86, simply > Could you provide more details in the commit message? Done so in v2. Samuel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH] os-prober: Fix translating device to mach format
On Sun, Mar 11, 2018 at 09:58:20PM +0100, Samuel Thibault wrote: > grub-probe would currently would currently print e.g. s/would currently would currently/would currently/? > "hostdisk//dev/sda,msdos1", i.e. not something we can translate. We can Are you sure that this happens upstream? On which arch? Could you provide more details in the commit message? Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
[PATCH] os-prober: Fix translating device to mach format
grub-probe would currently would currently print e.g.
"hostdisk//dev/sda,msdos1", i.e. not something we can translate. We can
instead use compatibility_hint which have more well-defined format.
Signed-off-by: Samuel Thibault
---
util/grub.d/30_os-prober.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/util/grub.d/30_os-prober.in b/util/grub.d/30_os-prober.in
index 515a68c7a..38444fe65 100644
--- a/util/grub.d/30_os-prober.in
+++ b/util/grub.d/30_os-prober.in
@@ -297,8 +297,8 @@ menuentry '$(echo "${LONGNAME} $onstr" | grub_quote)'
--class hurd --class gnu -
EOF
save_default_entry | grub_add_tab
prepare_grub_to_access_device ${DEVICE} | grub_add_tab
- grub_device="`${grub_probe} --device ${DEVICE} --target=drive`"
- mach_device="`echo "${grub_device}" | sed -e
's/(\(hd.*\),msdos\(.*\))/\1s\2/'`"
+ grub_device="`${grub_probe} --device ${DEVICE}
--target=compatibility_hint`"
+ mach_device="`echo "${grub_device}" | sed -e
's/\(hd.*\),msdos\(.*\)/\1s\2/'`"
grub_fs="`${grub_probe} --device ${DEVICE} --target=fs`"
case "${grub_fs}" in
*fs)hurd_fs="${grub_fs}" ;;
--
2.16.1
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
