Re: [PATCH] 00_header: Omit loading efi_uga on non-x86 EFI platforms

2026-01-29 Thread Michael Chang via Grub-devel
On Tue, Jan 27, 2026 at 12:13:25PM +0100, Gerd Hoffmann via Grub-devel wrote:
> On Tue, Jan 27, 2026 at 10:05:27AM +0800, Michael Chang wrote:
> > On Mon, Jan 26, 2026 at 11:13:16AM +0100, Gerd Hoffmann wrote:
> > >   Hi,
> > > 
> > > > However the efi_uga module is only enabled for x86_64-efi and i386-efi.
> > > > The script should therefore check the CPU target before attempting to
> > > > load it.
> > > 
> > > Or just remove efi_uga?
> > > 
> > > tianocore has removed uga support from the source tree last year, noting
> > > that "The UGA I/O and Draw protocols are deprecated since UEFI 2.0 was
> > > introduced".  UEFI 2.0 spec was released in January 2006.
> > > 
> > > https://github.com/tianocore/edk2/pull/11200
> > 
> > Thanks for the info. Yes, it looks like a viable decision to remove it
> > as well. However the patch is intended as a quick fix for the released
> > 2.14 branch, where efi_uga is still a supported module.
> > 
> > Perhaps a separate drop request to drop it in the next GRUB release
> > would be better, and would also allow more time to collect feedback.
> 
> Well, the removal can be staged in two steps, first remove from the
> config, and in case nobody misses it for one release cycle purge it
> completely from the code base.
> 
> IMHO removal from the config is fine even for the 2.14 branch.

I just did a quick check by removing all the efi_* modules from the
config and the terminal falls back to text menu gracefully. So it seems
to me this is not too much hassle for users: even if the efi video
drivers missing, the system still boots and they can add the modules
back to the config later.

So I'm not against the idea, but I'd like to hear more from Daniel if
he's OK with this. :)

Thanks,
Michael

> 
> take care,
>   Gerd
> 
> 
> ___
> Grub-devel mailing list
> [email protected]
> https://lists.gnu.org/mailman/listinfo/grub-devel

___
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: [PATCH] 00_header: Omit loading efi_uga on non-x86 EFI platforms

2026-01-27 Thread Gerd Hoffmann via Grub-devel
On Tue, Jan 27, 2026 at 10:05:27AM +0800, Michael Chang wrote:
> On Mon, Jan 26, 2026 at 11:13:16AM +0100, Gerd Hoffmann wrote:
> >   Hi,
> > 
> > > However the efi_uga module is only enabled for x86_64-efi and i386-efi.
> > > The script should therefore check the CPU target before attempting to
> > > load it.
> > 
> > Or just remove efi_uga?
> > 
> > tianocore has removed uga support from the source tree last year, noting
> > that "The UGA I/O and Draw protocols are deprecated since UEFI 2.0 was
> > introduced".  UEFI 2.0 spec was released in January 2006.
> > 
> > https://github.com/tianocore/edk2/pull/11200
> 
> Thanks for the info. Yes, it looks like a viable decision to remove it
> as well. However the patch is intended as a quick fix for the released
> 2.14 branch, where efi_uga is still a supported module.
> 
> Perhaps a separate drop request to drop it in the next GRUB release
> would be better, and would also allow more time to collect feedback.

Well, the removal can be staged in two steps, first remove from the
config, and in case nobody misses it for one release cycle purge it
completely from the code base.

IMHO removal from the config is fine even for the 2.14 branch.

take care,
  Gerd


___
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: [PATCH] 00_header: Omit loading efi_uga on non-x86 EFI platforms

2026-01-26 Thread Michael Chang via Grub-devel
On Mon, Jan 26, 2026 at 11:13:16AM +0100, Gerd Hoffmann wrote:
>   Hi,
> 
> > However the efi_uga module is only enabled for x86_64-efi and i386-efi.
> > The script should therefore check the CPU target before attempting to
> > load it.
> 
> Or just remove efi_uga?
> 
> tianocore has removed uga support from the source tree last year, noting
> that "The UGA I/O and Draw protocols are deprecated since UEFI 2.0 was
> introduced".  UEFI 2.0 spec was released in January 2006.
> 
> https://github.com/tianocore/edk2/pull/11200

Thanks for the info. Yes, it looks like a viable decision to remove it
as well. However the patch is intended as a quick fix for the released
2.14 branch, where efi_uga is still a supported module.

Perhaps a separate drop request to drop it in the next GRUB release
would be better, and would also allow more time to collect feedback.

Thanks,
Michael

___
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: [PATCH] 00_header: Omit loading efi_uga on non-x86 EFI platforms

2026-01-26 Thread Gerd Hoffmann via Grub-devel
  Hi,

> However the efi_uga module is only enabled for x86_64-efi and i386-efi.
> The script should therefore check the CPU target before attempting to
> load it.

Or just remove efi_uga?

tianocore has removed uga support from the source tree last year, noting
that "The UGA I/O and Draw protocols are deprecated since UEFI 2.0 was
introduced".  UEFI 2.0 spec was released in January 2006.

https://github.com/tianocore/edk2/pull/11200

take care,
  Gerd


___
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel