Re: [PATCH] build: Add grub-core/tests/crypto_cipher_mode_vectors.h file to EXTRA_DIST

2026-01-14 Thread Srish Srinivasan


On 1/13/26 11:30 PM, Daniel Kiper via Grub-devel wrote:

This file was not added to EXTRA_DIST during test creation.

Fixes: 51ebc6f67 (tests: Add functional tests for ecb/cbc helpers)

Signed-off-by: Daniel Kiper 
---
  conf/Makefile.extra-dist | 1 +
  1 file changed, 1 insertion(+)

diff --git a/conf/Makefile.extra-dist b/conf/Makefile.extra-dist
index 288ba1f87..d22b6c862 100644
--- a/conf/Makefile.extra-dist
+++ b/conf/Makefile.extra-dist
@@ -72,6 +72,7 @@ EXTRA_DIST += grub-core/lib/libtasn1
  EXTRA_DIST += $(shell find $(top_srcdir)/include -name '*.h')
  EXTRA_DIST += $(shell find $(top_srcdir)/grub-core/lib -name '*.h')
  EXTRA_DIST += grub-core/efiemu/runtime/config.h
+EXTRA_DIST += grub-core/tests/crypto_cipher_mode_vectors.h
  EXTRA_DIST += grub-core/tests/asn1/asn1_test.h
  EXTRA_DIST += $(shell find $(top_srcdir)/grub-core/tests/asn1/tests -name 
'*.h')
  EXTRA_DIST += $(shell find 
$(top_srcdir)/grub-core/commands/tpm2_key_protector -name '*.h')



Reviewed-by: Srish Srinivasan 

Thank You,
Srish.


___
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: [PATCH] build: Add grub-core/tests/crypto_cipher_mode_vectors.h file to EXTRA_DIST

2026-01-13 Thread Sudhakar Kuppusamy


> On 13 Jan 2026, at 11:30 PM, Daniel Kiper  wrote:
> 
> This file was not added to EXTRA_DIST during test creation.
> 
> Fixes: 51ebc6f67 (tests: Add functional tests for ecb/cbc helpers)
> 
> Signed-off-by: Daniel Kiper 

Reviewed-by: Sudhakar Kuppusamy 

Thanks,
Sudhakar  
> ---
> conf/Makefile.extra-dist | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/conf/Makefile.extra-dist b/conf/Makefile.extra-dist
> index 288ba1f87..d22b6c862 100644
> --- a/conf/Makefile.extra-dist
> +++ b/conf/Makefile.extra-dist
> @@ -72,6 +72,7 @@ EXTRA_DIST += grub-core/lib/libtasn1
> EXTRA_DIST += $(shell find $(top_srcdir)/include -name '*.h')
> EXTRA_DIST += $(shell find $(top_srcdir)/grub-core/lib -name '*.h')
> EXTRA_DIST += grub-core/efiemu/runtime/config.h
> +EXTRA_DIST += grub-core/tests/crypto_cipher_mode_vectors.h
> EXTRA_DIST += grub-core/tests/asn1/asn1_test.h
> EXTRA_DIST += $(shell find $(top_srcdir)/grub-core/tests/asn1/tests -name 
> '*.h')
> EXTRA_DIST += $(shell find 
> $(top_srcdir)/grub-core/commands/tpm2_key_protector -name '*.h')
> -- 
> 2.11.0
> 


___
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: [PATCH] build: Add grub-core/tests/crypto_cipher_mode_vectors.h file to EXTRA_DIST

2026-01-13 Thread Alec Brown via Grub-devel
On Tue, Jan 13, 2026 at 1:01 PM, Daniel Kiper  wrote:
> This file was not added to EXTRA_DIST during test creation.
> 
> Fixes: 51ebc6f67 (tests: Add functional tests for ecb/cbc helpers)
> 
> Signed-off-by: Daniel Kiper 
> ---
>  conf/Makefile.extra-dist | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/conf/Makefile.extra-dist b/conf/Makefile.extra-dist
> index 288ba1f87..d22b6c862 100644
> --- a/conf/Makefile.extra-dist
> +++ b/conf/Makefile.extra-dist
> @@ -72,6 +72,7 @@ EXTRA_DIST += grub-core/lib/libtasn1
>  EXTRA_DIST += $(shell find $(top_srcdir)/include -name '*.h')
>  EXTRA_DIST += $(shell find $(top_srcdir)/grub-core/lib -name '*.h')
>  EXTRA_DIST += grub-core/efiemu/runtime/config.h
> +EXTRA_DIST += grub-core/tests/crypto_cipher_mode_vectors.h
>  EXTRA_DIST += grub-core/tests/asn1/asn1_test.h
>  EXTRA_DIST += $(shell find $(top_srcdir)/grub-core/tests/asn1/tests -name 
> '*.h')
>  EXTRA_DIST += $(shell find 
> $(top_srcdir)/grub-core/commands/tpm2_key_protector -name '*.h')
> --
> 2.11.0

This patch LGTM!

Reviewed-by: Alec Brown 

Alec Brown

___
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel