Re: [PATCH v1] http: return error on unhandled HTTP error responses

2020-04-06 Thread Olaf Hering
Am Thu, 26 Mar 2020 20:36:47 +0100 schrieb Daniel Kiper : > May I ask you to do the change for 404 and test it too? If it works > please post a new patch. I think "http" needs more surgery. It happens to work despite the (apparently) bogus error handling. But I do not have time to work on this

Re: [PATCH v1] http: return error on unhandled HTTP error responses

2020-04-03 Thread Daniel Kiper
On Thu, Mar 26, 2020 at 08:36:47PM +0100, Daniel Kiper wrote: > On Wed, Mar 25, 2020 at 08:30:38PM +0100, Olaf Hering wrote: > > Am Wed, 25 Mar 2020 19:55:47 +0100 > > schrieb Daniel Kiper : > > > > > Should not we do the same for 404, file not found, a few lines above? > > > > Maybe. For some

Re: [PATCH v1] http: return error on unhandled HTTP error responses

2020-03-26 Thread Daniel Kiper
On Wed, Mar 25, 2020 at 08:30:38PM +0100, Olaf Hering wrote: > Am Wed, 25 Mar 2020 19:55:47 +0100 > schrieb Daniel Kiper : > > > Should not we do the same for 404, file not found, a few lines above? > > Maybe. For some reason a 404 returns quickly, while a 400 will request > the file 4 times. With

Re: [PATCH v1] http: return error on unhandled HTTP error responses

2020-03-25 Thread Olaf Hering
Am Wed, 25 Mar 2020 19:55:47 +0100 schrieb Daniel Kiper : > Should not we do the same for 404, file not found, a few lines above? Maybe. For some reason a 404 returns quickly, while a 400 will request the file 4 times. With this patch there is still some delay, but the request is sent just

Re: [PATCH v1] http: return error on unhandled HTTP error responses

2020-03-25 Thread Daniel Kiper
On Tue, Mar 17, 2020 at 07:56:14PM +0100, Olaf Hering wrote: > A http transfer will hang if an unhandled error is returned. > The error branch returns the value zero, which is not expected by the caller. > > Signed-off-by: Olaf Hering > --- > grub-core/net/http.c | 2 +- > 1 file changed, 1