Re: disk/mdraid1x_linux.c:181:15: warning: array subscript ...

2020-03-25 Thread Michael Chang
On Thu, Mar 26, 2020 at 12:13:11PM +0800, Michael Chang wrote: > On Wed, Mar 25, 2020 at 07:35:27PM +0100, Daniel Kiper wrote: > > On Wed, Mar 25, 2020 at 03:27:28PM +0800, Michael Chang wrote: > > > On Tue, Mar 24, 2020 at 06:54:43PM +0100, Thomas Schmitt wrote: > > [snip] > > > > >From 8666468a

Re: disk/mdraid1x_linux.c:181:15: warning: array subscript ...

2020-03-25 Thread Michael Chang
On Wed, Mar 25, 2020 at 07:35:27PM +0100, Daniel Kiper wrote: > On Wed, Mar 25, 2020 at 03:27:28PM +0800, Michael Chang wrote: > > On Tue, Mar 24, 2020 at 06:54:43PM +0100, Thomas Schmitt wrote: [snip] > > >From 8666468ac1a35f0678672de5c89a3f062d1aeb39 Mon Sep 17 00:00:00 2001 > > From: Michael C

Re: disk/mdraid1x_linux.c:181:15: warning: array subscript ...

2020-03-25 Thread PGNet Dev
On 3/25/20 8:29 PM, Michael Chang wrote: >> with your patches, no immediate mdraid1x or zfs build errors > > Thanks a lot for your test and validation. > >> one does surface, now, for ntfscomp ... > > I am also using openSUSE, somehow I didn't have the ntfscomp build error > on my gcc-10 build t

Re: disk/mdraid1x_linux.c:181:15: warning: array subscript ...

2020-03-25 Thread Michael Chang
On Wed, Mar 25, 2020 at 08:35:58AM -0700, PGNet Dev wrote: > On 3/25/20 12:27 AM, Michael Chang wrote: > > It would be great if you can help to test patch to solve the build > > problem for gcc-10 in your system or not. > > with your patches, no immediate mdraid1x or zfs build errors Thanks a lot

Re: disk/mdraid1x_linux.c:181:15: warning: array subscript ...

2020-03-25 Thread Michael Chang
On Wed, Mar 25, 2020 at 12:13:49PM +0100, Thomas Schmitt wrote: > Hi, > > Michael Chang wrote in patch 2/2: > > ../../grub-core/fs/zfs/zfs.c:2263:44: error: array subscript '' is > > outside the bounds of an interior zero-length array 'grub_uint16_t[0]' {aka > > 'short unsigned int[0]'} [-Werror=z

Re: disk/mdraid1x_linux.c:181:15: warning: array subscript ...

2020-03-25 Thread Daniel Kiper
On Wed, Mar 25, 2020 at 03:27:28PM +0800, Michael Chang wrote: > On Tue, Mar 24, 2020 at 06:54:43PM +0100, Thomas Schmitt wrote: > > Hi, > > > > i wrote: > > > >(char *) &sb.dev_roles - (char *) sb > > > >+ grub_le_to_cpu32 (sb.dev_number) * > > > > sizeof(grub_uint

Re: disk/mdraid1x_linux.c:181:15: warning: array subscript ...

2020-03-25 Thread Paul Menzel
Dear PGNet Dev, Am 25.03.20 um 16:54 schrieb PGNet Dev: On 3/25/20 8:52 AM, Paul Menzel wrote: Thanks, but please follow the mailing list netiquette I was responding to a question asked by a developer in THIS thread Yes, the question was, if the reported(?) build issues were fixed, and yo

Re: disk/mdraid1x_linux.c:181:15: warning: array subscript ...

2020-03-25 Thread PGNet Dev
On 3/25/20 8:52 AM, Paul Menzel wrote: > Thanks, but please follow the mailing list netiquette I was responding to a question asked by a developer in THIS thread ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-

Re: disk/mdraid1x_linux.c:181:15: warning: array subscript ...

2020-03-25 Thread Paul Menzel
Dear PGNet Dev, Am 25.03.20 um 16:35 schrieb PGNet Dev: […] with your patches, no immediate mdraid1x or zfs build errors one does surface, now, for ntfscomp ... […] Thanks, but please follow the mailing list netiquette, and start a new discussion thread with a descriptive subject line.

Re: disk/mdraid1x_linux.c:181:15: warning: array subscript ...

2020-03-25 Thread PGNet Dev
On 3/25/20 12:27 AM, Michael Chang wrote: > It would be great if you can help to test patch to solve the build > problem for gcc-10 in your system or not. with your patches, no immediate mdraid1x or zfs build errors one does surface, now, for ntfscomp ... gcc --version gcc (SUSE Linux) 10

Re: disk/mdraid1x_linux.c:181:15: warning: array subscript ...

2020-03-25 Thread Thomas Schmitt
Hi, Michael Chang wrote in patch 2/2: > ../../grub-core/fs/zfs/zfs.c:2263:44: error: array subscript '' is > outside the bounds of an interior zero-length array 'grub_uint16_t[0]' {aka > 'short unsigned int[0]'} [-Werror=zero-length-bounds] > [...] > The l_hash[0] is apparnetly an interior member

Re: disk/mdraid1x_linux.c:181:15: warning: array subscript ...

2020-03-25 Thread Michael Chang
On Tue, Mar 24, 2020 at 06:54:43PM +0100, Thomas Schmitt wrote: > Hi, > > i wrote: > > >(char *) &sb.dev_roles - (char *) sb > > >+ grub_le_to_cpu32 (sb.dev_number) * sizeof(grub_uint16_t) > > PGNet Dev wrote: > > grub-core/disk/mdraid1x_linux.c:183:6: error: canno

Re: disk/mdraid1x_linux.c:181:15: warning: array subscript ...

2020-03-24 Thread Thomas Schmitt
Hi, i wrote: > >(char *) &sb.dev_roles - (char *) sb > >+ grub_le_to_cpu32 (sb.dev_number) * sizeof(grub_uint16_t) PGNet Dev wrote: > grub-core/disk/mdraid1x_linux.c:183:6: error: cannot convert to a > pointer type My fault. I forgot the "&" before "sb". (char

Re: disk/mdraid1x_linux.c:181:15: warning: array subscript ...

2020-03-20 Thread Thomas Schmitt
Hi, Paul Menzel wrote: > 181 | (char *) &sb.dev_roles[grub_le_to_cpu32 (sb.dev_number)] >98 | grub_uint16_t dev_roles[]; /* Role in array, or 0x for a > 127 | struct grub_raid_super_1x sb; > [...] > Normally, it should be fixed by using `grub_uint16_t[]` instead of > `grub