Re: [Gsll-devel] Patch that exports symbols required to use non-linear fitting outside the gsl package

2010-04-29 Thread Liam Healy
No problem. Thanks for the update. Liam On Wed, Apr 28, 2010 at 6:06 PM, Russell Kliese wrote: > Hi Liam, > > Just a quick note to let you know that I tested the changes and all > looks good. Your additional changes have made the interface better. > Thank you! > > Cheers, > > Russell > > On Thu

Re: [Gsll-devel] Patch that exports symbols required to use non-linear fitting outside the gsl package

2010-04-25 Thread Liam Healy
OK, I've applied your patch and made some further changes. I have generally followed a policy of making objects that are to be returned by the function be optional arguments, with the correctly sized object being made by default, thereby sparing the programmer from having to think about it. Towar

Re: [Gsll-devel] Patch that exports symbols required to use non-linear fitting outside the gsl package

2010-04-23 Thread Russell Kliese
Yes, I was thinking the same thing. I created a new patch and tested the example. There is also the issue of the ls-covariance function requiring a raw pointer to the Jacobin matrix. I just exported the jacobian function in the attached patch. Cheers, Russell On Thu, 2010-04-22 at 22:45 -0400,

[Gsll-devel] Patch that exports symbols required to use non-linear fitting outside the gsl package

2010-04-22 Thread Liam Healy
Hmm, so it does.  I'm wondering if fit-test-delta is always called with last-step and current-position derived from the same fit object.  In which case, would it make sense to just have one argument there, the fit object? E.g. (fit-test-delta fit 1.0d-4 1.0d-4) What do you think? Liam On Wed, Apr

Re: [Gsll-devel] Patch that exports symbols required to use non-linear fitting outside the gsl package

2010-04-21 Thread Russell Kliese
Hi Liam, The example included at the bottom of gsll/solve-minimize-fit/nonlinear-least-squares.lisp, line 373 (fit-test-delta (last-step fit) (mpointer (solution fit)) 1.0d-4 1.0d-4)) uses (mpointer (solution fit)). Because mpointer isn't exported, I thought I would create a specific function like

Re: [Gsll-devel] Patch that exports symbols required to use non-linear fitting outside the gsl package

2010-04-21 Thread Liam Healy
Russell, Can you give an example showing why this function is needed? If I understand correctly, #'solution gives an marray which can be used like any other marray. As a general practice I don't define functions returning raw pointers unless the exclusive use of the returned value from the origin

[Gsll-devel] Patch that exports symbols required to use non-linear fitting outside the gsl package

2010-04-12 Thread Russell Kliese
Hi, I think some additional exports are required in order to make use of the non-linear least-squares fitting outside of the gsl package. Attached is a patch that achieves this. Cheers, Russell From e5f4e270d0d14fb8a1f653b25ed9ff11326d1fe1 Mon Sep 17 00:00:00 2001 From: Russell Kliese Date: Mon