I got an account on gitlab. I need to find a time slot to work on this, so
no progress in next few days.
Thanks for the coding suggestions.
Mirko
On Mon, Jan 4, 2016 at 7:18 AM, Mirko Vukovic
wrote:
> Hi Liam,
>
> thanks for the feedback. I will get an account on gitlab.
>
> Mirko
>
> On Fri
Hi Liam,
thanks for the feedback. I will get an account on gitlab.
Mirko
On Fri, Jan 1, 2016 at 1:12 PM, Liam Healy wrote:
> Thanks for these patches. I think that GSLL should use the GSL
> functions for permutations and combinations rather than relying on the
> foreign representation as vect
Thanks for these patches. I think that GSLL should use the GSL
functions for permutations and combinations rather than relying on the
foreign representation as vectors (and the wrong type, too, as you
discovered). There is some loss of use of grid functions for
manipulation, but I never used that a
This is a follow-up on the previous patch.
I applied the same principles on data/combination.lisp and recoded using
GSL's combination functions only. Again this cleared up some errors or
failures on my end.
I hope that I did not mangle major pieces of your design intent.
Mirko
On Fri, Nov 27,
Liam,
I am not trying to bludgeon this issue to death nor convince the you that
I am right and you are wrong.
In a nutshell, I started on this path because of exception errors when
trying to
load GSLL on Windows (SBCL or CCL) using GSL compiled MinGW64. I
traced this to the initialization of the
Added thought: you can lookup any GSL (C) function to find the CL
equivalent by using gsl-lookup. So for example
(gsl:gsl-lookup "gsl_permute_vector")
PERMUTE
T
tells you #'permute is the function you want. If there is no
equivalent (there are some C functions with no interface in CL), you
will g
Thanks for the explanations - I missed the :generic and :method specifiers.
I'll study the macro-expansions.
Sorry for the noise.
Mirko
On Tue, Nov 24, 2015 at 10:16 PM, Liam Healy wrote:
> The original code looks right to me.
>
> You have taken the generic function and the associated foreign
The original code looks right to me.
You have taken the generic function and the associated foreign vector
methods #'permute and gratuitously renamed them #'permute-vector,
leaving the method for raw C pointer with the original name and no
generic function. Then you completely delete the generic f
Because of a typo, GSLL did not have the equivalent of GSL_PERMUTE_VECTOR.
There was also a section of duplicated code.
This patch should fix these errors.
NOTE: I did not test this patch - My GSLL system is not behaving
super-cleanly on MSYS2 and GSL2.1. Proceed with care.
Mirko
0001-Fixed-
