Asking a favor to review a patch

2013-02-24 Thread Fan Chun-wei
Hi, I have filed bug 693646 about two weeks ago regarding gspawn-win32-helper.c which fixes the Win32 spawn helper programs when they are linked with msvcr80.dll or later. As msvcr80.dll (and later) are much more picky on the validity of the fd (file descriptor) passed into close(), the curr

Re: win32-fixup.pl

2013-02-24 Thread Philip Chimento
On Sun, Feb 24, 2013 at 10:47 AM, John Emmas wrote: > On 24/02/2013 08:34, John Emmas wrote: >> >> >> Can anyone tell me what the correct syntax is for running the script? I >> tried "perl win32-fixup.pl" (without any command-line options) and although >> it did work, it only processed the first

Re: win32-fixup.pl

2013-02-24 Thread John Emmas
On 24/02/2013 08:34, John Emmas wrote: Can anyone tell me what the correct syntax is for running the script? I tried "perl win32-fixup.pl" (without any command-line options) and although it did work, it only processed the first file in the list and then skipped the others. I realised wha

win32-fixup.pl

2013-02-24 Thread John Emmas
I just discovered an interesting Perl script in my main 'glib' folder. It's a small script called 'win32-fixup.pl' and I've reproduced it below (after adjusting shebang for my particular system). It looks like the intention is to iterate through some files and change various declarations (suc