Re: GDK_KP_Decimal (on Windows)

2015-05-08 Thread John Emmas
On 04/05/2015 16:49, LRN wrote: - *ksymp - GDK_KP_DECIMAL; break; + *ksymp = GDK_KEY_KP_Decimal; break; I just updated from gtk-2-24 git which pulled in the above change (commit #1f74f12d). Whilst the change might be technically more correct (and it matches the style for GTK+

Re: GDK_KP_Decimal (on Windows)

2015-05-08 Thread Emmanuele Bassi
Hi; On 8 May 2015 at 07:35, John Emmas john...@tiscali.co.uk wrote: On 04/05/2015 16:49, LRN wrote: - *ksymp - GDK_KP_DECIMAL; break; + *ksymp = GDK_KEY_KP_Decimal; break; I just updated from gtk-2-24 git which pulled in the above change (commit #1f74f12d). Whilst the change

Re: GDK_KP_Decimal (on Windows)

2015-05-04 Thread LRN
On 01.05.2015 14:35, Matthias Clasen wrote: On Thu, Apr 30, 2015 at 2:37 AM, John Emmas wrote: Thanks. Here's a patch produced by one of my colleagues:- --- a/gdk/win32/gdkkeys-win32.c 2015-04-29 16:33:41.545406159 +0200 +++ b/gdk/win32/gdkkeys-win32.c 2015-04-29 16:35:16.821576820 +0200 @@

Re: GDK_KP_Decimal (on Windows)

2015-05-01 Thread Matthias Clasen
On Thu, Apr 30, 2015 at 2:37 AM, John Emmas john...@tiscali.co.uk wrote: Thanks. Here's a patch produced by one of my colleagues:- --- a/gdk/win32/gdkkeys-win32.c 2015-04-29 16:33:41.545406159 +0200 +++ b/gdk/win32/gdkkeys-win32.c 2015-04-29 16:35:16.821576820 +0200 @@ -145,6 +145,8 @@

Re: GDK_KP_Decimal (on Windows)

2015-04-30 Thread John Emmas
On 29/04/2015 19:03, Jasper St. Pierre wrote: It was likely left out by accident, and nobody so far hit this code path yet. Thanks for finding it! It looks super easy to fix. Thanks. Here's a patch produced by one of my colleagues:- --- a/gdk/win32/gdkkeys-win32.c 2015-04-29

Re: GDK_KP_Decimal (on Windows)

2015-04-29 Thread Jasper St. Pierre
It was likely left out by accident, and nobody so far hit this code path yet. Thanks for finding it! It looks super easy to fix. On Wed, Apr 29, 2015 at 8:01 AM, John Emmas john...@tiscali.co.uk wrote: On 29/04/2015 08:54, John Emmas wrote: The Windows version looks slightly different:-

Re: GDK_KP_Decimal (on Windows)

2015-04-29 Thread John Emmas
On 29/04/2015 16:25, Ignacio Casal Quinteiro wrote: Hi John, out of curiosity can you check if this is true for gtk3? Hi Ignacio. I don't actually build Gtk+3 but it looks like GDK_KP_Decimal is still missing. Strangely, it's also missing from 'gdkkeys-x11.c' - and yet I got told that

GDK_KP_Decimal (on Windows)

2015-04-29 Thread John Emmas
that these include a definition for 'GDK_KP_Decimal'. The Windows version looks slightly different:- case VK_MULTIPLY: *ksymp = GDK_KP_Multiply; break; case VK_ADD: *ksymp = GDK_KP_Add; break; case VK_SEPARATOR: *ksymp = GDK_KP_Separator; break; case VK_SUBTRACT

Re: GDK_KP_Decimal (on Windows)

2015-04-29 Thread Ignacio Casal Quinteiro
Hi John, out of curiosity can you check if this is true for gtk3? Cheers. On Wed, Apr 29, 2015 at 5:01 PM, John Emmas john...@tiscali.co.uk wrote: On 29/04/2015 08:54, John Emmas wrote: The Windows version looks slightly different:- case VK_ADD: *ksymp = GDK_KP_Add; break;

Re: GDK_KP_Decimal (on Windows)

2015-04-29 Thread John Emmas
On 29/04/2015 08:54, John Emmas wrote: The Windows version looks slightly different:- case VK_ADD: *ksymp = GDK_KP_Add; break; case VK_SEPARATOR: *ksymp = GDK_KP_Separator; break; case VK_SUBTRACT: *ksymp = GDK_KP_Subtract; break; // some others However, the