Re: GtkTreeView Refactoring Considerations [was Re: Private types inside GTK+]

2010-11-03 Thread Tristan Van Berkom
On Mon, 2010-11-01 at 17:37 +0900, Tristan Van Berkom wrote: On Mon, 2010-11-01 at 15:15 +0900, Tristan Van Berkom wrote: On Mon, 2010-11-01 at 12:15 +0900, Tristan Van Berkom wrote: On Sun, 2010-10-31 at 17:45 +0100, Kristian Rietveld wrote: On Sun, Oct 31, 2010 at 3:17 PM, Tristan Van

Re: GtkTreeView Refactoring Considerations [was Re: Private types inside GTK+]

2010-11-01 Thread Tristan Van Berkom
On Mon, 2010-11-01 at 12:15 +0900, Tristan Van Berkom wrote: On Sun, 2010-10-31 at 17:45 +0100, Kristian Rietveld wrote: On Sun, Oct 31, 2010 at 3:17 PM, Tristan Van Berkom trista...@openismus.com wrote: Whew, ok I implemented GtkCellArea-render for GtkCellAreaBox for the most part,

Re: GtkTreeView Refactoring Considerations [was Re: Private types inside GTK+]

2010-11-01 Thread Tristan Van Berkom
On Mon, 2010-11-01 at 15:15 +0900, Tristan Van Berkom wrote: On Mon, 2010-11-01 at 12:15 +0900, Tristan Van Berkom wrote: On Sun, 2010-10-31 at 17:45 +0100, Kristian Rietveld wrote: On Sun, Oct 31, 2010 at 3:17 PM, Tristan Van Berkom trista...@openismus.com wrote: Whew, ok I

Re: GtkTreeView Refactoring Considerations [was Re: Private types inside GTK+]

2010-11-01 Thread Matthias Clasen
On Mon, Nov 1, 2010 at 2:15 AM, Tristan Van Berkom trista...@openismus.com wrote: Well... as I've already said I havent figured out a solution for this... I'm all ears. Look at gtk_container_focus_sort for how we deal with directional navigation in widgets. It notably doesn't handle

Re: GtkTreeView Refactoring Considerations [was Re: Private types inside GTK+]

2010-10-31 Thread Tristan Van Berkom
On Wed, 2010-10-27 at 08:59 +0200, Kristian Rietveld wrote: On Tue, Oct 26, 2010 at 6:34 PM, Tristan Van Berkom trista...@openismus.com wrote: Depending on the GtkSizeRequestMode in use by the parenting layout widget (hfw of wfh), generally only allocate_width() or allocate_height() will

Re: GtkTreeView Refactoring Considerations [was Re: Private types inside GTK+]

2010-10-31 Thread Tristan Van Berkom
On Sun, 2010-10-31 at 15:21 +0900, Tristan Van Berkom wrote: On Wed, 2010-10-27 at 08:59 +0200, Kristian Rietveld wrote: On Tue, Oct 26, 2010 at 6:34 PM, Tristan Van Berkom trista...@openismus.com wrote: Depending on the GtkSizeRequestMode in use by the parenting layout widget (hfw of

Re: GtkTreeView Refactoring Considerations [was Re: Private types inside GTK+]

2010-10-31 Thread Kristian Rietveld
On Sun, Oct 31, 2010 at 7:21 AM, Tristan Van Berkom trista...@openismus.com wrote: Ok so I'm pretty much finished the request/allocation code... I've got as far as having a list of renderers with allocated positions and sizes come time for -render()/-event() etc. If I understand correctly

Re: GtkTreeView Refactoring Considerations [was Re: Private types inside GTK+]

2010-10-31 Thread Kristian Rietveld
On Sun, Oct 31, 2010 at 3:17 PM, Tristan Van Berkom trista...@openismus.com wrote: Whew, ok I implemented GtkCellArea-render for GtkCellAreaBox for the most part, however I'm still missing the GtkCellRendererState flags ;-) So for this part I was thinking it might make more sense to create a

Re: GtkTreeView Refactoring Considerations [was Re: Private types inside GTK+]

2010-10-31 Thread Tristan Van Berkom
On Sun, 2010-10-31 at 17:30 +0100, Kristian Rietveld wrote: On Sun, Oct 31, 2010 at 7:21 AM, Tristan Van Berkom trista...@openismus.com wrote: Ok so I'm pretty much finished the request/allocation code... I've got as far as having a list of renderers with allocated positions and sizes come

Re: GtkTreeView Refactoring Considerations [was Re: Private types inside GTK+]

2010-10-31 Thread Tristan Van Berkom
On Sun, 2010-10-31 at 17:45 +0100, Kristian Rietveld wrote: On Sun, Oct 31, 2010 at 3:17 PM, Tristan Van Berkom trista...@openismus.com wrote: Whew, ok I implemented GtkCellArea-render for GtkCellAreaBox for the most part, however I'm still missing the GtkCellRendererState flags ;-) So

Re: GtkTreeView Refactoring Considerations [was Re: Private types inside GTK+]

2010-10-27 Thread Kristian Rietveld
On Tue, Oct 26, 2010 at 6:34 PM, Tristan Van Berkom trista...@openismus.com wrote: Depending on the GtkSizeRequestMode in use by the parenting layout widget (hfw of wfh), generally only allocate_width() or allocate_height() will be called. However there will be cases where we get to further

Re: GtkTreeView Refactoring Considerations [was Re: Private types inside GTK+]

2010-10-26 Thread Kristian Rietveld
On Tue, Oct 26, 2010 at 3:28 AM, Tristan Van Berkom trista...@openismus.com wrote: On Mon, 2010-10-25 at 17:26 +0200, Kristian Rietveld wrote: Hmm seems I didn't communicate this clearly enough, GtkCellArea is a base abstract class, and GtkCellAreaBox is the first concrete subclass of

Re: GtkTreeView Refactoring Considerations [was Re: Private types inside GTK+]

2010-10-26 Thread Tristan Van Berkom
On Tue, 2010-10-26 at 09:23 +0200, Kristian Rietveld wrote: On Tue, Oct 26, 2010 at 3:28 AM, Tristan Van Berkom trista...@openismus.com wrote: On Mon, 2010-10-25 at 17:26 +0200, Kristian Rietveld wrote: Hmm seems I didn't communicate this clearly enough, GtkCellArea is a base abstract

Re: GtkTreeView Refactoring Considerations [was Re: Private types inside GTK+]

2010-10-26 Thread Tristan Van Berkom
On Tue, 2010-10-26 at 16:54 +0900, Tristan Van Berkom wrote: On Tue, 2010-10-26 at 09:23 +0200, Kristian Rietveld wrote: On Tue, Oct 26, 2010 at 3:28 AM, Tristan Van Berkom trista...@openismus.com wrote: On Mon, 2010-10-25 at 17:26 +0200, Kristian Rietveld wrote: Hmm seems I didn't

Re: GtkTreeView Refactoring Considerations [was Re: Private types inside GTK+]

2010-10-25 Thread Kristian Rietveld
On Sat, Oct 23, 2010 at 9:44 AM, Tristan Van Berkom trista...@openismus.com wrote: I'm a few days into this and I've written up a GtkCellAreaClass and started out implementing an orientable GtkCellAreaBoxClass. An initial problem here has to do with pushing data to the GtkCellArea instead of

Re: GtkTreeView Refactoring Considerations [was Re: Private types inside GTK+]

2010-10-25 Thread Tristan Van Berkom
On Mon, 2010-10-25 at 17:26 +0200, Kristian Rietveld wrote: On Sat, Oct 23, 2010 at 9:44 AM, Tristan Van Berkom trista...@openismus.com wrote: I'm a few days into this and I've written up a GtkCellAreaClass and started out implementing an orientable GtkCellAreaBoxClass. An initial

Re: GtkTreeView Refactoring Considerations [was Re: Private types inside GTK+]

2010-10-23 Thread Tristan Van Berkom
On Tue, 2010-10-12 at 14:51 +0200, Kristian Rietveld wrote: On Thu, Oct 7, 2010 at 6:41 AM, Tristan Van Berkom trista...@openismus.com wrote: I was thinking that a GtkCellArea would only render a single row (actually, a row in a treeview can be composed of several GtkCellAreas, each

Re: GtkTreeView Refactoring Considerations [was Re: Private types inside GTK+]

2010-10-12 Thread Kristian Rietveld
On Thu, Oct 7, 2010 at 6:41 AM, Tristan Van Berkom trista...@openismus.com wrote: I was thinking that a GtkCellArea would only render a single row (actually, a row in a treeview can be composed of several GtkCellAreas, each treeview column would use exactly one cell area to abstract a lot of

Re: GtkTreeView Refactoring Considerations [was Re: Private types inside GTK+]

2010-10-06 Thread Tristan Van Berkom
First sorry for the delayed reply... lets just say that rome was not built in a day ;-) On Wed, 2010-09-29 at 21:25 +0200, Kristian Rietveld wrote: On Sep 23, 2010, at 10:56 AM, Tristan Van Berkom wrote: So to help stay on track without straying too too much, these are (my perceived) reasons

Re: GtkTreeView Refactoring Considerations [was Re: Private types inside GTK+]

2010-09-29 Thread Kristian Rietveld
On Sep 23, 2010, at 10:56 AM, Tristan Van Berkom wrote: So to help stay on track without straying too too much, these are (my perceived) reasons for the said refactoring work: - Code sharing: A good refactoring of cell layouting logic into some classes that can be (more) easily reused