Re: Pluggable widgets II

2006-12-20 Thread Mark McLoughlin
Hi Tim, Just a couple of things I'm confused about: - How does this work for interface types? e.g. I can understand how you might want to replace GtkEntry's editable interface, but not how you'd appoint an implementation type for GTK_TYPE_EDITABLE - How does this work

Re: Pluggable widgets II

2006-12-20 Thread Tim Janik
On Wed, 20 Dec 2006, Mark McLoughlin wrote: Hi Tim, Just a couple of things I'm confused about: - How does this work for interface types? e.g. I can understand how you might want to replace GtkEntry's editable interface, but not how you'd appoint an implementation type for

Re: Pluggable widgets II

2006-12-20 Thread Mark McLoughlin
On Wed, 2006-12-20 at 10:22 +0100, Tim Janik wrote: On Wed, 20 Dec 2006, Mark McLoughlin wrote: - How does this work for application derived types? e.g. if vino derives from GtkLabel to make a label which looks like a clickable URL, then even if it is instantiated using

Re: Pluggable widgets II

2006-12-20 Thread Benjamin Otte
Tim Janik timj at imendio.com writes: - How does this work for application derived types? e.g. if vino derives from GtkLabel to make a label which looks like a clickable URL, then even if it is instantiated using g_factory_create() a gtk theme module will not be able to

Re: Pluggable widgets II

2006-12-20 Thread Mark McLoughlin
On Wed, 2006-12-20 at 10:46 +0100, Tim Janik wrote: On Wed, 20 Dec 2006, Mark McLoughlin wrote: Whichever it is, I'm wondering about things like VinoUrl - i.e. an application derived widget. Should it be expected that a plugged-in re-implementation of GtkLabel would also be used by

Re: Pluggable widgets II

2006-12-20 Thread Tim Janik
On Wed, 20 Dec 2006, Mark McLoughlin wrote: Suppose gnome-panel implements PanelMenu[1] as a sub-class of GtkMenu in order to display an ugly logo on the left hand side of the menu. If a platform vendor goes to the trouble of introducing a customised GtkMenu implementation, then

Re: Pluggable widgets II

2006-12-20 Thread Mark McLoughlin
On Wed, 2006-12-20 at 15:04 +0100, Tim Janik wrote: On Wed, 20 Dec 2006, Mark McLoughlin wrote: With this API the vendor would need to have a gtk module or library especially for the gnome-panel in order to appoint a new implementation of PanelMenu. if he *only* means to change the

Re: Pluggable widgets II

2006-12-20 Thread Tim Janik
On Wed, 20 Dec 2006, Mark McLoughlin wrote: On Wed, 2006-12-20 at 15:04 +0100, Tim Janik wrote: On Wed, 20 Dec 2006, Mark McLoughlin wrote: With this API the vendor would need to have a gtk module or library especially for the gnome-panel in order to appoint a new implementation of

Re: Pluggable widgets II

2006-12-20 Thread Tristan Van Berkom
On Wed, 2006-12-20 at 15:34 +0100, Tim Janik wrote: My point is that Foo would prefer if PanelMenu could automatically sub-class FooGtkMenu rather than GtkMenu. with Gtk+ and its object system, that is simply not technically possible. custom_menu_item_type =

Re: Pluggable widgets II

2006-12-20 Thread Tim Janik
On Wed, 20 Dec 2006, Tristan Van Berkom wrote: On Wed, 2006-12-20 at 15:34 +0100, Tim Janik wrote: My point is that Foo would prefer if PanelMenu could automatically sub-class FooGtkMenu rather than GtkMenu. with Gtk+ and its object system, that is simply not technically possible.

Re: Pluggable widgets II

2006-12-20 Thread Gustavo J. A. M. Carneiro
On Ter, 2006-12-19 at 21:51 +0200, Paul Pogonyshev wrote: Tim Janik wrote: here's a refined proposal for pluggable widgets [...] Looks fine to me, except that I support the requested addition of va_list version of g_factory_create(). Otherwise everything seems good. I didn't propose a

Re: Pluggable widgets II

2006-12-20 Thread Paul Pogonyshev
Gustavo J. A. M. Carneiro wrote: On Ter, 2006-12-19 at 21:51 +0200, Paul Pogonyshev wrote: Tim Janik wrote: here's a refined proposal for pluggable widgets [...] Looks fine to me, except that I support the requested addition of va_list version of g_factory_create(). Otherwise

Re: Pluggable widgets II

2006-12-20 Thread Paul Pogonyshev
Benjamin Otte wrote: Tim Janik timj at imendio.com writes: - How does this work for application derived types? e.g. if vino derives from GtkLabel to make a label which looks like a clickable URL, then even if it is instantiated using g_factory_create() a gtk theme

Re: Pluggable widgets II

2006-12-19 Thread Gustavo J. A. M. Carneiro
On Ter, 2006-12-19 at 14:18 +0100, Tim Janik wrote: hey All. here's a refined proposal for pluggable widgets, incorporating the recent comments from Damon Chaplin and Paul Pogonyshev. the motivation for pluggable widgets is supplied in the original proposal:

Re: Pluggable widgets II

2006-12-19 Thread Paul Pogonyshev
Tim Janik wrote: here's a refined proposal for pluggable widgets [...] Looks fine to me, except that I support the requested addition of va_list version of g_factory_create(). Otherwise everything seems good. Paul ___ gtk-devel-list mailing list

Re: Pluggable widgets II

2006-12-19 Thread Kalle Vahlman
2006/12/19, Tim Janik [EMAIL PROTECTED]: - g_object_factory_ was suggested as namespace for this factory. that'd be technically correct because the API is supposed to only create GObject derived types, however g_object_factory_ is significantly longer and i think we can be pretty

Re: Pluggable widgets II

2006-12-19 Thread Tristan Van Berkom
On Tue, 2006-12-19 at 21:51 +0200, Paul Pogonyshev wrote: Tim Janik wrote: here's a refined proposal for pluggable widgets [...] This isnt really a concern, just curious... g_factory_appoint (TYPE_BAR, TYPE_BAZ); g_factory_appoint (TYPE_FOO, TYPE_BAR); g_factory_get_appointed (TYPE_FOO) ==

Re: Pluggable widgets II

2006-12-19 Thread Tim Janik
On Tue, 19 Dec 2006, Tristan Van Berkom wrote: On Tue, 2006-12-19 at 21:51 +0200, Paul Pogonyshev wrote: Tim Janik wrote: here's a refined proposal for pluggable widgets [...] This isnt really a concern, just curious... g_factory_appoint (TYPE_BAR, TYPE_BAZ); g_factory_appoint (TYPE_FOO,