Re: Use of lrint() in 'gdk-pixbuf/pixops/pixops.c'

2017-02-05 Thread Martin Guy
On 05/02/2017, Yale Zhang wrote: > I suggest adding a lrintf() fallback to fallback-c89.c too. > > Currently, there are 2 rounding functions in the fall backs, round() > and rint(), with rint() having the better less biased IEEE > round-to-even behavior for the 0.5 case. > >

Re: Use of lrint() in 'gdk-pixbuf/pixops/pixops.c'

2017-02-04 Thread Martin Guy
On 04/02/2017, John Emmas via gtk-devel-list wrote: > Commit #61e3edeb79 (6th Jan 2017) introduced these 2 calls in > 'gdk-pixbuf/pixops/pixops.c' (at lines 1847 and 1848):- > > tmp_width = lrint (src_width * prescale_x); > tmp_height = lrint (src_height *

Re: Patch is waiting for your review

2017-01-15 Thread Martin Guy
I beat you by two years. I've fixed a 14-year-old one from 2002, bug 80125. After a month or two thinking I could get it included and move on, I have now given up chasing it. Only Bastien stepped forward to triage it and make it ready for review, but his technical remarks were largely limited to

Re: subscribe

2016-12-01 Thread Martin Guy
_gdk_disable_two_step_scaler; ... _gdk_disable_two_step_scaler = 1; it is not found: .../gdk-pixbuf/tests/pixbuf-scale-two-step.c:120: undefined reference to `_gdk_disable_two_step_scaler' Any ideas why? M On 01/12/2016, Martin Guy <martinw...@gmail.com>

Symbols in gdk-pixbuf/pixops become local (was Re: subscribe)

2016-12-01 Thread Martin Guy
Hum. THe global variable has become file local. $ nm gdk-pixbuf/.libs/libgdk_pixbuf-2.0.so.0 | grep scaler 002236f0 b _gdk_disable_two_step_scaler so the global variable has become file-local, as have its functions: $ nm gdk-pixbuf/.libs/libgdk_pixbuf-2.0.so.0 | grep pixops

Re: Symbols in gdk-pixbuf/pixops become local (was Re: subscribe)

2016-12-26 Thread Martin Guy
On 01/12/2016, Martin Guy <martinw...@gmail.com> wrote: > is there another way to turn a piece of code on and off in a > routine in pixops/ from the testsuite? Hi all Last month I made a workaround for the 14-year-old bug in the scaler https://bugzilla.gnome.org/show_bug.cgi?id=80