Re: Perl-Cairo patches

2020-11-08 Thread Torsten Schoenfeld

On 08.11.20 21:12, Torsten Schoenfeld wrote:

Patch 2 adds Perl bindings for:
 cairo_surface_set_mime_data
 cairo_surface_get_mime_data
 cairo_surface_supports_mime_type
 cairo_recording_surface_get_extents

Patch 2 also adds an example file to demonstrate the new bindings.


Looks good too, but could you also be bothered to add docs and unit
tests for the new functionality [...]?


I'm sorry, I misread the patch initially  It already contains unit tests
and docs.  So I committed it, with a few tiny adjustments.  Thanks for
your work!

-Torsten
___
gtk-perl-list mailing list
[email protected]
https://mail.gnome.org/mailman/listinfo/gtk-perl-list


Re: Perl-Cairo patches

2020-11-08 Thread Torsten Schoenfeld

On 31.10.20 15:51, Raymond S Brand wrote:

Patch 1 updates the MANIFEST file to reflect the filename case change of
the "doap" file that was changed last year.


Looks good, applied and pushed.  Thanks!


Patch 2 adds Perl bindings for:
 cairo_surface_set_mime_data
 cairo_surface_get_mime_data
 cairo_surface_supports_mime_type
 cairo_recording_surface_get_extents

Patch 2 also adds an example file to demonstrate the new bindings.


Looks good too, but could you also be bothered to add docs and unit
tests for the new functionality and perhaps wrappers for all the
CAIRO_MIME_TYPE_* defines with newCONSTSUB as in
?

-Torsten
___
gtk-perl-list mailing list
[email protected]
https://mail.gnome.org/mailman/listinfo/gtk-perl-list