Re: [Gtk2hs-devel] Patch to support get/set_prgname and get/set_application_name

2009-11-16 Thread John Millikin
Updated patch attached; copies comments from the glib docs, with appropriate changes (init_gtk -> initGUI, etc). I don't mind the picky-ness -- better to get it right than to add a below-standards module. Please let me know if there are any other issues with the patch. On Mon, Nov 16, 2009 at 01:

Re: [Gtk2hs-devel] Patch to support get/set_prgname and get/set_application_name

2009-11-16 Thread Axel Simon
On Sun, 2009-11-15 at 13:14 -0800, John Millikin wrote: > Ah, I see. Here is the patch updated to use the preferred syntax. Much better. Sorry to be such a pain, but could you add comments to each function. That is, copy and paste the comments from the website and adjust them if necessary. Thanks

Re: [Gtk2hs-devel] Patch to support get/set_prgname and get/set_application_name

2009-11-15 Thread John Millikin
Ah, I see. Here is the patch updated to use the preferred syntax. On Sun, Nov 15, 2009 at 12:41, Axel Simon wrote: > > On Nov 15, 2009, at 21:25, John Millikin wrote: > >> I'm writing a binding for GNOME Keyring -- if the application and >> program name are not properly set, the "unlock keyring"

Re: [Gtk2hs-devel] Patch to support get/set_prgname and get/set_application_name

2009-11-15 Thread Axel Simon
I'm not so happy applying your patch since a) you introduce some new "helper" functions that are not really necessary b) you bind functions that don't seem to be useful in a more general context. I.e. you can set the program name in the AboutDialog directly using the 'aboutDialogName' property. W

Re: [Gtk2hs-devel] Patch to support get/set_prgname and get/set_application_name

2009-11-15 Thread Axel Simon
On Nov 15, 2009, at 21:25, John Millikin wrote: > I'm writing a binding for GNOME Keyring -- if the application and > program name are not properly set, the "unlock keyring" window > displays non-useful values. Additionally, the following warning is > printed to the terminal when running without

Re: [Gtk2hs-devel] Patch to support get/set_prgname and get/set_application_name

2009-11-15 Thread John Millikin
I'm writing a binding for GNOME Keyring -- if the application and program name are not properly set, the "unlock keyring" window displays non-useful values. Additionally, the following warning is printed to the terminal when running without a set application name. -- ** (proces