Re: [PATCH] Augmenting the doc of `define-module'

Hi, Marius Vollmer <[EMAIL PROTECTED]> writes: > I made the following changes. OK? Looks perfect to me! But what about the rest of the patch, namely: > 2005-11-07 Ludovic Courtès <[EMAIL PROTECTED]> > > * srfi-19.scm (current-time): Replace it instead of exporting > it. > >

Re: [PATCH] Augmenting the doc of `define-module'

[EMAIL PROTECTED] (Ludovic Courtès) writes: > Any news regarding this patch? I made the following changes. OK? Index: api-modules.texi === RCS file: /cvsroot/guile/guile/guile-core/doc/ref/api-modules.texi,v retrieving revision 1.1

Re: [PATCH] Augmenting the doc of `define-module'

Hi, [EMAIL PROTECTED] (Ludovic Courtès) writes: > [EMAIL PROTECTED] (Ludovic Courtès) writes: > >> doc/ref/ChangeLog >> >> 2005-11-07 Ludovic Courtès <[EMAIL PROTECTED]> >> >> * api-modules.texi (Using Guile Modules): Document SRFI-19 as an >> example usage of `#:replace'. >> >> >> sr

Re: [PATCH] Augmenting the doc of `define-module'

Hi, [EMAIL PROTECTED] (Ludovic Courtès) writes: > doc/ref/ChangeLog > > 2005-11-07 Ludovic Courtès <[EMAIL PROTECTED]> > > * api-modules.texi (Using Guile Modules): Document SRFI-19 as an > example usage of `#:replace'. > > > srfi/ChangeLog > > 2005-11-07 Ludovic Courtès <[EMAIL P

Re: [PATCH] Augmenting the doc of `define-module'

Hi Kevin, Kevin Ryde <[EMAIL PROTECTED]> writes: > [EMAIL PROTECTED] (Ludovic Courtès) writes: >> >> "replaces" `current-time' instead of exporting it. Once this is >> done, > > Well, certainly not until then. I removed this bit I didn't like and > checked-in the rest. Thanks. Thanks for chec

Re: [PATCH] Augmenting the doc of `define-module'

[EMAIL PROTECTED] (Ludovic Courtès) writes: > > "replaces" `current-time' instead of exporting it. Once this is > done, Well, certainly not until then. I removed this bit I didn't like and checked-in the rest. Thanks. ___ Guile-devel mailing list Gu

Re: [PATCH] Augmenting the doc of `define-module'

Kevin Ryde <[EMAIL PROTECTED]> writes: > No, I'm not bothered about the rationale, I just think "what-if"'s > about builtin stuff is confusing. Create a standalone example and > it's fine. The suggestion that I made implicitly was to "fix" srfi-19.scm so that it "replaces" `current-time' instead

Re: [PATCH] Augmenting the doc of `define-module'

[EMAIL PROTECTED] (Ludovic Courtès) writes: > > Actually, I think that what we disagree on is the rationale behind > `#:replace'. No, I'm not bothered about the rationale, I just think "what-if"'s about builtin stuff is confusing. Create a standalone example and it's fine. _

Re: [PATCH] Augmenting the doc of `define-module'

Kevin Ryde <[EMAIL PROTECTED]> writes: > [EMAIL PROTECTED] (Ludovic Courtès) writes: >> >> [EMAIL PROTECTED] #:replace @var{list} >> ... >> +One example of this is @code{(srfi srfi-19)} which exports >> [EMAIL PROTECTED] > > This isn't a great example. See if you can make up something, to > avoid

Re: [PATCH] Augmenting the doc of `define-module'

[EMAIL PROTECTED] (Ludovic Courtès) writes: > > [EMAIL PROTECTED] #:replace @var{list} > ... > +One example of this is @code{(srfi srfi-19)} which exports > [EMAIL PROTECTED] This isn't a great example. See if you can make up something, to avoid confusing anyone about what srfi-19 actually does o

[PATCH] Augmenting the doc of `define-module'

Hi, It occurred to me that `define-module' is only partially documented, in particular, `#:re-export', `#:replace' and `#:duplicates' are not documented at all. I tried to do my best to document them accurately but note that (i) I'm not a native English speaker and (ii) from the discussion we've