Re: [PATCH] Avoid 'frame-local-ref' errors when printing backtrace.

Ludovic Courtès wrote: > > Applied, thanks! Thank you! > PS: Please use ‘git format-patch’ so the patch can be directly consumed > by ‘git am’. My mistake, sorry about that. Noted for next time :) Cheers, Andrew

Re: [PATCH] Avoid 'frame-local-ref' errors when printing backtrace.

Hi, Andrew Whatson skribis: > commit 164bdce6acf53796cb96ef1930a89c6caf84bc39 > Author: Andrew Whatson > Date: Wed Jan 11 14:04:32 2023 +1000 > > Test for 'frame-local-ref' errors when printing backtrace. > > This test reproduces the error from , and

Re: [PATCH] Avoid 'frame-local-ref' errors when printing backtrace.

Ludovic Courtès wrote: > > It would be great if you could add a simple test case though, so that > the bug doesn’t eventually come back to haunt us. I've finally tracked this one down, a patch with a unit test for this bug is attached. Cheers, Andrew commit

Re: [PATCH] Avoid 'frame-local-ref' errors when printing backtrace.

Pushed to c7fa78fc751eb336bcfafbb5ac59c460ee2c5d7a. Thank you!

Re: [PATCH] Avoid 'frame-local-ref' errors when printing backtrace.

Hi, Andrew Whatson skribis: > Ludovic Courtès wrote: >> >> It would be great if you could add a simple test case though, so that >> the bug doesn’t eventually come back to haunt us. >> >> Could you send an updated patch? > > Ah yes, getting this covered in a test is on my list. I had trouble

Re: [PATCH] Avoid 'frame-local-ref' errors when printing backtrace.

Ludovic Courtès wrote: > > It would be great if you could add a simple test case though, so that > the bug doesn’t eventually come back to haunt us. > > Could you send an updated patch? Ah yes, getting this covered in a test is on my list. I had trouble writing a reproducer previously, I think

Re: [PATCH] Avoid 'frame-local-ref' errors when printing backtrace.

Hi Andrew, Andrew Whatson skribis: > Workaround for . > > * module/system/vm/frame.scm (frame-call-representation): Treat a > binding as "unspecified" if its slot exceeds 'frame-num-locals'. Yay, great to see that fixed (or almost)! It would be great if you could

Re: [PATCH] Avoid 'frame-local-ref' errors when printing backtrace.

On 22-09-2022 15:53, Andrew Whatson wrote: - (let ((val (frame-local-ref frame (binding-slot binding) - (binding-representation binding + (let* ((slot (binding-slot binding)) +;; HACK: Avoid out-of-range

[PATCH] Avoid 'frame-local-ref' errors when printing backtrace.

Workaround for . * module/system/vm/frame.scm (frame-call-representation): Treat a binding as "unspecified" if its slot exceeds 'frame-num-locals'. --- module/system/vm/frame.scm | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] Avoid 'frame-local-ref' errors when printing backtrace.

Maxime Devos wrote: > > I propose to add a link to the bug report in the comments, for future > reference. Also, there is an interest in returning zero values in such > cases: > (that patch didn't work out, but the sentiment is still

Re: [PATCH] Avoid 'frame-local-ref' errors when printing backtrace.

On 20-09-2022 09:23, Andrew Whatson wrote: => (lambda (binding) - (let ((val (frame-local-ref frame (binding-slot binding) - (binding-representation binding + (let* ((slot (binding-slot binding)) +

[PATCH] Avoid 'frame-local-ref' errors when printing backtrace.

Workaround for . * module/system/vm/frame.scm (frame-call-representation): Treat a binding as "unspecified" if its slot exceeds 'frame-num-locals'. --- module/system/vm/frame.scm | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git