Re: [PATCH] Possible Documentation Fix

2011-02-02 Thread Noah Lavine
> I've added you to the Guile group.  If you don't mind, please continue > to post patches to the list for a little while.  Try to rebase before > pushing patches to the Guile repo; merge commits are OK sometimes, but > we like having a nice linear history. > > I guess in short the thing is to keep

Re: [PATCH] Possible Documentation Fix

2011-02-02 Thread Andy Wingo
On Wed 02 Feb 2011 15:53, Noah Lavine writes: >> Looks great to me!  Would you mind submitting an updated patch? > > It's attached. Thanks. I added a summary line and committed it. I've added you to the Guile group. If you don't mind, please continue to post patches to the list for a little w

Re: [PATCH] Possible Documentation Fix

2011-02-02 Thread Noah Lavine
Hi, > Looks great to me!  Would you mind submitting an updated patch? It's attached. > Also, if you like, please add yourself to the Guile group on savannah. > Let Ludo and I know when/if you've done this and we'll be happy to add > you there.  Let's keep up the great discussion on the list, but

Re: [PATCH] Possible Documentation Fix

2011-01-31 Thread Andy Wingo
On Mon 31 Jan 2011 20:54, Noah Lavine writes: > How about this language? Looks great to me! Would you mind submitting an updated patch? Also, if you like, please add yourself to the Guile group on savannah. Let Ludo and I know when/if you've done this and we'll be happy to add you there. Let'

Re: [PATCH] Possible Documentation Fix

2011-01-31 Thread Noah Lavine
Hi, > It is correct, but I kinda liked the explicit mention of pattern > variable environments in the original.  In syntax expansion, there are > lexical variables, bound in lexical environments, and pattern variables, > bound in syntax-expansion environments.  The confusion addressed by that > pa

Re: [PATCH] Possible Documentation Fix

2011-01-30 Thread Andy Wingo
Hi Noah, Thanks for the review and patch! On Sat 29 Jan 2011 19:08, Noah Lavine writes: > Could someone who understands syntax-case better than I do please > review it for correctness? It is correct, but I kinda liked the explicit mention of pattern variable environments in the original. In s

[PATCH] Possible Documentation Fix

2011-01-29 Thread Noah Lavine
Hello all, I was recently reading the syntax-case documentation (as part of my project to make peg.scm use syntax-case), and I hit a paragraph that I found difficult to understand. I think I figured out what it means. The attached patch changes the paragraph to something that I think would have be