Re: [PATCH] Verify Size of Objcode Headers

2010-06-20 Thread Ludovic Courtès
Hi Noah, Thanks for the patch! Noah Lavine noah.b.lav...@gmail.com writes: + scm_t_uint8 dummy[] = { OBJCODE_HEADER(5,5) }; + VERIFY_OBJCODE_HEADER_SIZE(dummy); I think that: verify (sizeof (dummy) == sizeof (struct scm_objcode)); would be enough (see below). Perhaps the ‘SCM_UNUSED’

Re: [PATCH] Verify Size of Objcode Headers

2010-06-20 Thread Noah Lavine
Thanks for the corrections. I think this patch addresses them. Noah Add static checks to make sure that the statically-generated object code headers in continuations.c, control.c, foreign.c, gsubr.c and smob.c are the same length as the struct scm_objcode data type in objcodes.h. ---