Denis 'GNUtoo' Carikli writes:
> Yes, that makes the code much better and since when ch is eof, '(eqv? ch
> #\:)' returns #f, so it should work.
OK, pushed your commit to main.
Thanks for the help
--
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8
Sorry again for the delay, I had personal issues (that are now mostly
fixed) that needed urgent attention and that took all my time.
On Fri, 05 Apr 2024 17:03:21 -0500
Rob Browning wrote:
> Rob Browning writes:
>
> > Apologies for the delay, and good point. I should have used eqv?
> > rather
On Tue, 19 Mar 2024 19:21:19 -0500
Rob Browning wrote:
> Denis 'GNUtoo' Carikli writes:
>
> > Would something like that be OK instead?:
>
> Not sure I understand the question. Were you asking if that'd be OK
> elsewhere in the function too?
I was just asking if my new version looked OK,
Rob Browning writes:
> Apologies for the delay, and good point. I should have used eqv? rather
> than char=?, i.e.
>
> (let ((ch (read-char port)))
>(if (eqv? ch #\:)
>(set! ch (read-char port))
>(if (eof-object? ch)
>
Denis 'GNUtoo' Carikli writes:
> Would something like that be OK instead?:
Not sure I understand the question. Were you asking if that'd be OK
elsewhere in the function too?
> However here (char=? ch #\:) can fail if ch is an eof-object.
Apologies for the delay, and good point. I should
On Mon, 11 Mar 2024 19:25:08 +0100
Denis 'GNUtoo' Carikli wrote:
> Also note that I didn't test the code above yet.
I tested the code afterward and it passes all the tests.
I'll send a v2 in case that makes review easier.
Denis.
pgp3X68eFC1AE.pgp
Description: OpenPGP digital signature
Hi,
Sorry for the delay,
On Wed, 06 Mar 2024 12:42:10 -0600
Rob Browning wrote:
> Denis 'GNUtoo' Carikli writes:
> (...and (not related), I also wondered about making some of the error
> messsages more specific, i.e. "Invalid time zone minutes digit" or
> something.)
Would something like
Oh, and for anyone else reviewing this, some specification-related info:
https://en.wikipedia.org/wiki/ISO_8601#Time_zone_designators
--
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A
GPG as of 2002-11-03 14DD 432F
Denis 'GNUtoo' Carikli writes:
> diff --git a/module/srfi/srfi-19.scm b/module/srfi/srfi-19.scm
> index 570f933ca..23d115926 100644
> --- a/module/srfi/srfi-19.scm
> +++ b/module/srfi/srfi-19.scm
> @@ -1271,6 +1271,11 @@
>(if (eof-object? ch)
>(time-error
* module/srfi/srfi-19.scm (zone-reader): handle a colon in the zone.
* test-suite/tests/srfi-19.test (SRFI date/time library test): Add test.
Signed-off-by: Denis 'GNUtoo' Carikli
---
module/srfi/srfi-19.scm | 5 +
test-suite/tests/srfi-19.test | 3 +++
2 files changed, 8
10 matches
Mail list logo
