Re: Fwd: PATCH - Add cooperative REPL server module

2014-01-22 Thread David Thompson
Mark H Weaver m...@netris.org writes: Hi David, Your latest patch looks great to me. I have only one request: please update the docstrings of 'spawn-coop-repl-server' and 'poll-coop-repl-server' to match their current descriptions in the manual, except without texinfo markup, as usual.

Re: Fwd: PATCH - Add cooperative REPL server module

2014-01-21 Thread David Thompson
Mark H Weaver m...@netris.org writes: Interesting. Does it happen with unmodified stable-2.0? If so, I think we can treat this as an independent bug. Yes, exact same problem on stable-2.0. Can you reproduce the segfault while running meta/gdb-uninstalled-guile and get a backtrace?

Re: Fwd: PATCH - Add cooperative REPL server module

2014-01-21 Thread Mark H Weaver
Hi David, Your latest patch looks great to me. I have only one request: please update the docstrings of 'spawn-coop-repl-server' and 'poll-coop-repl-server' to match their current descriptions in the manual, except without texinfo markup, as usual. Other than that, I think the patch is ready to

Fwd: PATCH - Add cooperative REPL server module

2014-01-20 Thread Thompson, David
Forgot to CC the list about my updated patch. Forwarding instead. My apologies. - Dave -- Forwarded message -- From: David Thompson dthomps...@worcester.edu Date: Mon, Jan 20, 2014 at 6:31 PM Subject: Re: PATCH - Add cooperative REPL server module To: Mark H Weaver

Re: Fwd: PATCH - Add cooperative REPL server module

2014-01-20 Thread Mark H Weaver
Hi David, Thompson, David dthomps...@worcester.edu writes: I have wrapped the body of 'start-coop-repl' with 'false-if-exception' to prevent the program from crashing with 'stop-server-and-clients!' is called from a REPL. I did not have to do the same for 'close-socket!' in