Re: [PATCH] do not augment environment

2012-10-01 Thread Bruce Korb
Hi Mark, On 09/30/12 19:38, Mark H Weaver wrote: Thanks for the patch, but I think it needs more work before it can be committed. See below for my comments. You're welcome! Just FYI, I've got no ego wrapped up in being the one to type in characters, so fixing things up for preferred style or

Re: [PATCH] do not augment environment

2012-10-01 Thread Bruce Korb
Hi, P.S. On 09/30/12 19:38, Mark H Weaver wrote: In the current code, SCM_LIB_DIR and SCM_EXTENSIONS_DIR are only added to the library search path when GUILE_SYSTEM_EXTENSIONS_PATH is not set. Your patch mishandles this, because it _always_ acts as if SCM_LIB_DIR and SCM_EXTENSIONS_DIR have

Re: [PATCH] do not augment environment

2012-10-01 Thread Mark H Weaver
On 10/01/2012 10:39 AM, Bruce Korb wrote: On 09/30/12 19:38, Mark H Weaver wrote: In the current code, SCM_LIB_DIR and SCM_EXTENSIONS_DIR are only added to the library search path when GUILE_SYSTEM_EXTENSIONS_PATH is not set. Your patch mishandles this, because it _always_ acts as if

Re: [PATCH] do not augment environment

2012-10-01 Thread Bruce Korb
On 10/01/12 09:59, Mark H Weaver wrote: On 10/01/2012 10:39 AM, Bruce Korb wrote: On 09/30/12 19:38, Mark H Weaver wrote: In the current code, SCM_LIB_DIR and SCM_EXTENSIONS_DIR are only added to the library search path when GUILE_SYSTEM_EXTENSIONS_PATH is not set. Your patch mishandles