Re: fencepost error in encoding processing

2009-11-15 Thread Mike Gran
From: Ken Raeburn raeb...@raeburn.org iconv_t iconv_open (const char *tocode, const char *fromcode) {   /* Normalize the name.  We remove all characters beside alpha-numeric,     '_', '-', '/', '.', and ':'.  */   ... If there's reason to believe that all these characters might show up

release status

2009-11-15 Thread Andy Wingo
Hi, Quick note from a tired hacker :) I had a lovely time at the GNU hacker's meeting in Sweden, and just got back today. I'm sure Ludovic has similar positive reports. The deal for Guile though is that we didn't get enough time to hack, and there is an optargs bug (relative to past ice-9

Re: compiling with -DSCM_DEBUG=1

2009-11-15 Thread Neil Jerram
Ken Raeburn raeb...@raeburn.org writes: I may be overlooking something in my old email -- what were the non- comment updates you suggested? Actually nothing - misremembering on my part. Sorry for the confusion. Neil

Re: compiling with -DSCM_DEBUG=1

2009-11-15 Thread Neil Jerram
Ken Raeburn raeb...@raeburn.org writes: Here's my revised patch. I've simplified the check, and it still passes the tests (except the options tests that were just committed with a log message indicating that they don't pass) and doesn't crash under SCM_DEBUG. Thanks. The revised patch

Re: fencepost error in encoding processing

2009-11-15 Thread Neil Jerram
Mike Gran spk...@yahoo.com writes: Okay to check in? FWIW, it looks right to me. Yes, it looks good to me too. My only comment is that it took me a while to see what you meant by 'fencepost'. I'm not familiar with that expression, and thought it was something to do with building on

Re: compiling with -DSCM_DEBUG=1

2009-11-15 Thread Ken Raeburn
On Nov 15, 2009, at 17:25, Neil Jerram wrote: Ken Raeburn raeb...@raeburn.org writes: Here's my revised patch. I've simplified the check, and it still passes the tests (except the options tests that were just committed with a log message indicating that they don't pass) and doesn't crash

Re: fencepost error in encoding processing

2009-11-15 Thread Mike Gran
From: Neil Jerram n...@ossau.uklinux.net Yes, it looks good to me too.  My only comment is that it took me a while to see what you meant by 'fencepost'.  I'm not familiar with that expression, and thought it was something to do with building on fencepost.gnu.org.  So you might like to add