Hi Daniel,
The updated patch looks good except for a few minor nitpicks:
Daniel Hartwig mand...@gmail.com writes:
From 46178db9eecc9ca402d9571c3ee520074f15ef5a Mon Sep 17 00:00:00 2001
From: Daniel Hartwig mand...@gmail.com
Date: Mon, 8 Oct 2012 18:35:00 +0800
Subject: [PATCH] In
Hi Mark!
Makes sense to me, you can apply it.
Thanks,
Ludo’.
Hi,
Mark H Weaver m...@netris.org skribis:
FAIL: ftw.test: file-system-fold: test-suite (never enter)
FAIL: ftw.test: file-system-fold: test-suite/lib.scm (flat file)
FAIL: ftw.test: scandir: no select
FAIL: ports.test: %file-port-name-canonicalization: absolute
canonicalization from ice-9
Hi,
And now with the patch.
Mark H Weaver m...@netris.org skribis:
FAIL: ftw.test: file-system-fold: test-suite (never enter)
FAIL: ftw.test: file-system-fold: test-suite/lib.scm (flat file)
FAIL: ftw.test: scandir: no select
FAIL: ports.test: %file-port-name-canonicalization: absolute
Hello!
As incredible as it may seem, ‘hash’ until now always returned 263 % n
for structs, leading to interesting experiences when using structs as
hash table keys.
The attached patch provides a simple hasher for structs.
I’ll commit it within a few days if there are no objections.
Ludo’.
On 10 October 2012 01:48, Mark H Weaver m...@netris.org wrote:
+ if (!SCM_CHARSETP (char_pred))
{
- last_idx = idx;
- while (idx 0 buf[idx-1] != SCM_CHAR(chr))
-idx--;
- if (idx = 0)
-{
- res = scm_cons
Daniel Hartwig mand...@gmail.com writes:
On 10 October 2012 01:48, Mark H Weaver m...@netris.org wrote:
Please drop the unneeded curly braces above.
Are guile's macros safe to always use that way?
They should be. If they aren't, that's a bug IMO.
In libguile/__scm.h
the SCM_ASSERT
Hi Ludovic!
l...@gnu.org (Ludovic Courtès) writes:
As incredible as it may seem, ‘hash’ until now always returned 263 % n
for structs, leading to interesting experiences when using structs as
hash table keys.
Yes, do you remember us talking about this long ago on IRC? I wanted to
fix this,
On 10 October 2012 10:14, Mark H Weaver m...@netris.org wrote:
Your latest patch looks good, but I just remembered one more thing:
doc/ref/api-data.texi needs to be updated.
I had assumed that was updated automatically from the doc strings,
which are in the right format.
?
Daniel Hartwig mand...@gmail.com writes:
On 10 October 2012 10:14, Mark H Weaver m...@netris.org wrote:
Your latest patch looks good, but I just remembered one more thing:
doc/ref/api-data.texi needs to be updated.
I had assumed that was updated automatically from the doc strings,
which are
On 10 October 2012 11:25, Mark H Weaver m...@netris.org wrote:
Daniel Hartwig mand...@gmail.com writes:
On 10 October 2012 10:14, Mark H Weaver m...@netris.org wrote:
Your latest patch looks good, but I just remembered one more thing:
doc/ref/api-data.texi needs to be updated.
I had assumed
11 matches
Mail list logo