Re: Unexpectedly low read/write performance of open-pipe

2019-04-09 Thread Mark H Weaver
Hi again, Earlier, I wrote: > I'm not sure off-hand what would be required to re-implement custom > ports in suspendable Scheme code. I finally dug into this code, and was delighted to find that Andy Wingo has already laid the groundwork to avoid going through C code in our custom port handlers,

Re: Unexpectedly low read/write performance of open-pipe

2019-04-09 Thread Chris Vine
On Tue, 09 Apr 2019 14:24:09 -0400 Mark H Weaver wrote: > Hi Chris, > Chris Vine writes: > > On Tue, 09 Apr 2019 04:35:38 -0400 > > Mark H Weaver wrote: > >> > >> I think it's probably fine for 2.2, although a more careful check should > >> be made for differences in behavior between the old an

Re: Unexpectedly low read/write performance of open-pipe

2019-04-09 Thread Mark H Weaver
Chris Vine writes: > On Tue, 09 Apr 2019 04:35:38 -0400 > Mark H Weaver wrote: >> >> I think it's probably fine for 2.2, although a more careful check should >> be made for differences in behavior between the old and new >> implementations, and tests should be added. I'll try to get to it soon.

Re: Unexpectedly low read/write performance of open-pipe

2019-04-09 Thread Mark H Weaver
Hi Chris, Chris Vine writes: > On Tue, 09 Apr 2019 04:35:38 -0400 > Mark H Weaver wrote: >> >> I think it's probably fine for 2.2, although a more careful check should >> be made for differences in behavior between the old and new >> implementations, and tests should be added. I'll try to get

Re: Unexpectedly low read/write performance of open-pipe

2019-04-09 Thread Chris Vine
On Tue, 09 Apr 2019 04:35:38 -0400 Mark H Weaver wrote: > Hi Rob, > > Rob Browning writes: > > > Mark H Weaver writes: > > > >> See below for a draft reimplementation of the OPEN_BOTH mode of > >> open-pipe* based on R6RS custom binary input/output. On my machine it > >> increases the speed o

Re: Unexpectedly low read/write performance of open-pipe

2019-04-09 Thread Mark H Weaver
Hi Rob, Rob Browning writes: > Mark H Weaver writes: > >> See below for a draft reimplementation of the OPEN_BOTH mode of >> open-pipe* based on R6RS custom binary input/output. On my machine it >> increases the speed of your test by a factor of ~1k. > > Hah, I was about to report that I'd tes