Patch with .texi updated also.
0001-In-string-split-add-support-for-character-sets-and-p.patch
Description: Binary data
Daniel Hartwig mand...@gmail.com writes:
Patch with .texi updated also.
Applied, thanks! :)
Mark
Daniel Hartwig mand...@gmail.com writes:
One final thing before I resubmit. I just notice that most of this
file has uses hard tabs, though there are places with soft. Is it
preferable to change the patch to also use hard tabs?
IMO, even when editing code that currently uses hard tabs, all
Hi!
Mark H Weaver m...@netris.org skribis:
I vaguely recall hearing somewhere that this autogeneration of docs was
considered a failed experiment, but we'd have to ask Andy or Ludovic
about that.
Well, look at this section of the manual (especially on hard copy), and
compare it to
Hi,
FWIW, I think tabs are OK in C files, but not in Scheme files, because
in the latter case, we want to be able to copy/paste without triggering
tab completion.
Our .dir-locals.el follows that.
Thanks,
Ludo’.
Hi Daniel,
The updated patch looks good except for a few minor nitpicks:
Daniel Hartwig mand...@gmail.com writes:
From 46178db9eecc9ca402d9571c3ee520074f15ef5a Mon Sep 17 00:00:00 2001
From: Daniel Hartwig mand...@gmail.com
Date: Mon, 8 Oct 2012 18:35:00 +0800
Subject: [PATCH] In
On 10 October 2012 01:48, Mark H Weaver m...@netris.org wrote:
+ if (!SCM_CHARSETP (char_pred))
{
- last_idx = idx;
- while (idx 0 buf[idx-1] != SCM_CHAR(chr))
-idx--;
- if (idx = 0)
-{
- res = scm_cons
Daniel Hartwig mand...@gmail.com writes:
On 10 October 2012 01:48, Mark H Weaver m...@netris.org wrote:
Please drop the unneeded curly braces above.
Are guile's macros safe to always use that way?
They should be. If they aren't, that's a bug IMO.
In libguile/__scm.h
the SCM_ASSERT
On 10 October 2012 10:14, Mark H Weaver m...@netris.org wrote:
Your latest patch looks good, but I just remembered one more thing:
doc/ref/api-data.texi needs to be updated.
I had assumed that was updated automatically from the doc strings,
which are in the right format.
?
Daniel Hartwig mand...@gmail.com writes:
On 10 October 2012 10:14, Mark H Weaver m...@netris.org wrote:
Your latest patch looks good, but I just remembered one more thing:
doc/ref/api-data.texi needs to be updated.
I had assumed that was updated automatically from the doc strings,
which are
On 10 October 2012 11:25, Mark H Weaver m...@netris.org wrote:
Daniel Hartwig mand...@gmail.com writes:
On 10 October 2012 10:14, Mark H Weaver m...@netris.org wrote:
Your latest patch looks good, but I just remembered one more thing:
doc/ref/api-data.texi needs to be updated.
I had assumed
Following up on the thread from last time regexp-split was discussed.
On 8 January 2012 07:05, Andy Wingo wi...@pobox.com wrote:
On Sat 31 Dec 2011 06:54, Daniel Hartwig mand...@gmail.com writes:
* [Vanilla `string-split' expanded to support the CHAR_PRED
semantics of `string-index' et al.]
Hi Daniel,
Thanks for the patch! I have a few comments.
Daniel Hartwig mand...@gmail.com writes:
From 0aeed16baa70eca143fec05e864f98d95d7267e8 Mon Sep 17 00:00:00 2001
From: Daniel Hartwig mand...@gmail.com
Date: Mon, 8 Oct 2012 18:35:00 +0800
Subject: [PATCH] In string-split, add support
Hi Mark
Thanks for the speedy response.
General ACK on all your comments. Some additional notes:
On 8 October 2012 23:40, Mark H Weaver m...@netris.org wrote:
[which vs. that]
This was straight out of the doc string for string-index. Changed.
+ if (SCM_CHARP (char_pred))
+{
+
14 matches
Mail list logo
