[PATCH] web: uri-encode hexadecimal percent-encoding is now uppercase

2013-05-02 Thread Aleix Conchillo Flaqué
This patch changes the way uri-encode does percent-encoding. The hexadecimal characters are now uppercase as suggested by RFC3986. So, (uri-encode /) = %2F Aleix uri-encode-uppercase.patch Description: Binary data

Re: [PATCH] web: uri-encode hexadecimal percent-encoding is now uppercase

2013-05-02 Thread Mark H Weaver
Hi Aleix, This patch looks good to me, except that I don't like the variable name 'num' for a string. Actually, I'm not sure we need to bind that to a variable at all. How about just wrapping 'string-upcase' around the call to 'number-string'? Thanks, Mark @@ -396,11 +396,12

Re: [PATCH] web: uri-encode hexadecimal percent-encoding is now uppercase

2013-05-02 Thread Aleix Conchillo Flaqué
On Thu, May 2, 2013 at 11:53 AM, Mark H Weaver m...@netris.org wrote: Hi Aleix, This patch looks good to me, except that I don't like the variable name 'num' for a string. Actually, I'm not sure we need to bind that to a variable at all. How about just wrapping 'string-upcase' around the

Re: [PATCH] web: uri-encode hexadecimal percent-encoding is now uppercase

2013-05-02 Thread Mark H Weaver
Hi Aleix, There was one remaining problem with your commit: web-uri.test contained some tests that assumed lowercase percent encoding. I took the liberty of modifying your commit to fix those tests, and then pushed it to stable-2.0. Thanks! Mark

Re: [PATCH] web: uri-encode hexadecimal percent-encoding is now uppercase

2013-05-02 Thread Aleix Conchillo Flaqué
On Thu, May 2, 2013 at 2:17 PM, Mark H Weaver m...@netris.org wrote: Hi Aleix, There was one remaining problem with your commit: web-uri.test contained some tests that assumed lowercase percent encoding. I took the liberty of modifying your commit to fix those tests, and then pushed it to