Re: fixes to goops + light structs + 'u' slots

2008-04-20 Thread Andy Wingo
Hi, On Sun 20 Apr 2008 01:07, Mikael Djurfeldt [EMAIL PROTECTED] writes: Well, apparently I'm the very author of this GC chain thing you are talking to me about. The only thing I can say is that there was probably a reason at the time to do this. The reason is simple: you need a class to

Re: fixes to goops + light structs + 'u' slots

2008-04-19 Thread Andy Wingo
Hi Mikael, On Tue 15 Apr 2008 00:16, Mikael Djurfeldt [EMAIL PROTECTED] writes: 2008/4/14, Andy Wingo [EMAIL PROTECTED]: Regarding memory consumption. Currently, structs are double-cells: one word for the vtable, one for the data, one empty, and one for the STRUCT_GC_CHAIN, used (please

Re: fixes to goops + light structs + 'u' slots

2008-04-19 Thread Mikael Djurfeldt
2008/4/19, Andy Wingo [EMAIL PROTECTED]: I wash my hands. :-) When I left, structs where two words. commit 08c880a36746289330f3722522960ea21fe4ddc8 Author: Mikael Djurfeldt [EMAIL PROTECTED] It is natural for our memory to fade over this much time ;-) But if at any point something

Re: fixes to goops + light structs + 'u' slots

2008-04-16 Thread Mikael Djurfeldt
2008/4/16, Andy Wingo [EMAIL PROTECTED]: On Sun 13 Apr 2008 21:09, Mikael Djurfeldt [EMAIL PROTECTED] writes: I then ran accessor ref tests on objects that necessarily had their slots bound, and thus would go through @assert-bound-ref: (3) If the determination can be made that the slot

Re: fixes to goops + light structs + 'u' slots

2008-04-16 Thread Mikael Djurfeldt
2008/4/16, Mikael Djurfeldt [EMAIL PROTECTED]: 2008/4/16, Andy Wingo [EMAIL PROTECTED]: On Sun 13 Apr 2008 21:09, Mikael Djurfeldt [EMAIL PROTECTED] writes: I then ran accessor ref tests on objects that necessarily had their slots bound, and thus would go through @assert-bound-ref:

Re: fixes to goops + light structs + 'u' slots

2008-04-15 Thread Andy Wingo
On Sun 13 Apr 2008 21:09, Mikael Djurfeldt [EMAIL PROTECTED] writes: At least given the state of Guile at the point when GOOPS accessors were implemented, the current imlementation was superior to both a slot-ref-based and a SMOB-based implementation. [...] In any case, *please* always

Re: fixes to goops + light structs + 'u' slots

2008-04-14 Thread Andy Wingo
Hi Mikael! On Sun 13 Apr 2008 21:09, Mikael Djurfeldt [EMAIL PROTECTED] writes: I have heard that in a well-done CLOS implementation, accessors are are generally faster than slot-ref Note that the current implementation *does* compile in the slot position into this form and indeed *has*

Re: fixes to goops + light structs + 'u' slots

2008-04-14 Thread Mikael Djurfeldt
2008/4/14, Andy Wingo [EMAIL PROTECTED]: I have shied away from GOOPS internals in the past, but every time I have a brush with them I learn something interesting. You're very kind. It's in large parts not easily readable code. What is your perspective regarding foreign-slot? I wrote a bit

Re: fixes to goops + light structs + 'u' slots

2008-04-14 Thread Mikael Djurfeldt
2008/4/14, Andy Wingo [EMAIL PROTECTED]: Is this designed to work? It seems that all is still not right, @slot-ref (only used in accessors, not in slot-ref) accesses the slot as a SCM Right, the special form is @slot-ref, not @assert-bound-ref as I stated previously.