Re: guile pipeline do-over

Hi Rutger, It’s been a looong process (apologies!), but I’m happy to say that this patch is now in master! Hopefully your future contributions will be quicker to get in, otherwise there won’t be anyone to blame but the maintainers. ;-) Rutger van Beusekom skribis: > From

Re: guile pipeline do-over

Hi Ludo, Ludovic Courtès writes: > Hi Rutger, > > (+Cc: Andy.) > > Rutger van Beusekom skribis: > >> From d351c0a5ecde62e63368bec0e1f15108495a1a71 Mon Sep 17 00:00:00 2001 >> From: Rutger van Beusekom >> Date: Mon, 2 Mar 2020 10:38:57 +0100 >> Subject: [PATCH] Add pipeline procedure. >> >> *

Re: guile pipeline do-over

Hi Rutger, (+Cc: Andy.) Rutger van Beusekom skribis: > From d351c0a5ecde62e63368bec0e1f15108495a1a71 Mon Sep 17 00:00:00 2001 > From: Rutger van Beusekom > Date: Mon, 2 Mar 2020 10:38:57 +0100 > Subject: [PATCH] Add pipeline procedure. > > * libguile/posix.c (scm_open_process): Remove. >

Re: guile pipeline do-over

Hi Linus, pipeline is implemented with piped-process, which is implemented with scm_start_child, which does not use the shell. In your pipeline you can use a shell explicitly if you wanted to. I do not think I should follow the asterisk convention in procedure naming for pipeline. What do you

Re: guile pipeline do-over

I have a question about the interface. It uses the shell now, it seems. (I could be wrong). The guile system call has a (system cmd ) which uses the shell and a system* call which takes (system* cmd arg ...) So that it does not rely on the shell. Maybe a similar interface could be useful (and

Re: guile pipeline do-over

Hi Ludo, I have processed your feedback in this version of the patch. Ludovic Courtès writes: > Hi Rutger! > >> ... > Nice! That’s definitely very useful to have. We’ll need to check what > Andy thinks, but I think it can be added in the 3.0 series. > > >> ... > Could you mention functions

Re: guile pipeline do-over

Hi Rutger! Rutger van Beusekom skribis: > This patch replaces open-process with piped-process in posix.c and > reimplement open-process with piped-process in popen.scm. This allows > setting up a pipeline in guile scheme using the new pipeline procedure > in popen.scm and enables its use on

guile pipeline do-over

Hi, I submitted a previous version of this patch yesterday, only to find that making last minute changes is a big fat no no. Anyhow, having fixed the two problems I found, I also added the tests I should have written and run before sending my patch. Best, Rutger Content of previous email below: