Re: request review: branch wingo

2009-04-12 Thread Neil Jerram
Andy Wingo wi...@pobox.com writes: I went ahead and pushed an 80%-only patch, as you suggest. All UNIX systems that I know of have getrlimit. Windows does not of course, but it seems that their stack limit is hard-coded: http://www.mapleprimes.com/forum/stack_limit In any case, it

Re: request review: branch wingo

2009-04-03 Thread Andy Wingo
Howdy, On Wed 01 Apr 2009 15:23, Neil Jerram n...@ossau.uklinux.net writes: l...@gnu.org (Ludovic Courtès) writes: I have no objection to that. We still want to support existing scripts, of course - but I assume that's why you said mark as deprecated and not remove. :-) I agree :) We can

Re: request review: branch wingo

2009-04-01 Thread Ludovic Courtès
Hi Neil, Neil Jerram n...@ossau.uklinux.net writes: Should we then put the Makefile.am code back? Or does that break your uninstalled usage? Other things being equal, I think it's more important for the generated guile-config to be simple, than for our Makefile.am to be simple. Speaking

Re: request review: branch wingo

2009-04-01 Thread Ludovic Courtès
Hello! Andy Wingo wi...@pobox.com writes: On Tue 31 Mar 2009 14:31, l...@gnu.org (Ludovic Courtès) writes: Besides, there's the thread about cross-compilation where we mention building the compiler with an already installed Guile that may have an inappropriate stack limit. I don't think

Re: request review: branch wingo

2009-03-31 Thread Ludovic Courtès
Andy Wingo wi...@pobox.com writes: So, I really intended to wait for review, but it's irritating having `master' broken, so I went ahead and merged this in. You waited for 31 hours and I still don't know how it was broken, which I find irritating as well. I think the stack calibration stuff

Re: request review: branch wingo

2009-03-31 Thread Ludovic Courtès
Hello, Andy Wingo wi...@pobox.com writes: .scm.go: $(MKDIR_P) `dirname $...@` $(top_builddir)/pre-inst-guile \ -l $(top_builddir)/libguile/stack-limit-calibration.scm \ $(top_srcdir)/scripts/compile -o $@ $ This will

Re: request review: branch wingo

2009-03-31 Thread Andy Wingo
Howdy howdy, On Tue 31 Mar 2009 14:31, l...@gnu.org (Ludovic Courtès) writes: Besides, there's the thread about cross-compilation where we mention building the compiler with an already installed Guile that may have an inappropriate stack limit. I don't think that is relevant. Since the

Re: request review: branch wingo

2009-03-31 Thread Neil Jerram
Andy Wingo wi...@pobox.com writes: Hi Neil, Thanks for the review. Pleasure. By the way, on the general point of pushing possibly-contentious stuff to git.sv.gnu.org master... - I certainly don't think it's the end of the world to do this. We have complete history and can back things out

Re: request review: branch wingo

2009-03-30 Thread Neil Jerram
Andy Wingo wi...@pobox.com writes: Hey all, On Fri 27 Mar 2009 16:29, Andy Wingo wi...@pobox.com writes: On the wingo branch in the main repository, you will find the following patches: So, I really intended to wait for review, but it's irritating having `master' broken, so I went ahead

Re: request review: branch wingo

2009-03-29 Thread Andy Wingo
Hey all, On Fri 27 Mar 2009 16:29, Andy Wingo wi...@pobox.com writes: On the wingo branch in the main repository, you will find the following patches: So, I really intended to wait for review, but it's irritating having `master' broken, so I went ahead and merged this in. I think the stack

Re: request review: branch wingo

2009-03-29 Thread Neil Jerram
Andy Wingo wi...@pobox.com writes: Please let me know if yall have a concern with this merge -- we can fix it tomorrow or Monday. I'll aim to take a look tomorrow evening. Neil