Re: string_abstraction2 review

2009-07-19 Thread Mike Gran
On Thu, 2009-06-11 at 23:12 +0200, Andy Wingo wrote: Howdy good sir! I'm back on task. I'll go through your comments from the review of a month or so ago, and try to push the Unicode stuff next week. Things seem stable on my end, but, some optimization work remains to be done. With respect

string_abstraction2 review

2009-06-11 Thread Andy Wingo
Howdy good sir! I've been taking a look at string_abstraction2 this evening. (Well, I wrote that last evening. Time passes!) I'm really looking forward to it going in. The concepts seem sound, but I think the branch could be even better with a rebase. Further comments and impressions: commit

Re: string_abstraction2 review

2009-06-11 Thread Andreas Rottmann
Andy Wingo wi...@pobox.com writes: commit a462ad13abac7f12fa370fb1724a6eb7d80edcb2 Author: Michael Gran spk...@yahoo.com Date: Mon May 18 07:50:21 2009 -0700 string abstraction on charsets and combine redundant string_ref_to_XXX I still thing scm_i_string_ref should