Re: [PATCH] srfi-64: fix unused variable warnings

2021-04-01 Thread Maxime Devos
On Wed, 2021-03-31 at 23:11 -0700, Aleix Conchillo Flaqué wrote: > * module/srfi/srfi-64/testing.scm: remove unused name variable and use > let instead of let*. > I don't think this is the correct approach with respect to side effects. For example, in: > (define (%test-comp2 comp x) > (syn

[PATCH] srfi-64: fix double evaluation of test-name

2021-04-01 Thread Aleix Conchillo Flaqué
* module/srfi/srfi-64/testing.scm: fix double test-name evaluation which also fix unused variable warnings as a bonus. Signed-off-by: Aleix Conchillo Flaqué --- module/srfi/srfi-64/testing.scm | 36 - 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a

Re: [PATCH] srfi-64: fix unused variable warnings

2021-04-01 Thread Aleix Conchillo Flaqué
Hi Maxime, Thank you for your comments! On Thu, Apr 1, 2021 at 4:37 AM Maxime Devos wrote: > For example, in: > > > (define (%test-comp2 comp x) > > (syntax-case (list x (list (syntax quote) (%test-source-line2 x)) > > comp) () > >(((mac tname expected expr) line comp) > >

Re: [PATCH] srfi-64: fix unused variable warnings

2021-04-01 Thread Maxime Devos
On Thu, 2021-04-01 at 23:12 -0700, Aleix Conchillo Flaqué wrote: > Hi Maxime, > > Thank you for your comments! > > On Thu, Apr 1, 2021 at 4:37 AM Maxime Devos wrote: > > > For example, in: > > > > > (define (%test-comp2 comp x) > > > (syntax-case (list x (list (syntax quote) (%test-sourc