Re: Patch file for colorize module

2018-05-26 Thread Ricardo Wurmus
Hi Sahithi, > I went wrong in squashing. Please check the current attachment. Thank you. I’ve made a couple of minor changes and pushed it to the branch “wip-sahithi”. These are some of the changes: * Removed whitespace changes and trailing whitespace. * Moved the docstring of

Re: Patch file for colorize module

2018-05-26 Thread Sahitihi
I went wrong in squashing. Please check the current attachment. > Hi Ricardo, > >> I’d be happy if you could make these changes quickly and send an updated >> patch. Once I receive it I’ll push it to a branch “wip-sahithi” in the >> repository. >> > I have made the above changes. Please notify

Re: Patch file for colorize module

2018-05-26 Thread Sahitihi
Hi Ricardo, > I’d be happy if you could make these changes quickly and send an updated > patch. Once I receive it I’ll push it to a branch “wip-sahithi” in the > repository. > I have made the above changes. Please notify if i have to make further changes. I mean while, I will be trying out

Customize GuixSD: Use Stock SSH Agent Everywhere!

2018-05-26 Thread Ludovic Courtès
Hello Guix! Chris contributed an article showing a neat hack to get ssh-agent running on GNOME in lieu of GNOME Keyring’s custom implementation: https://www.gnu.org/software/guix/blog/2018/customize-guixsd-use-stock-ssh-agent-everywhere/ Enjoy! And thanks Chris! Ludo’.

Re: Patch file for colorize module

2018-05-26 Thread Ricardo Wurmus
Hi Sahithi, > Please find the attachment. Hope I made it correct this time. :) Thanks, this looks a lot better. Some comments below: > From 1bd9eaca576e7d958062197b9931d64c0882484e Mon Sep 17 00:00:00 2001 > From: root This indicates that you’re doing development

Re: 01/01: gnu: cmake: Delete Emacs library.

2018-05-26 Thread Marius Bakke
Oleg Pykhalov writes: > Hello Mark, > > Thank you for explanation of procedure and macro specifications. > I've pushed ffd526e61ab1b45c6c913ab4e139193e4d5bee9b with a fix. > > Also, here is a patch to mention core-updates-next in the documentation. > > diff --git

Re: Patch file for colorize module

2018-05-26 Thread Sahitihi
Hi Ricardo, Please find the attachment. Hope I made it correct this time. :) On Saturday 26 May 2018 03:05 PM, Ricardo Wurmus wrote: > git rebase -i > $start_commit >From 1bd9eaca576e7d958062197b9931d64c0882484e Mon Sep 17 00:00:00 2001 From: root Date: Sat, 26 May

Re: Patch file for colorize module

2018-05-26 Thread Ricardo Wurmus
Hi Sahithi, please take a look at the file you sent. It only contains the copyright line. You may need to squash the two recent commits into one and then format the patch. Squashing can be done easily with “git rebase -i $start_commit”. Could you please send another patch? -- Ricardo

Re: Patch file for colorize module

2018-05-26 Thread Sahitihi
Sorry, Please find patch file attached to this mail. Kindly ignore the previous one. I have made a small change to Copyrights line to that of previous. > Hi Ricardo, > > Please find the attachment.. > >> Please attach the file of that same name in an email. > Also add any corrections that i need