Re: [PATCH] gnu: Add mcelog.

Tobias Geerinckx-Rice writes: > Marius, > > On 14/09/16 17:19, Marius Bakke wrote: >> Another thing, I think the snippet should be moved to a phase, as AFAIK >> origin snippets should be reserved for removing unwanted files, or for >> reproducibility. > > Not if we use your

Re: [PATCH] gnu: Add mcelog.

Danny, Marius, Danny Milosavljevic writes: > DESTDIR is a feature which lets you install into a tempdir. The idea > is that you install it all there and then atomically replace the > ORIGINAL version at the non-DESTDIR location. Herp. I know all this, no idea how I

Re: [PATCH] gnu: Add mcelog.

Marius, On 14/09/16 17:19, Marius Bakke wrote: > Another thing, I think the snippet should be moved to a phase, as AFAIK > origin snippets should be reserved for removing unwanted files, or for > reproducibility. Not if we use your suggested snapshot tarball, which rightly lack a .git directory.

Re: [PATCH] gnu: Add mcelog.

DESTDIR is a feature which lets you install into a tempdir. The idea is that you install it all there and then atomically replace the ORIGINAL version at the non-DESTDIR location. It's very bad to set DESTDIR to out because the outdir is used after installation, too (your program will stay at

Re: [PATCH] gnu: Add mcelog.

Danny Milosavljevic writes: > DESTDIR is a feature which lets you install into a tempdir. The idea > is that you install it all there and then atomically replace the > ORIGINAL version at the non-DESTDIR location. Oops, I meant DOCDIR! Sorry for the confusion! >> >> +

Re: [PATCH] gnu: Add mcelog.

> >> +(home-page "http://mcelog.org/;) > > Nit-pick: the trailing slash is unnecessary :) If you don't include the trailing slash it will require an additional round-trip to the server in order to add it via a (302) redirect.

Re: [PATCH] gnu: Add mcelog.

Tobias Geerinckx-Rice writes: > On 14/09/16 15:45, Marius Bakke wrote: >> It's not visible in the cgit interface, but it actually seems to >> support normal snapshot downloads: >> https://git.kernel.org/cgit/utils/cpu/mce/mcelog.git/snapshot/v141.tar.gz > > I did not know that.

Re: [PATCH] gnu: Add mcelog.

Ludo', On 14/09/16 17:02, Ludovic Courtès wrote: > Please align the #:. > Remove leading space here. Yup, I noticed :-) Thanks. Kind regards, T G-R signature.asc Description: OpenPGP digital signature

Re: [PATCH] gnu: Add mcelog.

Tobias Geerinckx-Rice skribis: > * gnu/packages/linux.scm (mcelog): New variable. To complement what Marius wrote… > +(arguments > + `(#:phases (modify-phases %standard-phases > + (delete 'configure)) ; no configure script > +

Re: [PATCH] gnu: Add mcelog.

Marius, On 14/09/16 15:45, Marius Bakke wrote: > It's not visible in the cgit interface, but it actually seems to > support normal snapshot downloads: > https://git.kernel.org/cgit/utils/cpu/mce/mcelog.git/snapshot/v141.tar.gz I did not know that. Thanks for the tip! It still requires a

Re: [PATCH] gnu: Add mcelog.

Tobias Geerinckx-Rice writes: > * gnu/packages/linux.scm (mcelog): New variable. Thanks! > --- > gnu/packages/linux.scm | 41 + > 1 file changed, 41 insertions(+) > > diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm > index

[PATCH] gnu: Add mcelog.

* gnu/packages/linux.scm (mcelog): New variable. --- gnu/packages/linux.scm | 41 + 1 file changed, 41 insertions(+) diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm index 3ec6514..fc4faa4 100644 --- a/gnu/packages/linux.scm +++