Re: [PATCH] gnu: Add twolame.

2015-02-24 Thread Mark H Weaver
taylanbayi...@gmail.com (Taylan Ulrich "Bayırlı/Kammer") writes: > From 79a35cc12ebb07b789c08ca943465f11db3e199e Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?= > > Date: Fri, 20 Feb 2015 21:51:09 +0100 > Subject: [PATCH 4/8] gnu: Add twolame. > > * gnu/pa

Re: [PATCH] gnu: Add twolame.

2015-02-24 Thread Taylan Ulrich Bayırlı/Kammer
Andreas Enge writes: > On Mon, Feb 23, 2015 at 10:42:35PM +0100, Taylan Ulrich Bayırlı/Kammer wrote: >> Other than that, we could modify that file to remove that check, knowing >> that `sndfile-convert' is there, since the inputs have `libsndfile'. >> Should we go that way, how about: > > I do no

Re: [PATCH] gnu: Add twolame.

2015-02-23 Thread Andreas Enge
On Mon, Feb 23, 2015 at 10:42:35PM +0100, Taylan Ulrich Bayırlı/Kammer wrote: > Other than that, we could modify that file to remove that check, knowing > that `sndfile-convert' is there, since the inputs have `libsndfile'. > Should we go that way, how about: I do not know. If it is used and neede

Re: [PATCH] gnu: Add twolame.

2015-02-23 Thread Taylan Ulrich Bayırlı/Kammer
Andreas Enge writes: > On Sun, Feb 22, 2015 at 01:18:25PM +0100, Taylan Ulrich Bayırlı/Kammer wrote: >> I noticed that occasionally some ./configure scripts will say "which: >> command not found" and in that case I add it. I didn't look into what >> difference it makes though, since it doesn't m

Re: [PATCH] gnu: Add twolame.

2015-02-23 Thread Andreas Enge
On Sun, Feb 22, 2015 at 01:18:25PM +0100, Taylan Ulrich Bayırlı/Kammer wrote: > I noticed that occasionally some ./configure scripts will say "which: > command not found" and in that case I add it. I didn't look into what > difference it makes though, since it doesn't make the configure script > f

Re: [PATCH] gnu: Add twolame.

2015-02-22 Thread Taylan Ulrich Bayırlı/Kammer
Andreas Enge writes: >> + ("which" ,which))) > > What is this needed for? Maybe add a little comment as it is rather > unusual. I noticed that occasionally some ./configure scripts will say "which: command not found" and in that case I add it. I didn't look into what difference it makes t

Re: [PATCH] gnu: Add twolame.

2015-02-22 Thread Andreas Enge
On Sun, Feb 22, 2015 at 12:24:23AM +0100, Taylan Ulrich Bayırlı/Kammer wrote: > + ("which" ,which))) What is this needed for? Maybe add a little comment as it is rather unusual. Otherwise it looks good. There is at least one package, ffmpeg, that can take twolame as an additional input (see

[PATCH] gnu: Add twolame.

2015-02-21 Thread Taylan Ulrich Bayırlı/Kammer
>From ad7a15b990eb340bd491b99eb70e36675d277b92 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?= Date: Fri, 20 Feb 2015 21:51:09 +0100 Subject: [PATCH 7/9] gnu: Add twolame. * gnu/packages/audio.scm (twolame): New variable. --- gnu/packages/audio.scm | 26 +++