Re: Patch Review Flow

2023-12-10 Thread Tobias Alexandra Platen
This is also interesting for me, since I have created my first patch for guix: adding libsurvive as a package. Alex

Re: Patch Review Flow

2023-11-07 Thread jgart
There's also the following workflow: Click on an individual patch in the mumi web interface to download it to ~/Downloads. cd guix-checkout git am -S ~/Downloads/53019-76.mbox Go back to the mumi interface and click on the next patch. Repeat.  > Should we document an approach in the

Re: Patch Review Flow

2023-11-07 Thread Maxim Cournoyer
Hi jgart, "jgart" writes: > Hi Guixers, > > Does anyone follow this workflow for reviewing patches? > > git clone https://git.guix-patches.cbaines.net/guix-patches/ > git checkout issue-x > git format-patch ... > # then in the development checkout of Guix: > git am ...; make; ./pre-inst-env

Re: Patch Review Flow

2023-11-07 Thread jgart
> I've had it installed forever but only ever used it for viewing commits and > branches. ditto! -- jgart

Re: Patch Review Flow

2023-11-07 Thread Efraim Flashner
On Tue, Nov 07, 2023 at 12:32:35PM +, jgart wrote: > Hi Efraim, > > Thanks for sharing your approach as well. IIRC, a user can't interactively > cherry-pick a range with tig. If you find a way please do share ;() It looks like 'C' (that's a 'big c') over a commit will offer to cherry-pick

Re: Patch Review Flow

2023-11-07 Thread jgart
Hi Efraim, Thanks for sharing your approach as well. IIRC, a user can't interactively cherry-pick a range with tig. If you find a way please do share ;()

Re: Patch Review Flow

2023-11-07 Thread Efraim Flashner
On Mon, Nov 06, 2023 at 07:51:58AM +, Christopher Baines wrote: > > "jgart" writes: > > > Does anyone follow this workflow for reviewing patches? > > > > git clone https://git.guix-patches.cbaines.net/guix-patches/ > > git checkout issue-x > > git format-patch ... > > # then in the

Re: Patch Review Flow

2023-11-06 Thread jgart
> which I then cherry pick from (via Magit), which makes it quick and easy to > apply patches. Hi Chris, That's a great idea to use magit to select the range of patches to apply. I was doing it in a more painful way via the CLI. thanks, jgart

Re: Patch Review Flow

2023-11-06 Thread Clément Lassieur
On Mon, Nov 06 2023, Christopher Baines wrote: > "jgart" writes: > >> Does anyone follow this workflow for reviewing patches? >> >> git clone https://git.guix-patches.cbaines.net/guix-patches/ >> git checkout issue-x >> git format-patch ... >> # then in the development checkout of Guix: >>

Re: Patch Review Flow

2023-11-05 Thread Christopher Baines
"jgart" writes: > Does anyone follow this workflow for reviewing patches? > > git clone https://git.guix-patches.cbaines.net/guix-patches/ > git checkout issue-x > git format-patch ... > # then in the development checkout of Guix: > git am ...; make; ./pre-inst-env guix build > > Should we

Patch Review Flow

2023-11-05 Thread jgart
Hi Guixers, Does anyone follow this workflow for reviewing patches? git clone https://git.guix-patches.cbaines.net/guix-patches/ git checkout issue-x git format-patch ... # then in the development checkout of Guix: git am ...; make; ./pre-inst-env guix build Should we document it in the