Re: New review checklist

2022-04-02 Thread Liliana Marie Prikler
Am Samstag, dem 02.04.2022 um 15:38 +0200 schrieb Bengt Richter: > Hi Liliana, Maxime, et al, > [...] > Here ISTM important to understand exactly what you mean by "let- > binding" so I would really like it if I could type > > --8<---cut here---start->8--- >    

Re: New review checklist

2022-04-02 Thread Bengt Richter
Hi Liliana, Maxime, et al, On +2022-04-01 20:25:37 +0200, Liliana Marie Prikler wrote: > Hi Maxime, > > Am Freitag, dem 01.04.2022 um 19:46 +0200 schrieb Maxime Devos: > > [...] > > I know there have been some discussions in the past about whether > > git-version should be used when a commit is

Re: New review checklist

2022-04-01 Thread Liliana Marie Prikler
Hi Maxime, Am Freitag, dem 01.04.2022 um 19:46 +0200 schrieb Maxime Devos: > [...] > I know there have been some discussions in the past about whether > git-version should be used when a commit is explicitly chosen, > whether > tags should be used instead of commits, how high a risk there is that

Re: New review checklist

2022-04-01 Thread Tobias Geerinckx-Rice
>-- would the commit need to be let-bound here? You seem to already know the answer, which is 'no'. Aside, 'let-binding' is not the opposite of 'hard-coding'. Kind regards, T G-R Sent on the go. Excuse or enjoy my brevity.

Re: New review checklist

2022-04-01 Thread Maxime Devos
Liliana Marie Prikler schreef op vr 01-04-2022 om 19:03 [+0200]: > Hi Maxime, > > [...] > > > > -- would the commit need to be let-bound here? > This discussion has already been had elsewhere, but to reiterate, my > reasoning is that if you can't trust upstream tags to remain valid, you > need

Re: New review checklist

2022-04-01 Thread Liliana Marie Prikler
Hi Maxime, Am Freitag, dem 01.04.2022 um 08:30 +0200 schrieb Maxime Devos: > Liliana Marie Prikler schreef op vr 01-04-2022 om 06:14 [+0200]: > > It won't be added to Guix.  Here's why it won't. > > You appear to believe that > > [...] > > [ ] hard-coding the commit field is a good idea > > Does

Re: New review checklist

2022-04-01 Thread Jonathan McHugh
There is no reference to XML. Nor does it provide any interopabilietie with SOAP. Please stop wasting the mailinglists time with this non XML based hokum, this is Guxi.FFSaek. :) Jonathan McHugh indieterminacy@libre.brussels April 1, 2022 6:15 AM, "Liliana Marie Prikler"

Re: New review checklist

2022-04-01 Thread tanguy
Dear Liliana, On 2022-04-01 04:14, Liliana Marie Prikler wrote: in the sequel find the new review checklist, effective immediately. Failure to apply it will result in the confiscation of your machine for the purpose of making it usable for continuous integration. The last patch I submitted

Re: New review checklist

2022-04-01 Thread Maxime Devos
Liliana Marie Prikler schreef op vr 01-04-2022 om 06:14 [+0200]: > It won't be added to Guix. Here's why it won't. > You appear to believe that > [...] > [ ] hard-coding the commit field is a good idea Does the following count: (define-public foo (package (name "foo") (version