Re: Process for reviewing patches as someone without commit access

2023-10-04 Thread Ludovic Courtès
Hello, Christopher Baines skribis: > That form then takes you to a page to submit the review. This can be > done through the mailto link, or by following the manual > instructions. Of course people using other ways of interacting with > debbugs can also just add the reviewed-looks-good usertag

Re: Process for reviewing patches as someone without commit access

2023-09-27 Thread Christopher Baines
Christopher Baines writes: > I've been reviewing the list of ideas on and around QA ([1]) recently, > and got thinking again about how to support people without commit access > reviewing patches. Obviously you don't need commit access to review > patches, but where I think we need some process

Re: Process for reviewing patches as someone without commit access

2023-09-09 Thread Simon Tournier
Hi, There are only two hard things in Computer Science… On Thu, 07 Sep 2023 at 09:19, Vagrant Cascadian wrote: >>> Discussing about idea, would it be possible that the QA infrastructure >>> automatically send a message to Debbugs for tagging? For example, the >>> usertag ’qa-ok’ or whatever

Re: Process for reviewing patches as someone without commit access

2023-09-07 Thread Vagrant Cascadian
On 2023-09-06, Maxim Cournoyer wrote: > Simon Tournier writes: >> On Wed, 06 Sep 2023 at 16:55, Christopher Baines wrote: >> >>> Once we know what tags to use, I can have the QA frontpage do something >>> similar to the "Mark as moreinfo" links, so it's easy to just click a >>> button then send

Re: Process for reviewing patches as someone without commit access

2023-09-07 Thread Simon Tournier
Hi, On Wed, 06 Sep 2023 at 22:47, Maxim Cournoyer wrote: >> Well, using emacs-debbugs and then >> >> C-u M-x debbugs-gnu-usertags guix-patches RET >> >> the list of usertags is: >> >> guix-patches for-core-updates >> guix-patches reviewed-looks-good >> >> And if instead of

Re: Process for reviewing patches as someone without commit access

2023-09-06 Thread Maxim Cournoyer
Hi Simon, Chris, Simon Tournier writes: > Hi Chris, all, > > On Wed, 06 Sep 2023 at 16:55, Christopher Baines wrote: > >> Once we know what tags to use, I can have the QA frontpage do something >> similar to the "Mark as moreinfo" links, so it's easy to just click a >> button then send the

Re: Process for reviewing patches as someone without commit access

2023-09-06 Thread Simon Tournier
Hi Chris, all, On Wed, 06 Sep 2023 at 16:55, Christopher Baines wrote: > Once we know what tags to use, I can have the QA frontpage do something > similar to the "Mark as moreinfo" links, so it's easy to just click a > button then send the email to change the state of a issue. That’s cool!

Re: Process for reviewing patches as someone without commit access

2023-09-06 Thread Simon Tournier
Hi Felix, On Wed, 06 Sep 2023 at 12:01, Felix Lechner via "Development of GNU Guix and the GNU System distribution." wrote: > Usually, helpful reviews come from people with more experience. In > your system they come from folks with less. That seems upside down to > me. Well, I think we are

Re: Process for reviewing patches as someone without commit access

2023-09-06 Thread Development of GNU Guix and the GNU System distribution.
Hi Chris, On Wed, Sep 6, 2023 at 11:39 AM Christopher Baines wrote: > > I don't want to make reviewing changes more difficult, and I think > setting up more people with commit access and continuing the trend that > it's mostly people with commit access that review changes would increase > the

Re: Process for reviewing patches as someone without commit access

2023-09-06 Thread Christopher Baines
Felix Lechner writes: > On Wed, Sep 6, 2023 at 9:47 AM Christopher Baines wrote: >> >> Maybe we can use debbugs tags for this? > > Instead of pushing people into reviews and then again making the same > committers a bottleneck, I would offer some entry-level contributors > commit rights but

Re: Process for reviewing patches as someone without commit access

2023-09-06 Thread Development of GNU Guix and the GNU System distribution.
Hi Chris, On Wed, Sep 6, 2023 at 9:47 AM Christopher Baines wrote: > > Maybe we can use debbugs tags for this? Instead of pushing people into reviews and then again making the same committers a bottleneck, I would offer some entry-level contributors commit rights but require that they obtain