Re: move "source /etc/profile" from .zlogin to .zprofile

2018-10-19 Thread Chris Marusich
l...@gnu.org (Ludovic Courtès) writes: > Alright, so Chris you can probably go ahead and push the patch! Sounds good! I've committed this to master as 2f4d43584cb26315c028dfbd2197da0d175933a2. -- Chris signature.asc Description: PGP signature

Re: move "source /etc/profile" from .zlogin to .zprofile

2018-10-16 Thread Ludovic Courtès
Leo Famulari skribis: > On Mon, Oct 15, 2018 at 11:48:01AM +0200, Ludovic Courtès wrote: >> Hello, >> >> Chris Marusich skribis: >> >> > I see. I'm not a zsh user, but I agree it would make sense to rename >> > .zlogin to .zprofile. I've attached a patch that does this in our >> >

Re: move "source /etc/profile" from .zlogin to .zprofile

2018-10-15 Thread Leo Famulari
On Mon, Oct 15, 2018 at 11:48:01AM +0200, Ludovic Courtès wrote: > Hello, > > Chris Marusich skribis: > > > I see. I'm not a zsh user, but I agree it would make sense to rename > > .zlogin to .zprofile. I've attached a patch that does this in our > > /etc/skel. I haven't tested it, though.

Re: move "source /etc/profile" from .zlogin to .zprofile

2018-10-15 Thread Ludovic Courtès
Hello, Chris Marusich skribis: > I see. I'm not a zsh user, but I agree it would make sense to rename > .zlogin to .zprofile. I've attached a patch that does this in our > /etc/skel. I haven't tested it, though. Would you like to test it and > let me know if it works for you? I don’t use

Re: move "source /etc/profile" from .zlogin to .zprofile

2018-10-14 Thread Meiyo Peng
Hi Chris, On Sun, Oct 14, 2018 at 6:30 AM Chris Marusich wrote: > I haven't tested it, though. Would you like to test it and > let me know if it works for you? Guix is still new to me, and I don't know how to apply the patch and build guix. But I moved "source /etc/profile" from my .zlogin to

Re: move "source /etc/profile" from .zlogin to .zprofile

2018-10-14 Thread Chris Marusich
Hi Leo and Meiyo, Leo Famulari writes: > On Sat, Oct 13, 2018 at 06:33:59PM -0700, Chris Marusich wrote: >> [...] If .zprofile and .zlogin are both meant to serve the same >> purpose, then I'm not sure why one would be preferable over the >> other. > > The difference is that they are used at

Re: move "source /etc/profile" from .zlogin to .zprofile

2018-10-13 Thread Meiyo Peng
Hi Chris, /etc/profile should do the preparation work for users settings in .zshrc. But since .zlogin is sourced after .zshrc, it will override users settings in .zshrc. It resets $PATH and many other environment variables. This is counterintuitive. You can find what archlinux did here:

Re: move "source /etc/profile" from .zlogin to .zprofile

2018-10-13 Thread Leo Famulari
On Sat, Oct 13, 2018 at 06:33:59PM -0700, Chris Marusich wrote: > The same documentation you linked says: > > `.zprofile' is meant as an alternative to `.zlogin' for ksh fans; > the two are not intended to be used together, although this could > certainly be done if desired. > > Is

Re: move "source /etc/profile" from .zlogin to .zprofile

2018-10-13 Thread Chris Marusich
Hi Meiyo, Meiyo Peng writes: > Guix's default skeletons put "source /etc/profile" into ~/.zlogin. But > /etc/profile resets the PATH environment variable, exports many other > environment variables, and source /etc/bashrc. According to > http://zsh.sourceforge.net/Intro/intro_3.html .zlogin is