Re: java: switch to icedtea-8 as default JDK

Gábor Boskovits writes: > 2018-01-06 21:16 GMT+01:00 Gábor Boskovits : > >> It would also be nice, if you could review the patches already sent to >> guix-patches. >> They are tagged [PATCH core-updates]. OK, I'll find them and take a look this week.

Re: java: switch to icedtea-8 as default JDK

2018-01-07 18:25 GMT+01:00 Ricardo Wurmus : > > Gábor Boskovits writes: > > > https://github.com/Boskovits/guix/issues/58 > … > > What I don't understand, is why setting source and target to 1.7, > > like I did on java-aqute-libg did not work. > > How did

Re: java: switch to icedtea-8 as default JDK

Gábor Boskovits writes: > https://github.com/Boskovits/guix/issues/58 … > What I don't understand, is why setting source and target to 1.7, > like I did on java-aqute-libg did not work. How did you set it? Since this is using the package’s own build.xml you’d need to

Re: java: switch to icedtea-8 as default JDK

2018-01-06 21:16 GMT+01:00 Gábor Boskovits : > Actually we still have a couple of build failures, some test failures, and > the > commit messages are not conformant to the policy. Currently making the few > remainig > failures work should be the primary task. I will check the

Re: java: switch to icedtea-8 as default JDK

Gábor Boskovits writes: > If I understand well, then the check phase in ant-build-system > runs without make-flags. > In the definition of java-asm we configure the build with make-flags, so > the build system > does not complain about missing configuration. > This

Re: java: switch to icedtea-8 as default JDK

Actually we still have a couple of build failures, some test failures, and the commit messages are not conformant to the policy. Currently making the few remainig failures work should be the primary task. I will check the details. I already have an integration branch where I reorder commits and

Re: java: switch to icedtea-8 as default JDK

Gábor Boskovits writes: > 2018-01-05 16:44 GMT+01:00 Ricardo Wurmus : > >> >> Gábor Boskovits writes: >> >> > If I understand well, then the check phase in ant-build-system >> > runs without make-flags. >> > In the definition of

Re: java: switch to icedtea-8 as default JDK

2018-01-05 16:44 GMT+01:00 Ricardo Wurmus : > > Gábor Boskovits writes: > > > If I understand well, then the check phase in ant-build-system > > runs without make-flags. > > In the definition of java-asm we configure the build with make-flags, so > > the

Re: java: switch to icedtea-8 as default JDK

2017-12-20 13:29 GMT+01:00 Gábor Boskovits : > 2017-12-20 11:34 GMT+01:00 Gábor Boskovits : > >> 2017-12-19 23:11 GMT+01:00 Ricardo Wurmus : >> >>> >>> Gábor Boskovits writes: >>> >>> > Now I have another blocking

Re: java: switch to icedtea-8 as default JDK

2017-12-20 11:34 GMT+01:00 Gábor Boskovits : > 2017-12-19 23:11 GMT+01:00 Ricardo Wurmus : > >> >> Gábor Boskovits writes: >> >> > Now I have another blocking issue: >> > https://github.com/Boskovits/guix/issues/24 >> >> > Error

Re: java: switch to icedtea-8 as default JDK

2017-12-19 23:11 GMT+01:00 Ricardo Wurmus : > > Gábor Boskovits writes: > > > Now I have another blocking issue: > > https://github.com/Boskovits/guix/issues/24 > > > Error message: > > > > BUILD FAILED > >

Re: java: switch to icedtea-8 as default JDK

Gábor Boskovits writes: > Now I have another blocking issue: > https://github.com/Boskovits/guix/issues/24 > Error message: > > BUILD FAILED > /tmp/guix-build-java-bsh-2.0b6.drv-0/beanshell-2.0b6/build.xml:654: > Problem: failed to create task or type junit > Cause: the

Re: java: switch to icedtea-8 as default JDK

2017-12-19 10:11 GMT+01:00 Gábor Boskovits : > > > 2017-12-19 9:07 GMT+01:00 Chris Marusich : > >> Hi Gábor and Ricardo, >> >> I see that Gábor made this GitHub issue to track their work: >> >> https://github.com/Boskovits/guix/issues/16 >> >> At this

Re: java: switch to icedtea-8 as default JDK

2017-12-19 9:07 GMT+01:00 Chris Marusich : > Hi Gábor and Ricardo, > > I see that Gábor made this GitHub issue to track their work: > > https://github.com/Boskovits/guix/issues/16 > > At this point, can I help with anything in particular, or should I wait > until after Gábor

Re: java: switch to icedtea-8 as default JDK

Hi Gábor, > We now have an upstream fix for classpathx, it is pushed as revision 1244 > to the savannah subversion repo. > May I change the source to use this revision? Yes, this should be fine. Thanks! -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net

Re: java: switch to icedtea-8 as default JDK

2017-12-17 19:59 GMT+01:00 Gábor Boskovits : > Yes, we could do that, however, I would prefer to fix these if we can. > > > 2017-12-17 15:26 GMT+01:00 Ricardo Wurmus : > >> >> Gábor Boskovits writes: >> >> > Currently I cannot compile

Re: java: switch to icedtea-8 as default JDK

Yes, we could do that, however, I would prefer to fix these if we can. 2017-12-17 15:26 GMT+01:00 Ricardo Wurmus : > > Gábor Boskovits writes: > > > Currently I cannot compile java-aqute-bndlib, > > because java-classpathx-servletapi-3.0 does not work

Re: java: switch to icedtea-8 as default JDK

Gábor Boskovits writes: > Currently I cannot compile java-aqute-bndlib, > because java-classpathx-servletapi-3.0 does not work with java8. > This is a known incompatibility between java7 and java8 definition of Map, > affecting multiple projects. > I will focus on fixing

Re: java: switch to icedtea-8 as default JDK

Yesterday I investigated upgrading java-asm to version 6.0. It pulls in bnd as a dependency. I've not yet checked if we have a new dependecy cycle here... Currently I cannot compile java-aqute-bndlib, because java-classpathx-servletapi-3.0 does not work with java8. This is a known incompatibility

Re: java: switch to icedtea-8 as default JDK

It seems, that it is aslo safe to apply this on master. This is the patch: >From 8a4f7bcbbbefe282c15447907a67f81c5bb60aae Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?G=C3=A1bor=20Boskovits?= Date: Fri, 15 Dec 2017 15:22:03 +0100 Subject: [PATCH] gnu: Clean up depencies of

Re: java: switch to icedtea-8 as default JDK

Ok, it seems, that java-asm does not currently uses test anyway, so I can remove the junit native input. Will check if it is also true on master... 2017-12-15 14:52 GMT+01:00 Gábor Boskovits : > I've found the problem with java-hamcrest-core. > The root cause of this is that

Re: java: switch to icedtea-8 as default JDK

I've found the problem with java-hamcrest-core. The root cause of this is that java-jarjar uses a bundled copy of asm, version 4.0. This asm version does not support icedtea8. I propose to use java-asm instead of the bundled one. In my opinion the best course of action should be: 1. create a

Re: java: switch to icedtea-8 as default JDK

I've built the whole covering on my wip-change-default-java8 branch. The covering is 42 packages. 19 builds fine. 19 does not build because java-hamcrest-core does not build. I'll have a look at this first, this is the most critical. This is the issue link for reference:

Re: java: switch to icedtea-8 as default JDK

The patches I made: This is the trivial: >From f53ad84059786e0769a21a3a90a15189bcf2d61f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?G=C3=A1bor=20Boskovits?= Date: Mon, 11 Dec 2017 21:18:37 +0100 Subject: [PATCH] Change java toolchain defaults to use java8. *

Re: java: switch to icedtea-8 as default JDK

Hello! It was getting quite intractable to see what I was doing, so I started to fill my github issue tracker. Issues are labeled with change-default-java8. 2017-12-13 11:32 GMT+01:00 Efraim Flashner : > On Tue, Dec 12, 2017 at 06:06:52PM -0800, Chris Marusich wrote: > >

Re: java: switch to icedtea-8 as default JDK

On Tue, Dec 12, 2017 at 06:06:52PM -0800, Chris Marusich wrote: > Gábor Boskovits writes: > > > I will wait for your results for now... > > > * kodi@18.0_alpha-7-67fd70f: failed because of "potential infinite > recursion"; also it seems that it's looking for a DTD

Re: java: switch to icedtea-8 as default JDK

error: download from ' https://mirror.hydra.gnu.org/guix/nar/2i6pbhjlwzjcjpfd1jjv67hwg98ms6nw-java-testng-6.12.tar.gz' failed: 504, "Gateway Time-out" I get this for java-testng. It seems reproducible. 2017-12-13 10:59 GMT+01:00 Gábor Boskovits : > java-osgi-service-jdbc ok

Re: java: switch to icedtea-8 as default JDK

java-osgi-service-jdbc ok 2017-12-13 10:54 GMT+01:00 Gábor Boskovits : > clojure ok > > 2017-12-13 9:53 GMT+01:00 Gábor Boskovits : > >> I'll have a look at testng. >> >> 2017-12-13 3:06 GMT+01:00 Chris Marusich : >> >>> Gábor

Re: java: switch to icedtea-8 as default JDK

clojure ok 2017-12-13 9:53 GMT+01:00 Gábor Boskovits : > I'll have a look at testng. > > 2017-12-13 3:06 GMT+01:00 Chris Marusich : > >> Gábor Boskovits writes: >> >> > I will wait for your results for now... >> >> I apologize for

Re: java: switch to icedtea-8 as default JDK

I'll have a look at testng. 2017-12-13 3:06 GMT+01:00 Chris Marusich : > Gábor Boskovits writes: > > > I will wait for your results for now... > > I apologize for the delay. It took 20 hours to build the "covering" of > icedtea on my laptop, and I've

Re: java: switch to icedtea-8 as default JDK

Gábor Boskovits writes: > I will wait for your results for now... I apologize for the delay. It took 20 hours to build the "covering" of icedtea on my laptop, and I've been preoccupied with personal matters. I built commit 9e111db4535b3cd5729e37294ae51d95240334b4, which at

Re: java: switch to icedtea-8 as default JDK

hamcrest-core 1.3 fails. Exception in thread "main" java.lang.NoClassDefFoundError: org/hamcrest/generator/qdox/JavaDocBuilder 2017-12-12 23:49 GMT+01:00 Gábor Boskovits : > r-seurat is ok. > > 2017-12-12 17:57 GMT+01:00 Chris Marusich : > >> Chris

Re: java: switch to icedtea-8 as default JDK

r-seurat is ok. 2017-12-12 17:57 GMT+01:00 Chris Marusich : > Chris Marusich writes: > > > Now that things are hopefully fixed up a bit more in core-updates I am > > trying again to build the "covering" of icedtea to see what still needs > > to be

Re: java: switch to icedtea-8 as default JDK

minced is ok. 2017-12-12 12:30 GMT+01:00 Gábor Boskovits : > Ok I've built ant 1.9.9 with ant/java8 and icedtea8. It is ok. > > 2017-12-10 16:56 GMT+01:00 Gábor Boskovits : > >> I've seen package: >> java-jgit-4.2 explicitly depending on icedtea-7 >>

Re: java: switch to icedtea-8 as default JDK

Ok I've built ant 1.9.9 with ant/java8 and icedtea8. It is ok. 2017-12-10 16:56 GMT+01:00 Gábor Boskovits : > I've seen package: > java-jgit-4.2 explicitly depending on icedtea-7 > other explicit dependencies are for: > icedtea-7 > ant > > These are ok, I believe. > > We

Re: java: switch to icedtea-8 as default JDK

I've seen package: java-jgit-4.2 explicitly depending on icedtea-7 other explicit dependencies are for: icedtea-7 ant These are ok, I believe. We have ant/java8. What is the current status of these two: ant vs ant/java8, is ant/java8 the default? Should we do something with these? 2017-12-08

Re: java: switch to icedtea-8 as default JDK

Ok, hopefully that will work out. However there was a hint yesterday, that newest core-updates is broken again after a recent merge... It might worth to have a look around to see if it's woth to do on an older revision... I will wait for your results for now... Maybe later this weekend I can

Re: java: switch to icedtea-8 as default JDK

Gábor Boskovits writes: > sra-tools2.8.2-1 builds with no problem. Now that things are hopefully fixed up a bit more in core-updates I am trying again to build the "covering" of icedtea to see what still needs to be fixed. I'll let you know how that goes. -- Chris

Re: java: switch to icedtea-8 as default JDK

sra-tools2.8.2-1 builds with no problem. 2017-12-07 18:50 GMT+01:00 Gábor Boskovits : > Hello! > > The gtk+ patch is now in core-updates. > > > 2017-12-05 8:07 GMT+01:00 Gábor Boskovits : > >> FAIL: abicheck.sh >> PASS: pltcheck.sh >>

Re: java: switch to icedtea-8 as default JDK

Hello! The gtk+ patch is now in core-updates. 2017-12-05 8:07 GMT+01:00 Gábor Boskovits : > FAIL: abicheck.sh > PASS: pltcheck.sh > > > Testsuite summary for gtk+ 2.24.31 >

Re: java: switch to icedtea-8 as default JDK

FAIL: abicheck.sh PASS: pltcheck.sh Testsuite summary for gtk+ 2.24.31 # TOTAL: 3 # PASS: 2 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 #

Re: java: switch to icedtea-8 as default JDK

On Mon, Dec 04, 2017 at 04:44:00PM +0100, Gábor Boskovits wrote: > Now that this problem around glibc is resolved, I think I will do some > history rewrite, so that these reverts, reverting the revert does not > show up. > I 'm also willing to rename the branch to have wip in the name, as this

Re: java: switch to icedtea-8 as default JDK

now I'm trying to build sra-tools. 2017-12-04 17:34 GMT+01:00 Gábor Boskovits : > New branch name is: change-default-icedtea-8-wip > > I left the original intact, but that does not have the needed fixes. >

Re: java: switch to icedtea-8 as default JDK

New branch name is: change-default-icedtea-8-wip I left the original intact, but that does not have the needed fixes. Guix refresh shows the following on current core updates: Building the following 39 packages would ensure 202

Re: java: switch to icedtea-8 as default JDK

Now that this problem around glibc is resolved, I think I will do some history rewrite, so that these reverts, reverting the revert does not show up. I 'm also willing to rename the branch to have wip in the name, as this seems to be standard for longer runnig parts. WDYT? 2017-12-04 15:19

Re: java: switch to icedtea-8 as default JDK

Ok, so it seems, that the latest glibc update was made to fix the icu4c thing. It just broke the locales. Fix for that has just been pushed, making core-updates usable again. I pushed to my icedtea branch also. I'm now building it to see what we have now. 2017-12-04 13:59 GMT+01:00 Gábor

Re: java: switch to icedtea-8 as default JDK

Upstream corrected the issue in commit 6913ad65e00bb32417ad39c41d292b976171e27e. It is not yet included in 2.26. The patch is basically the same as I proposed. I think we should get the upstream version. 2017-12-04 13:33 GMT+01:00 Gábor Boskovits : > I think it should

Re: java: switch to icedtea-8 as default JDK

I think it should look like this: --- cdefs.h 2017-12-04 13:27:55.64000 +0100 +++ cdefs.new.h 2017-12-04 13:31:53.82000 +0100 @@ -1,4 +1,4 @@ -/* Copyright (C) 1992-2017 Free Software Foundation, Inc. +y/* Copyright (C) 1992-2017 Free Software Foundation, Inc. This file is part of the

Re: java: switch to icedtea-8 as default JDK

We also have this in bits/floatn.h, but this seems right. #if (defined __x86_64__ \ ? __GNUC_PREREQ (4, 3) \ : (defined __GNU__ ? __GNUC_PREREQ (4, 5) : __GNUC_PREREQ (4, 4))) # define

Re: java: switch to icedtea-8 as default JDK

We have this in cdefs.h: #if __GNUC_PREREQ (4, 9) \ || __glibc_clang_has_extension (c_generic_selections) \ || (!defined __GNUC__ && defined __STDC_VERSION__ \ && __STDC_VERSION__ >= 201112L) # define __HAVE_GENERIC_SELECTION 1 #else # define __HAVE_GENERIC_SELECTION 0 #endif This

Re: java: switch to icedtea-8 as default JDK

This minimal file reproduces the problem in icu4c 60.1 in guix environment icu4c on current core-updates. #include int main(int argc, char **argv) { std::signbit(1); return 0; } It seems, that it is some problem with cmath.h

Re: java: switch to icedtea-8 as default JDK

It seems, that the fix is already included in the 60.1 release for the xlocal problem. I think we can ignore that. 2017-12-03 23:20 GMT+01:00 Gábor Boskovits : > It seems, that they issued that already: > http://bugs.icu-project.org/trac/changeset/40603 > > 2017-12-03 23:08

Re: java: switch to icedtea-8 as default JDK

It seems, that they issued that already: http://bugs.icu-project.org/trac/changeset/40603 2017-12-03 23:08 GMT+01:00 Gábor Boskovits : > Ok, I found this one: > https://sourceware.org/glibc/wiki/Release/2.26#Removal_of_.27xlocale.h.27 > > It seems, that xlocale.h should not

Re: java: switch to icedtea-8 as default JDK

Ok, I found this one: https://sourceware.org/glibc/wiki/Release/2.26#Removal_of_.27xlocale.h.27 It seems, that xlocale.h should not be used as an include, and glibc removed that. So this is ok. The question is if this issue was addressed by icu4c, so we can just go to the next step, or should

Re: java: switch to icedtea-8 as default JDK

I've found that simply reverting the update to icu4c 60 commit brings up the issue you just mentioned, with missing xlocale.h. So it seems, that the one you found introduced the xlocale problem, while 4e080fbb0bb73e181599676f4e1ef5fdc2ba introduces the new error. I think we should deal with

Re: java: switch to icedtea-8 as default JDK

Gábor Boskovits writes: > Any news on this icu4c thing? After about 2 days of running git bisect, my computer has informed me that the first bad commit is 67d527e35e367c9e9e89ec01cda2ce32cabd2d89. This is the first commit where icu4c fails to build on core-updates. The

Re: java: switch to icedtea-8 as default JDK

java-testng also dies on icu4c. It seems like we will have to fix that first to do anything else. 2017-12-03 10:58 GMT+01:00 Gábor Boskovits : > Any news on this icu4c thing? > > We had a problem on core-updates, reverting > ee3ebf1a357bd4eb36a2fa1790a7b549cffb305a > makes

Re: java: switch to icedtea-8 as default JDK

Any news on this icu4c thing? We had a problem on core-updates, reverting ee3ebf1a357bd4eb36a2fa1790a7b549cffb305a makes it usable, it is not the best thing we can do, but in case you meet with encoding related errors after rebase this is a quick fix. I will have a look at this java-testng

Re: java: switch to icedtea-8 as default JDK

Gábor Boskovits writes: > Hello! > > I've just checked the current build status of packages on hyrda. I could > filter out a few that currently seems not to build anyway, we might try to > fix those first. > > I'll send a quick list: > > *java-htsjdk@1.129 -> newer version

Re: java: switch to icedtea-8 as default JDK

Hello! I've just checked the current build status of packages on hyrda. I could filter out a few that currently seems not to build anyway, we might try to fix those first. I'll send a quick list: *java-htsjdk@1.129 -> newer version (2.3.0) in master, does not build; java-testng@6.12

Re: java: switch to icedtea-8 as default JDK

On Wed, Nov 29, 2017 at 10:58:48PM -0800, Chris Marusich wrote: > Chris Marusich writes: > > >> 1) Confirm that these packages build before making changes. If any > >> fail, fix them first if possible. > >> > >> ... > >> > >> I'm going to try step (1) tonight on my

Re: java: switch to icedtea-8 as default JDK

Chris Marusich writes: >> 1) Confirm that these packages build before making changes. If any >> fail, fix them first if possible. >> >> ... >> >> I'm going to try step (1) tonight on my laptop. Is there a way to check >> their build status on Hydra, I wonder? I'm

Re: java: switch to icedtea-8 as default JDK

Chris Marusich writes: >> As first step it is not needed to remove #:jdk icedtea-8 references, >> because I think that simply becomes a noop. Am I right here? >> That can be done as the last step before merging, I guess. > > I think that's right, but I haven't looked

Re: java: switch to icedtea-8 as default JDK

Hi Gábor, > We could split the bootsrap part out of java.scm, to something like > java-bootstrap.scm. I agree that it would be good to separate the language bootstrap from all other packages. > The have a file like java-checkpoint.scm only with definitions like (define > idectea8

Re: java: switch to icedtea-8 as default JDK

Hello! I have a few idea, which could be done in parallel with this. I don't know if they worth considering, but here they are anyways. We could split the bootsrap part out of java.scm, to something like java-bootstrap.scm. We should stick here to specify versions used and not allow defaults.

Re: java: switch to icedtea-8 as default JDK

Chris Marusich writes: > Gábor Boskovits writes: > >> Hello! >> >> I just run a quick grep to see which files might be interesting. >> >> We use ant-build-system in: >> axoloti.scm * >> bioinformatics.scm * >> compression.scm * >> icu4c.scm >> java.scm

Re: java: switch to icedtea-8 as default JDK

Gábor Boskovits writes: > Hello! > > I just run a quick grep to see which files might be interesting. > > We use ant-build-system in: > axoloti.scm * > bioinformatics.scm * > compression.scm * > icu4c.scm > java.scm * > libusb.scm * > music.scm * > textutlis.scm > uml.scm *

Re: java: switch to icedtea-8 as default JDK

Ok, I just made a branch, basically only changing that single line in java.scm. It's base on current core-updates. You can clone from: https://github.com/Boskovits/guix.git branch: change-default-icedtea-8. How do we know where you need further assistance with that? As first step it is not

Re: java: switch to icedtea-8 as default JDK

Hi Gábor, > I guess we could just flip that to icedtea-8, and check what still works. > That would flip the version in the build system also, as it uses "icedtea". Exactly. The call for help is really about dealing with the fallout from this change. I’ve attempted this some time ago when we

Re: java: switch to icedtea-8 as default JDK

Hello! I just run a quick grep to see which files might be interesting. We use ant-build-system in: axoloti.scm * bioinformatics.scm * compression.scm * icu4c.scm java.scm * libusb.scm * music.scm * textutlis.scm uml.scm * version-control.scm * web.scm * xml.scm Only the ant-build system uses

Re: java: switch to icedtea-8 as default JDK

Ricardo Wurmus writes: > Chris Marusich writes: > >> Ricardo Wurmus writes: >> >>> Hi Guix, >>> >>> some of our Java packages now only build with icedtea-8. To avoid >>> incompatibilities we should make icedtea-8 the default and

Re: java: switch to icedtea-8 as default JDK

Chris Marusich writes: > Ricardo Wurmus writes: > >> Hi Guix, >> >> some of our Java packages now only build with icedtea-8. To avoid >> incompatibilities we should make icedtea-8 the default and make sure >> that all packages still build with that

Re: java: switch to icedtea-8 as default JDK

Ricardo Wurmus writes: > Hi Guix, > > some of our Java packages now only build with icedtea-8. To avoid > incompatibilities we should make icedtea-8 the default and make sure > that all packages still build with that version. > > Who would like to help with this? We can do

java: switch to icedtea-8 as default JDK

Hi Guix, some of our Java packages now only build with icedtea-8. To avoid incompatibilities we should make icedtea-8 the default and make sure that all packages still build with that version. Who would like to help with this? We can do this in a separate branch and build it on