Re: pre-push signature hook error reporting [was Re: [PATCH v6] gnu: python-sphinx: Update to 1.4.8.]

2017-01-20 Thread Leo Famulari
On Fri, Jan 20, 2017 at 03:05:42PM +0100, Ludovic Courtès wrote: > For the pre-push hook, the overhead seems reasonable (perhaps we could > limit the range to commits after the first signed commit to avoid > looping for no reason?) and an improvement. I agree that it's reasonable and an

Re: pre-push signature hook error reporting [was Re: [PATCH v6] gnu: python-sphinx: Update to 1.4.8.]

2017-01-20 Thread Ludovic Courtès
Leo Famulari skribis: > On Fri, Jan 13, 2017 at 10:24:00AM -0500, Leo Famulari wrote: >> I bet that you are using the new pre-push hook that verifies commit >> signatures, and you're trying to push some commits that fail the >> signature verification check. >> >> Someone

Re: pre-push signature hook error reporting [was Re: [PATCH v6] gnu: python-sphinx: Update to 1.4.8.]

2017-01-17 Thread Leo Famulari
On Tue, Jan 17, 2017 at 01:56:29PM +0100, Hartmut Goebel wrote: > Am 17.01.2017 um 12:34 schrieb Danny Milosavljevic: > > For minimal improvement (I don't even think it's measureable), try > > `git rev-list HEAD` (backquotes) - it prevents having to spawn a > > subshell. > > Huh? I doubt this.

Re: pre-push signature hook error reporting [was Re: [PATCH v6] gnu: python-sphinx: Update to 1.4.8.]

2017-01-17 Thread Leo Famulari
On Tue, Jan 17, 2017 at 03:55:42PM +0100, Hartmut Goebel wrote: > Am 17.01.2017 um 04:14 schrieb Leo Famulari: > > with `git verify-commit $(git rev-list HEAD)`. This is what the pre-push > > As far as I understand the example hook, it would be possible to do > something like > > git

Re: pre-push signature hook error reporting [was Re: [PATCH v6] gnu: python-sphinx: Update to 1.4.8.]

2017-01-17 Thread Leo Famulari
On Tue, Jan 17, 2017 at 12:34:28PM +0100, Danny Milosavljevic wrote: > Leo Famulari wrote: > > In Git 2.11.0, it seems that `git verify-commit` can't tell the user > > which commits failed verification: > > We should report that upstream and add the one line that does tell

Re: pre-push signature hook error reporting [was Re: [PATCH v6] gnu: python-sphinx: Update to 1.4.8.]

2017-01-17 Thread Hartmut Goebel
Am 17.01.2017 um 12:34 schrieb Danny Milosavljevic: > For minimal improvement (I don't even think it's measureable), try `git > rev-list HEAD` (backquotes) - it prevents having to spawn a subshell. Huh? I doubt this. The bash manual, section "Command Substitution" does not distinguish between

Re: pre-push signature hook error reporting [was Re: [PATCH v6] gnu: python-sphinx: Update to 1.4.8.]

2017-01-17 Thread Danny Milosavljevic
Hi Leo, On Mon, 16 Jan 2017 22:14:14 -0500 Leo Famulari wrote: > In Git 2.11.0, it seems that `git verify-commit` can't tell the user > which commits failed verification: > > https://git.kernel.org/cgit/git/git.git/tree/builtin/verify-commit.c?h=v2.11.0 We should report

pre-push signature hook error reporting [was Re: [PATCH v6] gnu: python-sphinx: Update to 1.4.8.]

2017-01-16 Thread Leo Famulari
On Fri, Jan 13, 2017 at 10:24:00AM -0500, Leo Famulari wrote: > I bet that you are using the new pre-push hook that verifies commit > signatures, and you're trying to push some commits that fail the > signature verification check. > > Someone should add some error reporting to the hook. In Git