> 2. Send all other patches by using the "--in-reply-to=$ABOVE_MESSAGE_ID"
> option. Make sure the patches are in the right order on the command
> line. Example:
>
> git send-email --to=38...@debbugs.gnu.org \
> --in-reply-to='<20200113103304.9093-1-mike.ros...@gmail.com>' \
>
Hi Mike,
> I've have sent some patches to an open bug #38148 in regards to
> qutebrowser being outdated. I'm hoping this will help test out
> qtwebengine and close that bug. Two birds with one stone :)
Qutebrowser 1.9.0 works now, great job!
I've reviewed those patches; fix the few nits and I'll
Pierre Neidhardt writes:
> Hooray!
>
> Thank you Marius, and thank you Mike for the tremendous effort!
>
>> Now we just need some packages using it! :-)
>
> We can get started with Qutebrowser.
Hello Pierre and Marius,
I've have sent some patches to an open bug #38148 in regards to
Pierre Neidhardt writes:
>> Now we just need some packages using it! :-)
>
> We can get started with Qutebrowser.
This was my first thought as well. Though next is also a good candidate
too? :)
If anyone is working on updating quitebrowser let me know. If not I'll
starting working on this
Marius Bakke writes:
> mike.ros...@gmail.com writes:
>
>> I've attached a patch that resolves these suggestions. Along with
>> patches to fix punctuation suggested by Pierre.
>>
>> Complete diff can still be found
>> at. https://gitlab.com/mike.rosset/guix/compare/master...merge-qtwebengine
>>
mike.ros...@gmail.com writes:
> I've attached a patch that resolves these suggestions. Along with
> patches to fix punctuation suggested by Pierre.
>
> Complete diff can still be found
> at. https://gitlab.com/mike.rosset/guix/compare/master...merge-qtwebengine
>
> Marius I've forgot to attach
Pierre Neidhardt writes:
> One more thing:
>
>> +"third_party/widevine/cdm/widevine_cdm_common.h"
>> +"third_party/widevine/cdm/widevine_cdm_version.h"
>
> Why do we preserve those files if we don't build widevine?
They are #include'd by some files
Hartmut Goebel writes:
> Am 07.01.20 um 01:27 schrieb mike.ros...@gmail.com:
>>
>>> With these changes, I think the package is ready to go. \o/
>> This is really great work Marius I appreciate this addition. I was
>> actually just looking at this approach yesterday.
>>
>> I've merged your two
Pierre Neidhardt writes:
> Fantastic, Marius! Some nits below:
>
>> ;;; Copyright © 2019 Marius Bakke
>
> 2020 for Marius?
>
>> + ;; FIXME: libxml2 needs to built with icu support though it links to
>> + ;; libxml2 configure summary still states. Checking for compatible
>> +
Am 07.01.20 um 01:27 schrieb mike.ros...@gmail.com:
>
>> With these changes, I think the package is ready to go. \o/
> This is really great work Marius I appreciate this addition. I was
> actually just looking at this approach yesterday.
>
> I've merged your two patches with one minor
One more thing:
> +"third_party/widevine/cdm/widevine_cdm_common.h"
> +"third_party/widevine/cdm/widevine_cdm_version.h"
Why do we preserve those files if we don't build widevine?
--
Pierre Neidhardt
https://ambrevar.xyz/
signature.asc
Description: PGP
Marius Bakke writes:
> Ricardo Wurmus writes:
>
>> Hi Mike,
>>
>> thank you for your patient reply.
>>
>>> Ricardo Wurmus writes:
>>>
Does the code include DRM support, for example? Does it phone home?
Can we see the patches that upstream applied to the Chromium sources?
>>>
Ricardo Wurmus writes:
> Hi Mike,
>
> thank you for your patient reply.
>
>> Ricardo Wurmus writes:
>>
>>> Does the code include DRM support, for example? Does it phone home?
>>> Can we see the patches that upstream applied to the Chromium sources?
>>>
>>
>> QtWebengine does not handle DRM at
Ricardo Wurmus writes:
> Hi Mike,
>
> thank you for your patient reply.
>
>> Ricardo Wurmus writes:
>>
>>> Does the code include DRM support, for example? Does it phone home?
>>> Can we see the patches that upstream applied to the Chromium sources?
>>>
>>
>> QtWebengine does not handle DRM at
Hi Mike,
thank you for your patient reply.
> Ricardo Wurmus writes:
>
>> Does the code include DRM support, for example? Does it phone home?
>> Can we see the patches that upstream applied to the Chromium sources?
>>
>
> QtWebengine does not handle DRM at all. That is handled by a 3rd party
Hi Mike,
> I've upgraded the description field as request see attached. And CC to
> 35...@debbugs.gnu.org
>
> I've also addressed in depth some Ricardo's concerns.
For me this would be okay. Ricardo needs to state whether his concerns
are covered.
>
Hartmut Goebel writes:
> Am 02.01.20 um 21:24 schrieb mike.ros...@gmail.com:
>> Apologies this is probably a failure in my ML workflow. And just my luck
>> I'm in the process of doing some working related moving todoy. Here is a
>> complete diff
>>
Ricardo Wurmus writes:
> Does the code include DRM support, for example? Does it phone home?
> Can we see the patches that upstream applied to the Chromium sources?
>
QtWebengine does not handle DRM at all. That is handled by a 3rd party
plugin called wildevine and would require guix to bundle
Am 02.01.20 um 21:24 schrieb mike.ros...@gmail.com:
> Apologies this is probably a failure in my ML workflow. And just my luck
> I'm in the process of doing some working related moving todoy. Here is a
> complete diff
> https://gitlab.com/mike.rosset/guix/compare/master...qtwebengine hope
> this
Hartmut Goebel writes:
> Am 01.01.20 um 23:30 schrieb mike.ros...@gmail.com:
>> I think the package is looking pretty good now. I sent some changes
>> requested by Hartmut today so we might need to wait on any more changes
>> he might have.
>
> I tried applying the patches to see the
Am 01.01.20 um 23:30 schrieb mike.ros...@gmail.com:
> I think the package is looking pretty good now. I sent some changes
> requested by Hartmut today so we might need to wait on any more changes
> he might have.
I tried applying the patches to see the complete/compiled diff, but `git
am` failed.
Pierre Neidhardt writes:
> mike.ros...@gmail.com writes:
>
>> My conclusion is this is going to be way more work then the
>> benefits. And once this was achieved it still needs to be
>> maintained. Keep in mind QT already has a patch re base process with
>> changes that might conflict with
Pierre Neidhardt writes:
> Let me know if there are more changes you'd like to include to your
> patch.
> If no one objects, I'll merge it within a week.
>
> Cheers!
I think the package is looking pretty good now. I sent some changes
requested by Hartmut today so we might need to wait on any
Pierre Neidhardt writes:
> Mike, have you tried building the package against ungoogled-chromium?
>
> Either way, I vote for including this package into Guix, it seems mature
> enough.
> We can open an issue to replace the bundled chromium with
> ungoogled-chromium if need be.
Sorry for the
Pierre Neidhardt writes:
> I tested again on an Intel HD Graphics 620.
> Everything works for me so far (navigating, smooth scrolling, rendering).
>
> I tested the following:
>
> - https://gnu.org
> - https://ambrevar.xyz (has some CSS that may required hardware acceleration)
> -
Pierre Neidhardt writes:
> Hmm... On second though, I just navigated GNU.org, which might not
> require GL acceleration. I think I should try with a proper GL test website.
For me the GL issues will cause issues regardless of the website. For
example you can not scroll the page. But the
Pierre Neidhardt writes:
> No problem on my end with an AMD RX 580.
This is surprising but good news none the less. Also I've mailed a
second in the series patch that fixes pulseaudio and address your
comments in the bug tracker. A substitute should be provided for this as
well.
Mike
mike.ros...@gmail.com writes:
> I have a simple CPP for testing it can be found
> here. https://github.com/mrosset/testqt.
>
> for testing I use this enviroment.
>
> --8<---cut here---start->8---
> ./pre-inst-env guix environment --ad-hoc qtbase qtwebengine
Pierre Neidhardt writes:
> Sorry, still no substitute for me for the patch you've sent yesterday.
I tested with a couple of machines and it does server substitutes. maybe
now the substitute cache will have invalidated. or you can manual purge
/var/guix/substitutes. Hopefully this resolves it
mike.ros...@gmail.com writes:
> This should be resolved now. I had to upgrade the vps to avoid OOM
> issues. But as I've now it should serve this substitute.
Sorry, still no substitute for me for the patch you've sent yesterday.
> you can test with.
>
> --8<---cut
Pierre Neidhardt writes:
> The substitution does not apply for me on master.
This should be resolved now. I had to upgrade the vps to avoid OOM
issues. But as I've now it should serve this substitute.
you can test with.
--8<---cut here---start->8---
guix
mike.ros...@gmail.com writes:
> Hartmut Goebel writes:
>
>> Am 16.12.19 um 18:09 schrieb mike.ros...@gmail.com:
>>> I'm currently brushing up my latest qtwebengine build. Will resubmit
>>> this patch. I will also see if I can inherit qtsvg again to put this
>>> back on par with other module
Pierre Neidhardt writes:
> Fantastic!
>
> The pulseaudio and OpenGL issues are not blockers in my opinion. We can
> open new issues about them and resolve them later.
>
>> I can also a substitute if anyone needs them for testing. Since this
>> build can take some time.
>
> Please do! Thanks!
Fantastic!
The pulseaudio and OpenGL issues are not blockers in my opinion. We can
open new issues about them and resolve them later.
> I can also a substitute if anyone needs them for testing. Since this
> build can take some time.
Please do! Thanks!
--
Pierre Neidhardt
Hartmut Goebel writes:
> Am 16.12.19 um 18:09 schrieb mike.ros...@gmail.com:
>> I'm currently brushing up my latest qtwebengine build. Will resubmit
>> this patch. I will also see if I can inherit qtsvg again to put this
>> back on par with other module packages. From there I'll put a simple
>>
Am 16.12.19 um 18:09 schrieb mike.ros...@gmail.com:
> I'm currently brushing up my latest qtwebengine build. Will resubmit
> this patch. I will also see if I can inherit qtsvg again to put this
> back on par with other module packages. From there I'll put a simple
> test example together
Am 16.12.19 um 16:45 schrieb mike.ros...@gmail.com:
> The problem is also not readily obvious until you
> try to use qtwebengine in a library or a program. Which will causes
> locale and translation path issues.
If the only issue with qtwebengine are locale and translation, I suggest
to accept
Hartmut Goebel writes:
> Hi,
>
> I'm glad to see there already has been some effort on this. I'll comment
> on the issue.
>
> Am 16.12.19 um 15:13 schrieb mike.ros...@gmail.com:
>> This new monolithic package stills suffers from the same issue as my
>> modular qtwebengine. In that there are many
Hi,
I'm glad to see there already has been some effort on this. I'll comment
on the issue.
Am 16.12.19 um 15:13 schrieb mike.ros...@gmail.com:
> This new monolithic package stills suffers from the same issue as my
> modular qtwebengine. In that there are many in tree third party
> dependencies.
Pierre Neidhardt writes:
> Mike, can you give some details (maybe one example) on how to replace the
> third-party dependencies? What is holding it back?
>
> I could give it a go if need be.
I have not tackled this problem yet. I've mainly been focused on get the
package to build. I've fixed
Pierre Neidhardt writes:
> Mike Rosset had it working in a patch that's still waiting on the tracker.
> It has at least one issue as far as I get it. Mike also made an
> all-in-one "Qt" package that does not suffer from this issue, a bit like
> our texlive mega-package.
>
> I'm all for adding
Mike, can you give some details (maybe one example) on how to replace the
third-party dependencies? What is holding it back?
I could give it a go if need be.
--
Pierre Neidhardt
https://ambrevar.xyz/
signature.asc
Description: PGP signature
Mike Rosset had it working in a patch that's still waiting on the tracker.
It has at least one issue as far as I get it. Mike also made an
all-in-one "Qt" package that does not suffer from this issue, a bit like
our texlive mega-package.
I'm all for adding it to master.
--
Pierre Neidhardt
Hi Guix!
Looks like we need to package qtwebengine, as more and more packages
require it.
qtwebengine includes a copy of chromium.
Any volunteers?
--
Regards
Hartmut Goebel
| Hartmut Goebel | h.goe...@crazy-compilers.com |
| www.crazy-compilers.com | compilers which you
44 matches
Mail list logo
