Re: [PATCH] Gracefully handle incompatible locale data

2015-10-27 Thread Carlos O'Donell
On 10/27/2015 11:30 AM, Samuel Thibault wrote: > Hello, > > Ludovic Courtès, le Tue 22 Sep 2015 17:27:55 +0200, a écrit : >> loadlocale.c:130: _nl_intern_locale_data: Assertion `cnt < (sizeof >> (_nl_value_type_LC_COLLATE) / sizeof (_nl_value_type_LC_COLLATE[0]))' failed. >> >> This patch chang

Re: [PATCH] Gracefully handle incompatible locale data

2015-10-27 Thread Carlos O'Donell
On 10/13/2015 10:45 AM, Ludovic Courtès wrote: >> - What does localedef --list-archive return? >> >> - The new LC_COLLATE format will make it's way into the binary locale >> archive >> and that means glibc can't read the locale-archive? Does it fail? exit >> code? > > The patch does not ch

Re: [PATCH] system: grub: On MIPS, the linux image name is vmlinuz

2015-10-27 Thread Mark H Weaver
l...@gnu.org (Ludovic Courtès) writes: > I just pushed this and two other non-controversial patches from > ‘wip-loongson2f’. Sounds good, thanks! > I could continue, because the remainder looks OK too at first glance > (mostly I need to test that the new GRUB works fine here), but I thought > I’

Re: [PATCH 1/1] gnu: lua: Build with dynamic library support.

2015-10-27 Thread Leo Famulari
Calling all Lua experts! Or even somebody that has used Lua before! ;) I studied the lua-5.1 and lua-5.2 Makefiles more carefully and I will split this up into separate packages for each version, with some changes. On Tue, Oct 27, 2015, at 11:48, Ludovic Courtès wrote: > By “fixing the flags”, do

Re: [PATCH] system: grub: On MIPS, the linux image name is vmlinuz

2015-10-27 Thread Ludovic Courtès
I just pushed this and two other non-controversial patches from ‘wip-loongson2f’. I could continue, because the remainder looks OK too at first glance (mostly I need to test that the new GRUB works fine here), but I thought I’d leave you a chance to chime in. ;-) So the backlog currently is this

Re: [PATCH] refresh: Support comma separated updater types.

2015-10-27 Thread Ludovic Courtès
Alex Kost skribis: > From 4a5132f171dfe6bac99661e75e7c5e53c4f74116 Mon Sep 17 00:00:00 2001 > From: Alex Kost > Date: Tue, 27 Oct 2015 21:13:05 +0300 > Subject: [PATCH] refresh: Support comma separated updater types. > > * guix/scripts/refresh.scm (%options): Handle comma separated types for >

[PATCH] refresh: Support comma separated updater types.

2015-10-27 Thread Alex Kost
Ludovic Courtès (2015-10-26 00:42 +0300) wrote: > Alex Kost skribis: > >> Ludovic Courtès (2015-10-21 15:54 +0300) wrote: >> >>> Hello! >>> >>> We now have a number of importers, which is great, but so far we had no >>> support to update packages once they had been imported, even though most >>>

Re: [PATCH] upstream: Add 'description' field to 'upstream-updater'.

2015-10-27 Thread Alex Kost
Ludovic Courtès (2015-10-27 20:26 +0300) wrote: > Alex Kost skribis: > >> From 19cee5ca983f663117d272382d7063d48e273cd0 Mon Sep 17 00:00:00 2001 >> From: Alex Kost >> Date: Mon, 26 Oct 2015 21:24:53 +0300 >> Subject: [PATCH] upstream: Add 'description' field to 'upstream-updater'. >> MIME-Versio

Re: [PATCH 15/15] scripts: Add 'container' subcommand.

2015-10-27 Thread Ludovic Courtès
"Thompson, David" skribis: > From f5312c2445d774c9355c947d3c748d064740246e Mon Sep 17 00:00:00 2001 > From: David Thompson > Date: Wed, 1 Jul 2015 20:32:07 -0400 > Subject: [PATCH] scripts: Add 'container' subcommand. > > * guix/scripts/container.scm: New file. > * guix/scripts/container/exec.sc

Re: [PATCH 13/15] scripts: system: Add 'container' action.

2015-10-27 Thread Ludovic Courtès
"Thompson, David" skribis: > From 5dde31ef51502726a2915cc4faba81f4fadb851c Mon Sep 17 00:00:00 2001 > From: David Thompson > Date: Mon, 8 Jun 2015 09:04:38 -0400 > Subject: [PATCH] scripts: system: Add 'container' action. > > * guix/scripts/system.scm (show-help): Display 'container' action. >

Re: [PATCH 03/12] import: pypi: Use "pypi-uri" instead of building the URL manually.

2015-10-27 Thread Ludovic Courtès
Cyril Roelandt skribis: > * guix/import/pypi.scm (make-pypi-sexp): Use "pypi-uri". > * tests/pypi.scm: Update the tests accordingly. LGTM, provided ‘pypi-uri’ does not rely on mirror://, as discussed earlier: https://lists.gnu.org/archive/html/guix-devel/2015-10/msg00347.html Sorry for the d

Re: [PATCH] upstream: Add 'description' field to 'upstream-updater'.

2015-10-27 Thread Ludovic Courtès
Alex Kost skribis: > From 19cee5ca983f663117d272382d7063d48e273cd0 Mon Sep 17 00:00:00 2001 > From: Alex Kost > Date: Mon, 26 Oct 2015 21:24:53 +0300 > Subject: [PATCH] upstream: Add 'description' field to 'upstream-updater'. > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Conten

Re: Inconsistencies in 'guix system' and 'guix package'

2015-10-27 Thread Ludovic Courtès
Alex Kost skribis: > 1. Should 'guix system' actions share the same options? > > I think it is confusing that recently added 'guix system' actions > (dmd-graph, extension-graph and list-generations) can take the same > command-line options as the other system actions (--dry-run, --no-grub, > etc.

Re: [PATCH] Gracefully handle incompatible locale data

2015-10-27 Thread Ludovic Courtès
Samuel Thibault skribis: > Ludovic Courtès, le Tue 22 Sep 2015 17:27:55 +0200, a écrit : >> loadlocale.c:130: _nl_intern_locale_data: Assertion `cnt < (sizeof >> (_nl_value_type_LC_COLLATE) / sizeof (_nl_value_type_LC_COLLATE[0]))' failed. >> >> This patch changes such conditions to return EI

Re: [PATCH] Add MOSAIK.

2015-10-27 Thread Ludovic Courtès
Ricardo Wurmus skribis: > Efraim Flashner writes: [...] >> I ran `./pre-inst-env guix build -s i686-linux mosaik` and the build failed >> for me. > > I can confirm this. Too bad. The reason is that “ssw.c” uses macros > from emmintrin.h that are always inlined. Inlining fails here due to >

Re: [PATCH 1/1] gnu: lua: Build with dynamic library support.

2015-10-27 Thread Ludovic Courtès
Leo Famulari skribis: > On Tue, Oct 27, 2015, at 08:47, Ludovic Courtès wrote: >> Leo Famulari skribis: >> >> > Notably, this enables the use of dynamic libraries with Lua. >> >> A better subject line for the commit would be: >> >> gnu: lua-5.2: Build shared libraries. >> >> AFAICS, the pr

Re: [PATCH] Gracefully handle incompatible locale data

2015-10-27 Thread Samuel Thibault
Hello, Ludovic Courtès, le Tue 22 Sep 2015 17:27:55 +0200, a écrit : > loadlocale.c:130: _nl_intern_locale_data: Assertion `cnt < (sizeof > (_nl_value_type_LC_COLLATE) / sizeof (_nl_value_type_LC_COLLATE[0]))' failed. > > This patch changes such conditions to return EINVAL instead of aborting.

Re: [PATCH] GCJ: run libjava tests.

2015-10-27 Thread Ricardo Wurmus
Ludovic Courtès writes: > Ricardo Wurmus skribis: > >> Attached is a new patch that pulls the ‘#:test-target’ line out of the >> ‘substitute-keyword-arguments’ expression. The indentation of many >> lines changes because of this. ‘git diff -w’ shows that the actual >> change is pretty small.

Inconsistencies in 'guix system' and 'guix package'

2015-10-27 Thread Alex Kost
Hello, 1. Should 'guix system' actions share the same options? I think it is confusing that recently added 'guix system' actions (dmd-graph, extension-graph and list-generations) can take the same command-line options as the other system actions (--dry-run, --no-grub, etc.), because specifying th

Re: [PATCH 1/1] gnu: lua: Build with dynamic library support.

2015-10-27 Thread Leo Famulari
On Tue, Oct 27, 2015, at 08:47, Ludovic Courtès wrote: > Leo Famulari skribis: > > > Notably, this enables the use of dynamic libraries with Lua. > > A better subject line for the commit would be: > > gnu: lua-5.2: Build shared libraries. > > AFAICS, the problem is only with Lua 5.2: > > --

Re: [PATCH] scripts: build: Add --file option.

2015-10-27 Thread Alex Kost
David Thompson (2015-10-27 01:23 +0300) wrote: > diff --git a/doc/guix.texi b/doc/guix.texi > index 7715b72..abd8de3 100644 > --- a/doc/guix.texi > +++ b/doc/guix.texi > @@ -3615,6 +3615,19 @@ The @var{options} may be zero or more of the following: > > @table @code > > +@item --file=@var{file

Re: [PATCH] system: container: Update to new service API.

2015-10-27 Thread Ludovic Courtès
Sorry, I meant to preserve #:container? behavior but I forgot this bit. I believe the attached patch provides an Even Greater Way to address the problem, namely by making the modprobe/firmware thing an optional service. Could you try and report back? I tried it in a VM and there’s no regression.

Re: [PATCH] Add MOSAIK.

2015-10-27 Thread Ricardo Wurmus
Efraim Flashner writes: > On Fri, 23 Oct 2015 10:42:49 +0200 > Ricardo Wurmus wrote: > >> > Mosaik fails on all architectures except for x86_64. Should it be disabled >> > or are there configure flags to make it work elsewhere? >> >> I think this is caused by ‘includes/linux.inc’, which is u

Re: [PATCH 1/1] gnu: lua: Build with dynamic library support.

2015-10-27 Thread Ludovic Courtès
Leo Famulari skribis: > Notably, this enables the use of dynamic libraries with Lua. A better subject line for the commit would be: gnu: lua-5.2: Build shared libraries. AFAICS, the problem is only with Lua 5.2: --8<---cut here---start->8--- $ ls $(guix b

Re: [PATCH] GCJ: run libjava tests.

2015-10-27 Thread Ludovic Courtès
Ricardo Wurmus skribis: > Attached is a new patch that pulls the ‘#:test-target’ line out of the > ‘substitute-keyword-arguments’ expression. The indentation of many > lines changes because of this. ‘git diff -w’ shows that the actual > change is pretty small. [...] > + `(#:test-target "c

Re: [PATCH] gnu: Add xcompmgr

2015-10-27 Thread Ludovic Courtès
Andreas Enge skribis: > On Mon, Oct 26, 2015 at 11:30:40PM +0100, Ludovic Courtès wrote: >> http://cgit.freedesktop.org/xorg/app/xcompmgr/tree/COPYING, which is > > As it is not part of xorg proper, I think it should go to xdisorg.scm. > Are you okay with me moving it there? Fine with me (I wond

Re: [PATCH] Add MOSAIK.

2015-10-27 Thread Efraim Flashner
On Fri, 23 Oct 2015 10:42:49 +0200 Ricardo Wurmus wrote: > > Mosaik fails on all architectures except for x86_64. Should it be disabled > > or are there configure flags to make it work elsewhere? > > I think this is caused by ‘includes/linux.inc’, which is unconditionally > included by default

Re: [PATCH] Fix subread on non-x86_64

2015-10-27 Thread Ricardo Wurmus
Ludovic Courtès writes: > Ricardo Wurmus skribis: > >> the attached patch should fix the build of subread on non-x86_64 by >> overriding the CC and CCFLAGS variables, which by default are set to >> contain a lot of x86_64 optimisations. > > Nice! Could you add a comment explaining that? Sure.

Re: [PATCH] GCJ: run libjava tests.

2015-10-27 Thread Ricardo Wurmus
Ludovic Courtès writes: > ‘substitute-keyword-arguments’ only works if the given keyword appears > in the input: > > (substitute-keyword-arguments '() > ((#:foo _) 'bar)) > > => () > > It might be what’s happening here? You are right, this exactly what happened here. Attached is a new

Re: Environment containers

2015-10-27 Thread Ludovic Courtès
Alex Vong skribis: > On 26/10/2015, Thompson, David wrote: >> On Mon, Oct 26, 2015 at 10:37 AM, Taylan Ulrich Bayırlı/Kammer >> wrote: >> >>> Also, for Debian 8 users and maybe others, this might help: >>> >>> sudo sysctl -w kernel.unprivileged_userns_clone=1 >> >> Yes, user namespaces are

Re: [PATCH 14/15] scripts: environment: Add --container option.

2015-10-27 Thread Ludovic Courtès
Hello! One thing I noticed is that ‘guix environment --container’ behaves sub-optimally when ‘SHELL’ is set or set to the empty string: --8<---cut here---start->8--- $ guix environment alta --pure --container [...] In execvp of /home/ludo/.guix-profile/bin/ba

Re: [PATCH] gnu: Add xcompmgr

2015-10-27 Thread Andreas Enge
On Mon, Oct 26, 2015 at 11:30:40PM +0100, Ludovic Courtès wrote: > http://cgit.freedesktop.org/xorg/app/xcompmgr/tree/COPYING, which is As it is not part of xorg proper, I think it should go to xdisorg.scm. Are you okay with me moving it there? Andreas