Re: guix lint false positives and RFC patch
On 2022-11-05, Ludovic Courtès wrote:
> Vagrant Cascadian skribis:
>> From bfa13fdd3616839883e50efbbc05fb132610ce67 Mon Sep 17 00:00:00 2001
>> From: Vagrant Cascadian
>> Date: Wed, 2 Nov 2022 19:56:12 -0700
>> Subject: [PATCH 01/12] guix: lint: Exclude some "@" symbols from various
>> checks.
>>
>> The visual representation of "@code{}" or similar in the description and
>> synopsis do not include the string, so exclude it from checks to avoid false
>> positives.
>>
>> FIXME handle @command, @file, @acronym, etc.
>>
>> * guix/linx.scm (properly-starts-sentence): Exclude leading "@".
>> (check-synopsis-length): Exclude "@code" and "@acronym".
>
> LGTM! Bonus points for a test in ‘tests/lint.scm’. :-)
No bonus points for me just yet...
diff --git a/tests/lint.scm b/tests/lint.scm
index ce22e2355a..26e93ca37b 100644
--- a/tests/lint.scm
+++ b/tests/lint.scm
@@ -283,6 +283,16 @@ (define (warning-contains? str warnings)
(synopsis (make-string 80 #\X)
(check-synopsis-style pkg
+(test-equal "synopsis: exclude @code from long synopsis"
+ '()
+ (single-lint-warning-message
+ (let ((pkg (dummy-package "x"
+ (synopsis
+ (string-append
+"@code{X}"
+(make-string 72 #\X))
+ (check-synopsis-style pkg
+
(test-equal "synopsis: start with package name"
"synopsis should not start with the package name"
(single-lint-warning-message
The above test doesn't catch this issue, even though the code works on
real packages... I am a bit stumped as to why. I guess '() (or "" which
I also tried) is not a valid way to try to express "this test expects no
warning/error/message/etc."?
Here is a log from the test I cargo-culted:
test-name: synopsis: too long
location: /home/vagrant/src/guix/tests/lint.scm:279
source:
+ (test-equal
+ "synopsis: too long"
+ "synopsis should be less than 80 characters long"
+ (single-lint-warning-message
+ (let ((pkg (dummy-package
+ "x"
+ (synopsis (make-string 80 #\X)
+ (check-synopsis-style pkg
expected-value: "synopsis should be less than 80 characters long"
actual-value: "synopsis should be less than 80 characters long"
result: PASS
And from my test in the patch listed above:
test-name: synopsis: exclude @code from long synopsis
location: /home/vagrant/src/guix/tests/lint.scm:286
source:
+ (test-equal
+ "synopsis: exclude @code from long synopsis"
+ '()
+ (single-lint-warning-message
+ (let ((pkg (dummy-package
+ "x"
+ (synopsis
+(string-append "@code{X}" (make-string 72 #\X))
+ (check-synopsis-style pkg
expected-value: ()
actual-value: #f
actual-error:
+ (match-error "match" "no matching pattern" ())
result: FAIL
What is failing to match what here?
live well,
vagrant
signature.asc
Description: PGP signature
why does make-essential-device-nodes exist?
Hi Guix, make-essential-device-nodes does not seem to have any callers. Can we remove it? -- Ricardo
dependencies or package changed
Would it be possible to add a verbose flag to print what exact transitive dependencies or package changed? For example when I get an output like this: lingot(dependencies or package changed) man-db(dependencies or package changed) newsboat (dependencies or package changed) nss-certs 3.71 → 3.81 recutils (dependencies or package changed) ripgrep (dependencies or package changed) skim (dependencies or package changed) sxiv (dependencies or package changed) tig 2.5.6 → 2.5.7 tokei (dependencies or package changed) tz(dependencies or package changed) vis 0.7 → 0.8 visidata (dependencies or package changed) xclip (dependencies or package changed) xst (dependencies or package changed) ^^ I would like to know what transitive deps changed for xst wdyt, jgart
Re: i586-gnu builds on ci.guix
Hello,
> Alas Cuirass depends on Fibers, which is currently Linux-only¹, so we
> cannot {cross-,}build it for GNU/Hurd. The good news is that
> ‘remote-worker.scm’ itself doesn’t seem to use Fibers. So I wonder if
> we could arrange to build a stripped-down package that contains nothing
> but ‘cuirass-remote-worker’. WDYT?
Yes, Fiber is not used much anymore, except for the web server.
> Cuirass also depends on Avahi, which is currently not buildable for
> GNU/Hurd due to libcap requiring on Linux-specific headers, and it seems
> to be a hard requirement². Unfortunately ‘remote-worker.scm’ requires
> it.
The remote worker is able to discover the remote server using Avahi but
can also connect directly to the server using its IP address. We could
definitely make the Avahi dependency optional.
Thanks,
Mathieu
Re: Guix Ncurses Interface?
On Sat, 12 Nov 2022 21:06:56 +0600 Akib Azmain Turja wrote: > Nice idea. Any resources except emacs-guix source code? Yes, this smalltalk GUI is another resource: https://10years.guix.gnu.org/program/#demo-a-malleable-gui-for-guix https://github.com/khinsen/guix-gtoolkit
GNOME 43
Hi, Is anyone working on upgrading to GNOME 43?
Re: Guix Ncurses Interface?
jgart writes: > Is anyone interested in having an emacs-agnostic ncurses interface for > some aspect of the Guix APIs? > > One thing I thought of just now is a nice transitive dependency explorer > ncurses interface. > > `guix install dag-tui` > > Forgive me Ambrevar, > > jgart > Nice idea. Any resources except emacs-guix source code? -- Akib Azmain Turja, GPG key: 70018CE5819F17A3BBA666AFE74F0EFA922AE7F5 Fediverse: akib@hostux.social Codeberg: akib emailselfdefense.fsf.org | "Nothing can be secure without encryption." signature.asc Description: PGP signature
Re: Release progress, week 5
Hey, >Probably we’ll postpone that post-release and drop i586-gnu from >‘etc/release-manifest.scm’ in the meantime. Objections? No. > - armhf-linux: No progress; can we arrange so that ci.guix at least >builds these core subset of packages? We already have the 'core' specification setup to build armhf-linux packages. I force restarted the latest builds for that specification this way: --8<---cut here---start->8--- update builds set status = -2 where id in (select build from jobs where evaluation = 814784 and system = 'armhf-linux'); --8<---cut here---end--->8--- Thanks, Mathieu
