Re: Suggest improve emacs setting in 'The Perfect Setup'

2022-12-31 Thread Joshua Branson
Feng Shu  writes:

> Hello:
>
> In 'The Perfect Setup', we suggest user to use the below emacs config:
>
> ```
> ;; Assuming the Guix checkout is in ~/src/guix.
> (with-eval-after-load 'geiser-guile
>   (add-to-list 'geiser-guile-load-path "~/src/guix"))
> ```
>
> This config need user to deal with %load-path of guix, which seem to be
> a hard job for new guile user for many dirs of guix and other guix channels,
> why not suggest new user to use the below config:
>

How about you go ahead and make a patch on guix-patc...@gnu.org, that
way this issue is not forgotten?

>
> ```
> (setq geiser-guile-binary (list "guix" "repl"))
> ```
>
>
> or:
>
> ```
> (setq geiser-guile-binary (list "guix" "repl" "-L" 
> "/path/to/user-own-config-dir"))
> ```
>
> when user just want to develop his own guix config, just run:
>
> ```
> emacs
> ```
>
> guix and other channels installed by 'guix pull' will be used properly.
>
> when user want to develop in guix.git, he just run emacs like the below:
>
> ```
> ./pre-inst-env emacs
> ```
>
> The below is my guix emacs config, seem to work:
>
> 
>
> (require 'geiser)
> (require 'geiser-guile)
> (require 'guix)
> (require 'magit)
>
> ;; ** My own guix config.
> (defvar eh-geeguix-dir (expand-file-name "~/geeguix"))
>
> ;; ** Let geiser-guile use 'guix repl'
> (setq geiser-guile-binary (list "guix" "repl" "-L" eh-geeguix-dir))
>
> ;; ** guix-devel-mode
> (add-hook 'scheme-mode-hook #'guix-devel-mode)
>
> ;; ** Get guix dir installed by 'guix pull'.
> (defun eh-guix-dir ()
>   (file-name-as-directory
>(cl-find-if
> (lambda (dir)
>   (file-exists-p (expand-file-name "guix.scm" dir)))
> (directory-files
>  (expand-file-name "~/.cache/guix/checkouts/")
>  t
>
> ;; ** copyright-update
> (when (eh-guix-dir)
>   (let* ((dir (eh-guix-dir))
>  (file (expand-file-name "etc/copyright.el" dir)))
> (when (file-exists-p file)
>   (load-file file)
>   ;; (add-hook 'after-save-hook 'copyright-update)
>   (setq copyright-names-regexp
> (format "%s <%s>" user-full-name user-mail-address)
>
> ;; ** tempel
> (when (eh-guix-dir)
>   (let* ((dir (eh-guix-dir))
>  (path (expand-file-name "etc/snippets/tempel/*" dir)))
> (add-to-list 'tempel-path path)))

I would also add:

(add-hook! 'scheme-mode-hook #'display-fill-column-indicator-mode)

This creates a vertical line that reminds you that your code should fit
inside 80 columns.

Possible also mention how to set up page break lines:

https://github.com/purcell/page-break-lines



Re: 06/06: gnu: samba/fixed: Update to 4.15.13.

2022-12-31 Thread Marius Bakke
Hi Liliana,

guix-comm...@gnu.org skriver:

> lilyp pushed a commit to branch master
> in repository guix.
>
> commit c39db91e51e55e46f177378c7b5a797441dc7d1b
> Author: Liliana Marie Prikler 
> AuthorDate: Sun Dec 18 08:29:07 2022 +0100
>
> gnu: samba/fixed: Update to 4.15.13.
> 
> * gnu/packages/samba.scm (samba/fixed-patched): New variable.
> (samba/fixed): Add replacement for samba/fixed-patched.

[...]

>  (define-public samba/fixed
>;; Version that rarely changes, depended on by libsoup.
>(hidden-package
> -   (package/inherit samba
> +   (package
> + (inherit samba)
> + (replacement samba/fixed-patched)
>   (version "4.15.3")

[...]

> +(define-public samba/fixed-patched
> +  (package
> +(inherit samba/fixed)
> +(version "4.15.13")

This is dangerous: grafts must have exactly the same store name length
since it patches binary files in-place.

I'm surprised the grafting machinery does not bail out when they differ.

I'm assuming this had security impliciations despite not being mentioned
in the commit message or comment and fixed it with
fb5514d3db19b5b405ea75cbe8fbf72d79baea1d instead of reverting.


signature.asc
Description: PGP signature


Re: All updaters are broken

2022-12-31 Thread Ricardo Wurmus


Ricardo Wurmus  writes:

> I haven’t seen these patches on the mailing list or the issue tracker.
> Have they been reviewed?  These changes also break existing tests, which
> should have been run before merging.
>
> Let us please do better and avoid breaking the master branch by
> discussing changes and running tests.

My bad: this *was* in fact discussed here:

https://issues.guix.gnu.org/57460

So… if the changes are here to stay we’ll need to come up with fixes to
the tests and the refresh mechanism.

-- 
Ricardo



All updaters are broken

2022-12-31 Thread Ricardo Wurmus
Hi Guix,

Running “guix refresh -t cran -u” I get this error:

--8<---cut here---start->8---
Backtrace:
In ice-9/boot-9.scm:
  1752:10 18 (with-exception-handler _ _ #:unwind? _ #:unwind-for-type _)
In unknown file:
  17 (apply-smob/0 #)
In ice-9/boot-9.scm:
724:2 16 (call-with-prompt _ _ #)
In ice-9/eval.scm:
619:8 15 (_ #(#(#)))
In guix/ui.scm:
   2276:7 14 (run-guix . _)
  2239:10 13 (run-guix-command _ . _)
In ice-9/boot-9.scm:
  1752:10 12 (with-exception-handler _ _ #:unwind? _ #:unwind-for-type _)
  1752:10 11 (with-exception-handler _ _ #:unwind? _ #:unwind-for-type _)
In guix/store.scm:
   661:37 10 (thunk)
In guix/monads.scm:
576:2  9 (run-with-store # 
# #:guile-for-build …)
In ice-9/eval.scm:
   191:27  8 (_ #(#(# 
#) (# …) …))
In ice-9/boot-9.scm:
152:2  7 (with-fluid* _ _ _)
152:2  6 (with-fluid* _ _ _)
152:2  5 (with-fluid* _ _ _)
In ice-9/eval.scm:
619:8  4 (_ #(#(# 
# (#< name:…>) …)))
In srfi/srfi-1.scm:
634:9  3 (for-each # 
(# …))
In ice-9/eval.scm:
   173:47  2 (_ #(#(# 
# (#< nam…>) …) …))
In ice-9/boot-9.scm:
  1685:16  1 (raise-exception _ #:continuable? _)
  1685:16  0 (raise-exception _ #:continuable? _)

ice-9/boot-9.scm:1685:16: In procedure raise-exception:
In procedure update-spec-package: Wrong type argument: #
--8<---cut here---end--->8---

There’s nothing wrong with the package “node-openzwave-shared”.  The
problem is that for some reason the updater now gets a  value
instead of an .

Commit 8aeccc6240ec45f0bc7bed655e0c8149ae4253eb seems like the problem
here.  Hartmut, can you please fix this?  Otherwise I’d like to revert
this and related commits ASAP.

I haven’t seen these patches on the mailing list or the issue tracker.
Have they been reviewed?  These changes also break existing tests, which
should have been run before merging.

Let us please do better and avoid breaking the master branch by
discussing changes and running tests.

Thanks!

-- 
Ricardo