Re: [Outreachy] - Guix Data Service - Set a more informative page title

2021-04-24 Thread Canan Talayhan
Thanks for your quick response. It helps a lot to me. But still, I have some confusion about the reproduction steps. As I understand it, I can reproduce the slow query just using the pure SQL queries without touching the code for now, right? Please find my steps below: 1. CREATE TEMPORARY TABLE

Re: [Outreachy] [Guix Data Service]: Identify the slow parts of process

2021-05-02 Thread Canan Talayhan
my local db. Am I on the right path for adding new jobs log to my local db? In addition, I've successfully generated simple Flame Graph using Linux perf. It visualizes only the data that was captured while I'm browsing on the Guix Data Service Page. Please find the svg file attached. Thanks, Ca

[Outreachy] [Guix Data Service]: Identify the slow parts of process

2021-04-27 Thread Canan Talayhan
) Now, I'm looking into a specific issue that arises when called insert-missing-data-and-return-all-ids. Thanks, Canan Talayhan

Re: [Outreachy] - Guix Data Service - Set a more informative page title

2021-04-15 Thread Canan Talayhan
it shortly. Patch name: 0001-Set-a-more-informative-page-title-for-any-page On Tue, Apr 13, 2021 at 8:51 PM Maxime Devos wrote: > > On Tue, 2021-04-13 at 18:56 +0300, Canan Talayhan wrote: > > [...] > > After sending the patch I've turned the patch like below. > >

Re: [Outreachy] - Guix Data Service - Set a more informative page title

2021-04-16 Thread Canan Talayhan
t;System tests Revision c7d0441 or ->Revision c7d0441 System tests Should I fix all of them this way? Or just for Channel News Entries? I've set the rule for 80 chars. Thanks. :) On Fri, Apr 16, 2021 at 12:52 AM Christopher Baines wrote: > > > Canan Talayhan writes: > >

Re: [Outreachy] - Guix Data Service - Set a more informative page title

2021-04-18 Thread Canan Talayhan
Baines wrote: > > > Canan Talayhan writes: > > > I've updated the patch that contains all the suggestions. I think the patch > > is ready to merge. > > > > One thing that I would like to ask you about the package and package-name > > in web/repository/contro

[Outreachy] - Guix Data Service - Set a more informative page title

2021-04-13 Thread Canan Talayhan
r comments? I'll be appreciated. Attached file: jobs-title-and-view.diff Thanks, Canan Talayhan MSc. in Computer Engineering Guix IRC: canant guix-data-service/web/jobs/html.scm | 25 + guix-data-service/web/view/html.scm | 11 +++ 2 files changed, 28 insertions

Re: [Outreachy] - Guix Data Service - Set a more informative page title

2021-04-13 Thread Canan Talayhan
We're generating titles using the available h1 value to prevent duplication. Adding space between the id and job could be more readable, I agree. It's done. Thanks for the improvements, Canan Talayhan MSc. in Computer Engineering Guix IRC: canant On Tue, Apr 13, 2021 at 2:58 PM Maxime Devos wrot

Re: [Outreachy] - Guix Data Service - Set a more informative page title

2021-04-18 Thread Canan Talayhan
epository/1/branch/master/package/emacs/ Could you please review the patch attached? I'm very excited to make my first FOSS contribution. :) Thanks for your help, Canan Talayhan On Fri, Apr 16, 2021 at 2:11 PM Christopher Baines wrote: > > Canan Talayhan writes: > > &

Re: [Outreachy] - Guix Data Service - Set a more informative page title

2021-04-21 Thread Canan Talayhan
ss "col-sm-7")),@(if invalid-query? `((h1 "Compare")) `((h1 "Comparing "(a (@ (href ,(string-append "/revision/" base-commit))) (samp ,(string-take base-commit 8) "…"))" and "* I'

Re: [Outreachy] - Guix Data Service - Set a more informative page title

2021-04-23 Thread Canan Talayhan
Talayhan On Thu, Apr 22, 2021 at 10:47 PM Christopher Baines wrote: > > > Canan Talayhan writes: > > > I've missed it unintentionally. I've not touched the "@" sign this time. :) > > > >>> + (define page-header "Comparing") > > &