Ludovic Courtès writes:
> ng0 skribis:
[…]
>> Okay, I will fix it. In the meantime should the additional patch which
>> is unrelated to this change be applied.
>
> Sorry, I’ll let whoever reviewed reply. :-)
That would be me :)
I pushed the patch to
Ludovic Courtès writes:
> Andreas Enge skribis:
>
>> femtolisp fails on mips and arm:
>>http://hydra.gnu.org:3000/build/1472987/nixlog/2/tail-reload
>> with the message
>> In file included from llt/llt.h:6:0,
>> from string.c:16:
>>
Andreas Enge skribis:
> femtolisp fails on mips and arm:
>http://hydra.gnu.org:3000/build/1472987/nixlog/2/tail-reload
> with the message
> In file included from llt/llt.h:6:0,
> from string.c:16:
> llt/utils.h:27:4: error: #error "unknown architecture"
> #
This patch fixes the mistake I had in the previous generation of it
(Scheme -> scheme)
From 597f041ae43ddc85a466ef95a9d1b24c684925d0 Mon Sep 17 00:00:00 2001
From: ng0
Date: Tue, 13 Sep 2016 20:19:57 +
Subject: [PATCH] gnu: femtolisp: Remove custom "patch-makefile"
ng0 writes:
> [ Unknown signature status ]
> From 4061b7fb71a40591dd8e34ee147153aa0d1d9fdc Mon Sep 17 00:00:00 2001
> From: ng0
> Date: Tue, 13 Sep 2016 20:19:57 +
> Subject: [PATCH] gnu: femtolisp: Remove custom "patch-makefile" phase.
Hello,
femtolisp fails on mips and arm:
http://hydra.gnu.org:3000/build/1472987/nixlog/2/tail-reload
with the message
In file included from llt/llt.h:6:0,
from string.c:16:
llt/utils.h:27:4: error: #error "unknown architecture"
# error "unknown architecture"
Should it be
From 4061b7fb71a40591dd8e34ee147153aa0d1d9fdc Mon Sep 17 00:00:00 2001
From: ng0
Date: Tue, 13 Sep 2016 20:19:57 +
Subject: [PATCH] gnu: femtolisp: Remove custom "patch-makefile" phase.
* gnu/packages/lisp.scm (femtolisp)[arguments]: Remove
"patch-makefile" phase;
Ricardo Wurmus writes:
> ng0 writes:
>
>> Ricardo Wurmus writes:
>>> In this case we should probably split these changes up as they are not
>>> related to one another. Alternatively, the summary line should be
>>> changed to
ng0 writes:
> Ricardo Wurmus writes:
>> In this case we should probably split these changes up as they are not
>> related to one another. Alternatively, the summary line should be
>> changed to apply to all of the changes in this patch.
>
> Can
Ricardo Wurmus writes:
> ng0 writes:
>
>> ng0 writes:
>>
>>> [ Unknown signature status ]
>>> Ricardo Wurmus writes:
>>>
Hi,
> I hope the appended patch still applies.
could
ng0 writes:
> ng0 writes:
>
>> [ Unknown signature status ]
>> Ricardo Wurmus writes:
>>
>>> Hi,
>>>
I hope the appended patch still applies.
>>>
>>> could you please send a new, complete patch?
>>>
>>> You seem to
ng0 writes:
> [ Unknown signature status ]
> Ricardo Wurmus writes:
>
>> Hi,
>>
>>> I hope the appended patch still applies.
>>
>> could you please send a new, complete patch?
>>
>> You seem to have removed the “#t” from the “install” phase
>>
Ricardo Wurmus writes:
> Hi,
>
>> I hope the appended patch still applies.
>
> could you please send a new, complete patch?
>
> You seem to have removed the “#t” from the “install” phase
> accidentally. The return value should be kept.
>
> ~~ Ricardo
>
>
From
Hi,
> I hope the appended patch still applies.
could you please send a new, complete patch?
You seem to have removed the “#t” from the “install” phase
accidentally. The return value should be kept.
~~ Ricardo
I hope the appended patch still applies.
Ricardo Wurmus writes:
> ng0 writes:
>
>> * gnu/packages/lisp.scm (femtolisp): New variable.
>> ---
>> gnu/packages/lisp.scm | 53
>> +++
>> 1 file changed,
Hi,
thanks for reviewing
Ricardo Wurmus writes:
> ng0 writes:
>
>> * gnu/packages/lisp.scm (femtolisp): New variable.
>> ---
>> gnu/packages/lisp.scm | 53
>> +++
>> 1 file changed, 53
On Mon, Sep 12, 2016 at 01:57:55PM +, ng0 wrote:
> * gnu/packages/lisp.scm (femtolisp): New variable.
Thanks! Pushed with the following minor changes:
> + (let* ((commit "68c5b1225572ecf2c52baf62f928063e5a30511b")
> +(revision "1"))
I made it use (let) instead of (let*). The
ng0 writes:
> * gnu/packages/lisp.scm (femtolisp): New variable.
> ---
> gnu/packages/lisp.scm | 53
> +++
> 1 file changed, 53 insertions(+)
>
> diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
> index
* gnu/packages/lisp.scm (femtolisp): New variable.
---
gnu/packages/lisp.scm | 53 +++
1 file changed, 53 insertions(+)
diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
index 8ee249d..4e2ecdb 100644
--- a/gnu/packages/lisp.scm
+++
19 matches
Mail list logo