Re: [PATCH 1/2] system: Rename grub to bootloader.

2017-01-14 Thread Ludovic Courtès
David Craven skribis: > I need to study for my exams the next week or two, but my current > thinking on the next steps to accomplish the goal of being bootloader > agnostic are: > > 1. discard in gnu/system/grub in favor of > from gnu/system - small api changes Not sure what

Re: [PATCH 1/2] system: Rename grub to bootloader.

2017-01-12 Thread Chris Marusich
l...@gnu.org (Ludovic Courtès) writes: > Hi! > > David Craven skribis: > >> These three files should be bootloader agnostic. This doesn't make >> them that yet, but it is a first step in that direction. > > I’d rather consider these patches it as part of a series that actually >

Re: [PATCH 1/2] system: Rename grub to bootloader.

2017-01-12 Thread David Craven
I agree on this patch. The renaming is not very good and breaks things. It needs to be done in smaller steps. The one that renames the flag could be done dough, since that doesn't break anything and changes the cli interface. The sooner we can do that the better IMO, because it is a user facing

Re: [PATCH 1/2] system: Rename grub to bootloader.

2017-01-12 Thread Ludovic Courtès
Hi! David Craven skribis: > These three files should be bootloader agnostic. This doesn't make > them that yet, but it is a first step in that direction. I’d rather consider these patches it as part of a series that actually adds support for another bootloader (especially

Re: [PATCH 1/2] system: Rename grub to bootloader.

2017-01-10 Thread Danny Milosavljevic
Hi David, LTGM! Thanks for taking care of this.

Re: [PATCH 1/2] system: Rename grub to bootloader.

2017-01-10 Thread David Craven
These three files should be bootloader agnostic. This doesn't make them that yet, but it is a first step in that direction.

[PATCH 1/2] system: Rename grub to bootloader.

2017-01-10 Thread David Craven
* gnu/system.scm (operating-system-bootloader-configuration-file, kernel->bootloader-label, bootloader-device): Rename variables. * guix/scripts/system.scm (install-bootloader*, profile-bootloader-entries, system->bootloader-entry): Rename variables. (install, perform-action,