Re: [PATCH 4/7] gnu: Add spice-gtk.

2016-07-28 Thread Leo Famulari
On Sun, Jul 24, 2016 at 07:52:27PM +0200, David Craven wrote: > * gnu/packages/spice.scm: Add it. > +(define-public spice-gtk Pushed with a standard commit message, thanks!

Re: [PATCH 4/7] gnu: Add spice-gtk.

2016-07-28 Thread Leo Famulari
On Mon, Jul 25, 2016 at 12:14:57AM +0200, Ludovic Courtès wrote: > David Craven skribis: > > > What are valid reasons to propagate inputs? > > If an installed .h file of spice-gtk #includes a .h file of a > dependency, that dependency should be a propagated input. Likewise if

Re: [PATCH 4/7] gnu: Add spice-gtk.

2016-07-28 Thread David Craven
Hi Leo and Ludo! Thanks! Just wasn't sure if you (Leo) had archived this thread =P

Re: [PATCH 4/7] gnu: Add spice-gtk.

2016-07-27 Thread Leo Famulari
To: David Craven <da...@craven.ch> Cc: Leo Famulari <l...@famulari.name>, guix-devel <guix-devel@gnu.org> Subject: Re: [PATCH 4/7] gnu: Add spice-gtk. Hi David, David Craven <da...@craven.ch> skribis: > I'm not sure if you still expect me to do something and what that i

Re: [PATCH 4/7] gnu: Add spice-gtk.

2016-07-27 Thread Ludovic Courtès
Hi David, David Craven skribis: > I'm not sure if you still expect me to do something and what that is exactly. Oops, I thought Leo was taking care of this patch series. Leo? > But maybe we shouldn't propagate pkg-config inputs. Not sure what you mean. As I wrote, if the

Re: [PATCH 4/7] gnu: Add spice-gtk.

2016-07-27 Thread David Craven
I'm not sure if you still expect me to do something and what that is exactly. But maybe we shouldn't propagate pkg-config inputs. I'm currently trying to get a package to not pick up optional x11 dependencies that are propagated by mesa...

Re: [PATCH 4/7] gnu: Add spice-gtk.

2016-07-25 Thread David Craven
> Likewise if its .pc file “Requires” the .pc file of a dependency. Maybe we want to patch pkg-config to not check for propagated dependencies? > If an installed .h file of spice-gtk #includes a .h file of a > dependency, that dependency should be a propagated input. > Likewise if its .pc file

Re: [PATCH 4/7] gnu: Add spice-gtk.

2016-07-24 Thread Ludovic Courtès
David Craven skribis: > What are valid reasons to propagate inputs? If an installed .h file of spice-gtk #includes a .h file of a dependency, that dependency should be a propagated input. Likewise if its .pc file “Requires” the .pc file of a dependency. For additional

Re: [PATCH 4/7] gnu: Add spice-gtk.

2016-07-24 Thread David Craven
So is this a valid use case for propagated inputs? Making sure that packages that use spice-gtk use the same gstreamer plugins?

[PATCH 4/7] gnu: Add spice-gtk.

2016-07-24 Thread David Craven
* gnu/packages/spice.scm: Add it. --- gnu/packages/spice.scm | 72 ++ 1 file changed, 72 insertions(+) diff --git a/gnu/packages/spice.scm b/gnu/packages/spice.scm index 6c6fbed..ee29f08 100644 --- a/gnu/packages/spice.scm +++

Re: [PATCH 4/7] gnu: Add spice-gtk.

2016-07-24 Thread Leo Famulari
On Sun, Jul 24, 2016 at 01:34:13PM +0200, David Craven wrote: > What are valid reasons to propagate inputs? Ideally, dependencies can be found by their callers with an absolute path to /gnu/store/...-foo. But, some software lacks this facility, and can only find dependencies in the environment,

Re: [PATCH 4/7] gnu: Add spice-gtk.

2016-07-24 Thread David Craven
What are valid reasons to propagate inputs?

Re: [PATCH 4/7] gnu: Add spice-gtk.

2016-07-24 Thread David Craven
> Can you say why these are propagated? spice-protocol shouldn't be progagated. I propagated the gstreamer plugins so that the 'wrap-remote-viewer phase in the virt-viewer package works. I didn't want to add them to virt-viewer since which plugins are needed can depend on the configure-flags of

Re: [PATCH 4/7] gnu: Add spice-gtk.

2016-07-23 Thread Leo Famulari
On Sat, Jul 23, 2016 at 03:18:56PM +0200, David Craven wrote: > * gnu/packages/spice.scm: Add it. > +(define-public spice-gtk > +(propagated-inputs > + `(("gstreamer" ,gstreamer) > +("gst-libav" ,gst-libav) > +("gst-plugins-base" ,gst-plugins-base) > +

[PATCH 4/7] gnu: Add spice-gtk.

2016-07-23 Thread David Craven
* gnu/packages/spice.scm: Add it. --- gnu/packages/spice.scm | 71 ++ 1 file changed, 71 insertions(+) diff --git a/gnu/packages/spice.scm b/gnu/packages/spice.scm index b571818..aa331db 100644 --- a/gnu/packages/spice.scm +++