Re: 04/07: guix: Add compression module.

2022-09-12 Thread Mathieu Othacehe


Hey Ludo,

> While I agree this should be factorize, I wonder if this should be
> promoted to (guix compression).  The module name intuitively is a better
> fit for the compression-related things currently in (guix utils).
>
> Not sure, maybe (gnu compression) would make more sense?

Thanks for noticing that. I moved this module to (gnu compression),
checked that make as-derivation is working and updated the wip-image
branch accordingly.

Mathieu



Re: 04/07: guix: Add compression module.

2022-09-11 Thread Ludovic Courtès
Hi Mathieu,

That’s a long-overdue factorization, but…

guix-comm...@gnu.org skribis:

> +(define-module (guix compression)
> +  #:use-module (guix gexp)
> +  #:use-module (guix ui)
> +  #:use-module ((gnu packages compression) #:hide (zip))

… a (guix …) module Should Not refer to a (gnu …) module¹.  When it
really has to, it should be via lazy-loading at run time, as is done in
(guix build-system …).

While I agree this should be factorize, I wonder if this should be
promoted to (guix compression).  The module name intuitively is a better
fit for the compression-related things currently in (guix utils).

Not sure, maybe (gnu compression) would make more sense?

Ludo’.

¹ For questions of abstraction layering, and also because that’d break
  “make as-derivation”.