Re: 07/07: guix: python-build-system: Fix an outdated comment.
Danny Milosavljevicskribis: >> Sorry, I didn't realize that altering comments here would have an >> effect; I would have warned Hartmut if I had. > > Out of curiousity, why does it have an effect? The file is imported in the build environment (chroot) of all the packages that use ‘python-build-system’. It’s an input of the derivation of those packages, so when it changes, all these derivations change. Hartmut Goebel skribis: >> Sorry, I didn't realize that altering comments here would have an >> effect; I would have warned Hartmut if I had. > > I'm sorry, too. I didn't expect that changing a comment would have any > impact on building packages. Aren't the the files converted to some > canonical form prior to deciding whether they changed? No. There’s no “decision” as to whether they changed; instead, they just happen to be part of the hash of the output file name. That said, don’t be sorry gentlefolks: these things happen. ;-) Ludo’.
Re: 07/07: guix: python-build-system: Fix an outdated comment.
Am 13.10.2016 um 21:39 schrieb Leo Famulari: >> > This change triggered over 6300 rebuilds on 'master'. I reverted it. >> > Please beware that changing some files in guix/build/*.scm can trigger a >> > large number of rebuilds, because some of these files are implicitly >> > used as inputs to a large number of builds. > Sorry, I didn't realize that altering comments here would have an > effect; I would have warned Hartmut if I had. I'm sorry, too. I didn't expect that changing a comment would have any impact on building packages. Aren't the the files converted to some canonical form prior to deciding whether they changed? (I'll take this change to the wip-python-build-system). -- Regards Hartmut Goebel | Hartmut Goebel | h.goe...@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible |
Re: 07/07: guix: python-build-system: Fix an outdated comment.
> Sorry, I didn't realize that altering comments here would have an > effect; I would have warned Hartmut if I had. Out of curiousity, why does it have an effect?
Re: 07/07: guix: python-build-system: Fix an outdated comment.
h.goe...@crazy-compilers.com (Hartmut Goebel) writes: > htgoebel pushed a commit to branch master > in repository guix. > > commit 635a7af45d6e2105ad65d1a9531126cc232a2a50 > Author: Hartmut Goebel> Date: Sun Oct 2 18:48:56 2016 +0200 > > guix: python-build-system: Fix an outdated comment. > > The python-build-system uses phases the build and install, but not > configure. So the old comment was plain wrong since Sept. 2013, when the > build > phase has been added. > --- > guix/build/python-build-system.scm |3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/guix/build/python-build-system.scm > b/guix/build/python-build-system.scm > index 9109fb4..e906e60 100644 > --- a/guix/build/python-build-system.scm > +++ b/guix/build/python-build-system.scm > @@ -137,8 +137,7 @@ installed with setuptools." > #t)) > > (define %standard-phases > - ;; 'configure' and 'build' phases are not needed. Everything is done > during > - ;; 'install'. > + ;; 'configure' phase is not needed. >(modify-phases gnu:%standard-phases > (add-after 'unpack 'ensure-no-mtimes-pre-1980 ensure-no-mtimes-pre-1980) > (delete 'configure) This change triggered over 6300 rebuilds on 'master'. I reverted it. Please beware that changing some files in guix/build/*.scm can trigger a large number of rebuilds, because some of these files are implicitly used as inputs to a large number of builds. Regards, Mark